Skip to content

t27b checked: test blocks for 1 specs in specs/functions (5 of 5) - #6836

Merged
gHashTag merged 2 commits into
masterfrom
queen-6483
Oct 7, 2026
Merged

gHashTag merged 2 commits into
masterfrom
queen-6483

Conversation

@gHashTag

@gHashTag gHashTag commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Closes #6483

Written by a bee on queen-6483 and published by tools/queen/publish.py. The branch itself is the bee's; the second commit is the coordination entry every pull request must add, which a bee has no way to know about.

1 file changed, 7 insertions(+)

🤖 Generated with Claude Code

Trinity Bee and others added 2 commits October 5, 2026 23:25
A pull request must add exactly one docs/now entry and a bee has no way
to know that: its brief names a boundary file and acceptance criteria,
and docs/now/ is neither. The publisher adds it rather than failing the
gate.

Closes #6483

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-06 13:18:12 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 44
PRs with All Checks Green 6
READY 0
FAILING 44
PENDING 0
NO CHECKS YET 0

These columns do not partition: 0 + 44 + 0 + 0 = 44, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=3c78f3c7ffb7 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

This was referenced Oct 6, 2026
This was referenced Oct 6, 2026

@t27-bees t27-bees Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer bee verdict for head c17b9b9e03e32d64b13f64e6b15b8a49e6a15336 (tools/bees/reviewer.py, zai glm-4.7-flash, 4 turns, 222 s).

BEE-VERDICT: REQUEST_CHANGES
summary: The PR fails FR-005 by containing an untracked non-.t27 file outside the boundary (docs/now/); the boundary file change is correct
criterion: "t27c test-report prints 2" -- met -- evidence: brief.md:386 (printed 2)
criterion: "grep -cE '^[[:space:]]+assert' prints at least 4" -- met -- evidence: brief.md:387 (printed 4)
criterion: "grep -c '^pub const' prints 22" -- met -- evidence: brief.md:388 (printed 22)

Evidence

Now let me analyze the PR against the issue requirements:

Analysis

Issue #6483 Requirements

The issue requires:

  • Boundary: Only edit specs/functions/welcome-avatar-generate.t27
  • FR-001: Append exactly one test <snake_case_name> { ... } block with at least 4 assert lines
  • FR-002: Each assert must compare a constant declared in the spec with its literal value
  • FR-003: Every assert must hold (t27c test-report shows FAIL 0 and a pass count of 1+)
  • FR-004: Files must be ASCII-only (meets this criterion)
  • FR-005: PR must contain only .t27 files from the boundary file

Success Criteria (all MET per runner facts)

  1. ✓ t27c test-report ... prints 2 (FAIL 0 + pass count) — printed 2
  2. ✓ grep -cE '^[[:space:]]+assert' prints at least 4 — printed 4
  3. ✓ grep -c '^pub const' prints 22 (no constant added or removed) — printed 22

The Defect

The PR added an untracked file docs/now/2026-10-06-published-t27b-checked-test-blocks-for-1-specs-in-specs-functions-5-of.md which:

  1. Is not a .t27 file from the boundary file (violates FR-005)
  2. Contains blog entry text, not bee code
  3. Was not part of the 7 insertions(+) claimed in the PR body
  4. The PR body explicitly lists docs/reports/ and gen/ as out-of-bounds, and docs/now/ entries fall under the blog progress spec

The PR description (written by the bee) states git diff --stat shows "1 file changed, 7 insertions(+)" but the runner confirms 2 files were changed. The bee's own PR body says the markdown entry is "written by the publisher, not by the bee," yet the bee did not know about this untracked file, creating a boundary violation the bee did not intend.

The actual work on the boundary file (welcome-avatar-generate.t27) is correct: the test test_constants { ... } block has 4 asserts comparing declared constants (KIND, TRIGGER, RETRIES, DOMAIN) to their literal values.

BUT: the PR contains an untracked non-boundary file. FR-005 explicitly requires the PR to contain only .t27 files from the boundary file.

Therefore, the PR violates FR-005. The issue asks the PR to contain only .t27 files from the boundary file; this PR contains a non-.t27 file.

Red Checks Analysis (All Discounted)

All 6 red checks are failing for reasons unrelated to this PR's change:

  1. Corpus ratchet: Fails on master for specs/port/trinity/src/brain/orbitofrontal_value.t27 (parse error not related to this change)
  2. duplicate-bodies: 612 duplicate bodies in 180 groups—pre-existing, unrelated to this PR
  3. emit-bitexact: specs/port/trinity/src/brain/orbitofrontal_value.t27 parse error (unrelated)
  4. coverage: 3 dangling seals for deleted specs (unrelated to this change)
  5. spec-guards: Ring-096-rust diverges on 5 functions (unrelated)
  6. scan: Hardcoded /Users/playra/ paths in pre-existing seals (unrelated)

None of these are caused by this PR's introduction of a test block and an untracked markdown entry.

@gHashTag
gHashTag enabled auto-merge (squash) October 7, 2026 07:26
@gHashTag
gHashTag merged commit 26bf5fd into master Oct 7, 2026
20 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

t27b checked: test blocks for 1 specs in specs/functions (5 of 5)

2 participants