Skip to content

Spec: the card-chat night watch (specs/automation/card-chat-night-watch.t27) - #6863

Open
gHashTag wants to merge 2 commits into
masterfrom
queen-5701
Open

gHashTag wants to merge 2 commits into
masterfrom
queen-5701

Conversation

@gHashTag

@gHashTag gHashTag commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Closes #5701

Part of EPIC #5388. Adds specs/automation/card-chat-night-watch.t27: the verdict constants (CHECK_*), the report constants (REPORT_*) and the functions night_verdict, night_report and night_counts_ok for the card-chat night watch, with their tests. The branch queen-5701 was judged accept by the Queen at 76fe195 but no pull request had been opened; this opens it.

Checked locally on 76fe195 with the prebuilt t27c:

  • t27c spec-status specs/automation/card-chat-night-watch.t27 -> IMPLEMENTED
  • t27c test-report specs/automation/card-chat-night-watch.t27 -> 17 tests, 17 pass, FAIL 0
  • The three function, constant and test-count greps from the issue's success criteria pass (3 / >=8 / >=8).
  • git diff --stat origin/master...queen-5701: 1 file changed, 146 insertions(+) -- only the spec.

Known: the first commit is the publisher's salvage commit, whose message carries Issue: #5701 rather than Closes/Refs, so the per-commit L1 TRACEABILITY check is expected to be red on it, as on #6747. The branch also carries no docs/now/ entry.

Opened by reviewer-bee-t27-5700; not merged by the opener.

🤖 Generated with Claude Code

Trinity Bee added 2 commits October 3, 2026 13:03
The turn ended with these files edited and never committed. Uncommitted
work is invisible to the review - it reads the branch - so the attempt
would have been released as empty and the next bee would have started
beside this work rather than from it.

This commit is not a claim that the work is correct. It is the bee's
work, committed on its behalf, and it is judged exactly like any other:
the adversarial reviewer reads it, the compiler runs on it, and the
issue's own criteria are measured against it.

Issue: #5701
Turn: cddc37e8-07d6-43ab-8f05-c4475d97706e
Ending: finished (the turn closed)
Committed: 1 path(s)
Left uncommitted: 0 path(s) outside the declared boundary
- Add u8 verdict constants: CHECK_PASS, CHECK_FAIL, CHECK_UNMEASURED
- Add u8 report constants: REPORT_SILENT, REPORT_OPEN_ISSUE, REPORT_COMMENT, REPORT_CLOSE_ISSUE, REPORT_LEAVE_AS_IS
- Add CARD_CHECK_VERDICTS constant (value: 4)
- Implement night_verdict function: any fail -> FAIL; else any unmeasured -> UNMEASURED; else PASS
- Implement night_report function: FAIL + no issue -> OPEN_ISSUE; FAIL + issue -> COMMENT; PASS + issue -> CLOSE_ISSUE; PASS + no issue -> SILENT; UNMEASURED -> LEAVE_AS_IS; verdict > 2 -> LEAVE_AS_IS
- Implement night_counts_ok function: true when fails + unmeasured <= CARD_CHECK_VERDICTS
- Add comprehensive tests covering all scenarios including user stories
- All 17 tests pass, meeting all acceptance criteria

Closes #5701
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-06 14:09:44 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 36
PRs with All Checks Green 14
READY 0
FAILING 36
PENDING 0
NO CHECKS YET 0

These columns do not partition: 0 + 36 + 0 + 0 = 36, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=3c78f3c7ffb7 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

This was referenced Oct 6, 2026
This was referenced Oct 6, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spec: the card-chat night watch -- open, comment, close or leave the regression issue (specs/automation/card-chat-night-watch.t27)

1 participant