Skip to content

specs/functions: render-job-run, morph-images-generate -- a failed delivery is not delivered - #4123

Merged
gHashTag merged 1 commit into
masterfrom
delivery-spec
Oct 2, 2026
Merged

gHashTag merged 1 commit into
masterfrom
delivery-spec

Conversation

@gHashTag

Copy link
Copy Markdown
Owner

Closes #4122

Plan: 999-multibots-telegraf docs/audit/inngest-improvement-plan-2026-09-13.md, money section (render-job-run callback, morph delivery).

  • render-job-run NOTE: sendCallback rethrows, the callback step fails and retries, after RETRIES the run fails and onFailure messages the admin. The plan's mkdir -p is recorded as not needed (Windows host, ssh.exec resolves on any exit code).
  • morph-images-generate SIDE_EFFECTS: charges-balance removed -- the file only reads the balance (getUserBalance), nothing deducts. NOTE records the { source } delivery, the rethrow instead of a fake link fallback, and that the paid Kling calls stay unmetered.
  • docs/now/2026-09-17-a-delivery-that-fails-does-not-report-delivered.md.
  • Compiler verdict clean on both specs (typecheckOk, 0 errors, hirOk). ASCII only. Pre-existing published_figures drift untouched.

Code: 999-multibots-telegraf branch delivery-fixes.

@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-09-17 09:31:24 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 0
PRs with All Checks Green 50
READY 0
FAILING 0
PENDING 0
NO CHECKS YET 0

These columns do not partition: 0 + 0 + 0 + 0 = 0, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=8932aae0c5a9 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

This was referenced Sep 17, 2026
This was referenced Oct 2, 2026
@gHashTag gHashTag added the bee-reviewed A reviewer bee reviewed and verified this PR at its current head; the only merge signal (#5525) label Oct 2, 2026
@gHashTag

gHashTag commented Oct 2, 2026

Copy link
Copy Markdown
Owner Author

Reviewer bee X. Evidence on master 6111696 + this diff (fresh clone): both specs parse and the parse ratchet passes against current master. The host behaviour these NOTEs record is on 999-multibots-telegraf main: landed in 999 PR #2511, guarded by deliveryIsNotSwallowed.test.ts. Required validate / check-linked-issue green; parse-ratchet context predates this branch, so re-running CI via close/reopen (no push).

@gHashTag gHashTag closed this Oct 2, 2026
@gHashTag gHashTag reopened this Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@gHashTag
gHashTag merged commit d3cad55 into master Oct 2, 2026
49 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bee-reviewed A reviewer bee reviewed and verified this PR at its current head; the only merge signal (#5525)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spec render-job-run and morph-images-generate: a delivery that fails must not report delivered

1 participant