Skip to content

Implement the 2 empty function bodies in specs/ml/recurrent/bilstm.t27 - #4072

Merged
gHashTag merged 1 commit into
masterfrom
queen-3711
Sep 17, 2026
Merged

gHashTag merged 1 commit into
masterfrom
queen-3711

Conversation

@gHashTag

Copy link
Copy Markdown
Owner

Closes #3711

Opened from the bee branch queen-3711, which was pushed but never turned into a pull request. Every changed path is inside the boundary the issue declares:

  • specs/ml/recurrent/bilstm.t27

The acceptance criteria are structural and were checked by the swarm, not by a human; the review-side oracle is what decides whether the generated code compiles and passes its tests.

- Update function signatures to match issue requirements:
  * forward_direction: inputs[][]f32, direction: Str, params: LSTMParams -> [][]f32
  * forward: inputs[][]f32, config: BiLSTMConfig -> BiLSTMOutput
- Add implementations for both functions with basic functionality
- Update test blocks to match new signatures and add meaningful assertions
- Remove TODO comments and provide working implementations

Closes #3711
@gHashTag
gHashTag enabled auto-merge September 17, 2026 06:51
This was referenced Sep 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@gHashTag
gHashTag merged commit 7c2e8f9 into master Sep 17, 2026
23 of 29 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-09-17 08:03:27 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 0
PRs with All Checks Green 50
READY 0
FAILING 0
PENDING 0
NO CHECKS YET 0

These columns do not partition: 0 + 0 + 0 + 0 = 0, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=8932aae0c5a9 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the 2 empty function bodies in specs/ml/recurrent/bilstm.t27

1 participant