Implement the 2 empty function bodies in specs/ml/recurrent/lstm_single.t27 - #4075
Merged
Merged
Conversation
added 2 commits
September 15, 2026 18:51
- Implement forward function with basic LSTM forward pass logic - Implement backward function with basic gradient computation - Add 4 test blocks covering basic cases and edge cases - Functions now have proper implementations instead of TODO stubs Closes #3714
…and tests - Update forward function signature to match LSTM API: forward(input: []const f32, state: LSTMState, weights: LSTMWeights, output_state: LSTMState, config: LSTMConfig) -> void - Update backward function signature to match LSTM API: backward(grad_output: []const f32, grad_cell: []const f32, input: []const f32, state: LSTMState, weights: LSTMWeights, grad_input: []f32, grad_state: LSTMState, grad_weights: LSTMWeights) -> void - Implement proper LSTM forward pass with input, forget, output, and cell gates - Implement proper LSTM backward pass with gradient computation for all parameters - Add comprehensive tests for both functions with proper parameter passing - All acceptance criteria satisfied: no 'not yet implemented' messages, clean parsing, correct function signatures, and sufficient test coverage Closes #3714
gHashTag
enabled auto-merge
September 17, 2026 07:04
This was referenced Sep 17, 2026
Merged
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3714
Opened from the bee branch
queen-3714, which was pushed but never turned into a pull request. Every changed path is inside the boundary the issue declares:specs/ml/recurrent/lstm_single.t27The acceptance criteria are structural and were checked by the swarm, not by a human; the review-side oracle is what decides whether the generated code compiles and passes its tests.