fix(ci): ledger the two compiler failures and re-pin the seven discard rises (Refs #5497) - #5596
Merged
Merged
Conversation
…d rises (Refs #5497) The corpus ratchet reported nine results on master that no spec edit can fix. Two typecheck failures, disjoint_set (#5573) and mha_block (#5574), are in the frozen compiler core; each issue carries its patch and needs the M5 ceremony. Seven parse-no-discard pins rose because the specs gained formal property statements (forall, implies, ==>) that the parser cannot express; each reason names the lines and the commit that added them. Ledger 133 -> 135 and max_entries 133 -> 135 by hand, as the workflow says to. `t27c suite --repo-root . --ratchet --corpus-only` -> RATCHET: CLEAN. Refs #5497 Refs #5573 Refs #5574 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #5497, #5573, #5574.
What
On master
4f65684dthe corpus ratchet reports exactly nine results, all of them outside what a spec edit can fix. This PR records them the waydocs/CORPUS-RATCHET.mdand the workflow say to.Two typecheck failures (new ledger entries, expiry 2026-11-30, hand-written reasons and issue numbers):
specs/tri/graph/disjoint_set.t27: A module-level var array is typechecked as const: W456 rejects every write into it #5573, a module-levelvararray is typechecked asconst, so W456 rejects every write. One-line patch and two tests are in the issue.specs/ml/transformer/mha_block.t27: A qualified call module::f is typechecked against the local f of the same name #5574, a qualified callmodule::fis checked against the localf.Both are in the frozen compiler core (M5 ceremony). Until #5572 and #5575 the two specs discarded tokens at parse, which masked the failures.
Seven
parse-no-discardpins raised to what the run measures. Each reason names the lines and the commit that added them:base/ternary_addassert … for all Trit a, b,… implies …fpga/top_levelassert … implies …,measure:igla/race/opcodesforall op : u8,==>igla/training/pilot_pretrainingforall cp : Checkpoint,given/letin testsmath/constantsmath/phi_split_optimalityassert forall bits: u8,forall i in …vsa/jones_polynomialThese are not code that was written and lost: the parser cannot express formal property statements (
forall,implies,==>), and the compiler is frozen. The pins stay bounds, so the next regression still fails. The #5551 note said these seven were "to be repaired, not recorded". Repairing means rewriting the maintainer's formal statements into executable asserts, which is a decision about those statements, so they are recorded here with the reason on each line instead, as the workflow allows ("bless and justify the rise in the PR").max_entries133 → 135 by hand, which is the reviewable event the ratchet asks for.Measured
On master the same command prints
UNEXPECTED FAILURES: 2,DISCARD WORSENED: 7.Not in this PR
The two compiler fixes themselves (#5573, #5574). The
docs/now/entry is added as every PR must.🤖 Generated with Claude Code