Skip to content

Converge M3 JFace viewer queue, selection, and worker-display safety (#33 + #35) - #37

Merged
hsoliwal merged 8 commits into
masterfrom
m3/viewer-worker-display-superset-20261022
Oct 23, 2026
Merged

hsoliwal merged 8 commits into
masterfrom
m3/viewer-worker-display-superset-20261022

Conversation

@hsoliwal

Copy link
Copy Markdown
Owner

Development convergence of the complete #33 → #35 stacked source, retaining ordered M3 viewer deltas, selection and callback semantics, CCombo behavior, worker-thread display ownership and original native JFace tests. This PR does not claim #27's separate iterative-tree changes or release readiness. Merge only if content-diff and SWT/PDE tests pass; no ancestry-only merge or code replacement.

Receive the qualified Synexia EclipseStructures20261021 eclipse-slot-v2
recipe. Reuse M3JDK21 sparse extents above the validated block threshold,
keep index state synchronized across edits, and preserve marker ordering
and public contracts. Retain a pinned qualification receipt.
Problems view: use M3SparseExtents for marker slot rank and lookup
Bound self-append, retain reentrant delta order, coalesce adjacent scheduled refreshes, and make timer cancellation and disposal deterministic. Preserve logical selection and callback intent across shared viewer operations and Combo clearing.

Correct differential harness layout and tree input preconditions, add regressions, and extend the existing workflow with pinned SWT integration and two-mode M3 validation.

All product, test, and workflow postimages are produced and received through the existing canonical Maven/OpenRewrite selections. Pair with SWT CCombo commit 394bd63c4ba19e5e73bd8dd7c13b5ad3e7d76f3f.

Copy link
Copy Markdown
Owner Author

Additive source-order reconciliation notice (2026-10-22)

A new direct-source review chain recovers these selection/callback atoms without overwriting the already admitted M3 primitive-array and queue owners:

This PR remains valuable because #33/#35/#37 demonstrated more extensive 47 native SWT/JFace cases per mode on its earlier head, with native differential traces and CCombo edge cases. That prior evidence is NOT automatically conferred upon #39's new combined source. Those native/regression tests and the full original JFace/PDE/Win32/macOS matrix must be rerun before product merge.

Please do not copy this PR's full M3ViewerDelta.java or differently shaped M3Viewers.Queue onto master or #36/#39, as that could undo already merged optimized append and timer contracts. Original public JFace contracts, donor licences, and all needed tests must be preserved. The two PR chains should be reconciled by content and exact-head proof, never ancestry-only merge.

Copy link
Copy Markdown
Owner Author

Exact-head no-regression gate (2026-10-22) — do not merge this develop stack wholesale into current master

Read original master and this PR's head sources directly:

Original Java owner current master Git blob this PR Git blob critical divergence
bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/m3/M3Viewers.java fcadd56125b52c6fa3c5911112b9cf3bda5cb14a 73da4eb60306b682cf18615014e7b323014f5674 master already owns post(Display,...), selection-preserving application, monotonic deadlineNanos, and redundantRefresh with barriers. This PR's branch has a different schedule/wake/cancelTimer state machine and no deadlineNanos or redundantRefresh. Do not overwrite the newer master batching/first-post semantics with older queue code
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/M3SlotOrder.java dd5e7b7d33c6521343f237c34d210b086dd8d80e 0ea028e7b2c6e59e37f552a59ce75c070e53c042 both are different indexed-array owners: current master uses blockCounts, countBefore, addCount and rebuildCounts; this branch uses M3SparseExtents blockIndex. Neither algorithm may be substituted merely because a Git ancestry merge succeeds; compare first-match/ordering/mutation and run strict head tests

The original UI #36, #38 and #39 are merged into master. Preserve their JFace selection/Combo/UI-thread behavior. Current PR #37 targets develop and was reported mergeable: false at inspection; merging that branch into master is not completion.

Required next step: source-sealed Synexia Maven/OpenRewrite recipe for only proven novel, non-conflicting atoms from #37 onto an exact observed master source; actual Recipe.run fixed point/drift refusal, native JFace/SWT/Tycho tests, and marker-index differential mutation/range benchmarks at each resulting head. Keep the current master queue/selection and indexed-sort features intact, and do not publish recipes in this public fork. No changes to master, branch rebases or forced PR merges are authorized by this audit.

Related owner inventory: Synexia #12944.

@hsoliwal
hsoliwal changed the base branch from develop to master October 23, 2026 01:08
@hsoliwal
hsoliwal merged commit c9a2df4 into master Oct 23, 2026
1 of 2 checks passed
hsoliwal added a commit that referenced this pull request Oct 23, 2026
Integrate PR #45 as the reviewed composite successor of #27 and #37/#35, preserving complete merge ancestry and JFace viewport/selection/display-safety implementations. No squash, no branch deletion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant