Skip to content

fix(M3 JFace CI): align pinned SWT 3.138 Tycho metadata without source replacement - #46

Closed
hsoliwal wants to merge 3 commits into
m3/viewer-worker-display-superset-20261022from
fix/m3-jface-tycho-pinned-swt-20261023
Closed

hsoliwal wants to merge 3 commits into
m3/viewer-worker-display-superset-20261022from
fix/m3-jface-tycho-pinned-swt-20261023

Conversation

@hsoliwal

@hsoliwal hsoliwal commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Purpose

Unblock the exact Tycho version mismatch in the existing JFace M3 viewer verification without changing JFace/SWT widget behavior or test logic.

The prior M3 viewer job (run 39710461979) failed before its 59 JFace tests because the pinned SWT correction had OSGi host version 3.138.0.qualifier but Maven module version 3.137.0-SNAPSHOT.

Minimal stacked CI repair

  • One existing file only: .github/workflows/ci.yml, with 3 additions and 2 deletions versus the viewer branch.
  • Pin SWT_CORRECTION_SHA from 394bd63c4ba19e5e73bd8dd7c13b5ad3e7d76f3f to 483af23f7bb58a06223aad61a79795cc2047d97f.
  • Add an explicit workflow trigger/routing expression for PRs based on m3/viewer-worker-display-superset-20261022.
  • Preserve every existing source/test/hash/runtime verification command, including the exact 59-case native viewer inventory.

SWT source custody

The new SWT ref is an exact descendant of the old pin, nine commits ahead and zero behind. Its diff is exactly nine metadata changes: bundles/org.eclipse.swt/pom.xml plus eight native-fragment META-INF/MANIFEST.MF files. Each resulting blob was read back and verified identical to the canonical hash-pinned SWT correction at c1ed5e568efc8ae628b32ff71d4f9a343a3f8f94. No Java, JNI, native shared library, widget, or API file was changed.

Those source comparisons are preparation evidence; this PR does not add separate in-workflow assertions for all nine blobs. It pins the verified immutable SWT commit and preserves all the prior provenance, source-hash, LFS and JFace gates.

Qualification and hold

The previous Tycho error is diagnosed and its stale pin has been corrected, not yet proven eliminated by a successful new CI execution. The full Tycho/PDE reactor, 59 native tests, GTK/Win32/Cocoa, selection/callback parity and release acceptance remain pending until exact-head results are inspected. Keep this as a draft and do not merge the underlying viewer branch into master on source evidence alone.

No squash, rebase, force-push, code replacement or unrelated donor change.

Copy link
Copy Markdown
Owner Author

Additive correction to the existing draft: replaced the Tycho-only SWT pin 483af23f7bb58a06223aad61a79795cc2047d97f with source-complete 026e1515b0ba60588b9152e64e339f137203e966, which retains the original CCombo change and the nine Tycho 3.138 metadata fixes together. Actual workflow blob readback matched the intended one-line edit on branch fix/m3-jface-tycho-pinned-swt-20261023 at d5bb5e811b99b31569cc43cf629c50a835442bea. This is a CI test-input repair, not proof that the full Eclipse tests pass. Keep draft until executed Tycho/JFace proof.

Copy link
Copy Markdown
Owner Author

2026-10-23 additive supersession review after merged JFace superset #45.

The current master and draft #46 both pin SWT_CORRECTION_SHA: 026e1515b0ba60588b9152e64e339f137203e966; the intended pinned correction is already present.

However the draft #46 source remains on the older #37 stack. Its .github/workflows/ci.yml expects 59 exact M3 viewer tests and routes m3/viewer-worker-display-superset-20261022; current master expects 62 exact tests and routes m3/jface-superset-20261023 with the newer test hash. Replacing current workflow would regress the test inventory and triggering.

Closing this obsolete CI-pin draft as SUPERSEDED_BY_#45, not as a separate merge. Source branch retained; no force/rebase/squash. The hosted Tycho/JFace runtime execution remains unproven and must be checked on the current 62-test workflow; this closure is NOT a CI PASS claim.

@hsoliwal hsoliwal closed this Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant