Skip to content

fix(JFace M3): preserve #33 selection pipeline while fencing worker SWT access - #35

Closed
hsoliwal wants to merge 4 commits into
m3/viewer-fixes-20261021from
m3/viewer-worker-display-superset-20261022
Closed

hsoliwal wants to merge 4 commits into
m3/viewer-fixes-20261021from
m3/viewer-worker-display-superset-20261022

Conversation

@hsoliwal

@hsoliwal hsoliwal commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Three serial original-file corrections, stacked on current UI #33

This PR adds only the worker-thread safety behavior from previously reviewed Eclipse UI #27 into the newer original UI #33 viewer queue, leaving #33's native 42-test selection, callback, CCombo, reuse-timer, monotonic first-post bound, and event ordering implementations untouched.

The original M3Viewers.post(viewer,delta,delay) now chooses a Display without inspecting the viewer off-thread, and an additive post(Display,viewer,delta,delay) supports nondefault Displays explicitly. Control access, ownership and disposal checks occur only on that Display's UI thread. Off-thread flush refuses before touching the Control. The two new original M3ViewersTest JUnit cases check worker-thread admission and off-thread flush.

The original ci.yml is updated only to preserve its strict source/test hashes while admitting the two additional named tests (old 57, new 59); the previously corrected github.workspace evidence path remains. No native ABI, JDK/HotSpot package, original SWT provider commit, selection/callback owner, or competing viewer model is introduced.

Canonical recipe and all source pins: Synexia #12901, itself stacked on #12898, using two existing M3HashPinnedJavaSnapshotRecipe passes and one M3HashPinnedTextSnapshotRecipe pass. All three received Git blobs are byte-for-byte identical to their canonical template blobs. Exact parent/UI #33 branch: 80e57503f69bf10fc5140868c763e10ea063a00a.

Hold: Source-native and Maven/OpenRewrite SDK fixture replay, second-run fixed point, JFace/SWT 59 exact native tests, Windows/macOS UI and full M3JDK21 build remain UNEXECUTED for this new stack. The existing UI #33 CI job 39709065260 is queued; this branch does not cancel or rewrite it. No test success is claimed before real reports. Merge only after requalification. No foreign challenge solutions copied.

Source-sealed CI routing for stacked PRs

The canonical Synexia #12901 now also contains a fourth serial FILE recipe for two CI routing expressions, admitting pull_request work whose base is m3/viewer-fixes-20261021. This permits the exact 59-test native workflow to be evaluated on this stacked branch while preserving original UI #33's base-branch path, Java/SWT checkout pins and expected hashes. Source postimage equals template Git blob ef4de26a9d75ff8ed3eb529596f6092910729ffb. Still draft pending actual CI and JFace native tests.

Copy link
Copy Markdown
Owner Author

22 October 2026 — exact original viewer superset + static roster receipt

Canonical recipe: Synexia #12901 (stacked on source-locked CI admission #12898). Four serial passes have original before/post images: M3Viewers.java, M3ViewersTest.java, CI test-name/hash roster and nested-PR branch routing. All three final target Git blobs match the canonical generated templates byte-for-byte; PR diff confirms exactly those three original files.

I independently re-read this PR head and compared every @Test public void method with the CI expected_tests literal: 44 JFace test names exactly match, unique both sides, no missing/extra names, and other 15 tests make the exact total 59. The CI test-source digest and nested branch route are present. Source SHA and exact Git blob receipts are in evidence/VIEWER_ROSTER_STATIC_PROOF.json.

GitHub created native JFace workflow run 39710461979, with m3-viewers job 119600303102. It was queued when inspected, NOT a passing result. Do not merge until the actual native Java25/PDE 59-case JUnit, full Maven/OpenRewrite fixed-point and source-drift controls, SWT callback ordering, and non-GTK peers are verified. PR #33 native 42-test evidence is the preserved incumbent, not a replacement for this new qualification.

Copy link
Copy Markdown
Owner Author

Additive convergence on 2026-10-23: this PR head 7337241b4f9ab751e8bb6756866b438f1c61b1b7 is already an ancestor of master through merged #37 and the consolidated #45.

master is 95ab50848e774727f802b3d99731a8113034f112; the comparison from #45 to master is identical (0 files changed).

GitHub rejected direct retarget to master with There are no new commits, and direct merge against the obsolete stacked base reports a conflict.

Closing as superseded and content integrated via #37/#45, not as a separate merge of this PR. No source branch is deleted.

@hsoliwal hsoliwal closed this Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant