Skip to content

fix(JFace): preserve marker selection and disambiguate local helper - #43

Merged
hsoliwal merged 1 commit into
masterfrom
m3/jface-marker-selection-repair-20261022
Oct 23, 2026
Merged

hsoliwal merged 1 commit into
masterfrom
m3/jface-marker-selection-repair-20261022

Conversation

@hsoliwal

Copy link
Copy Markdown
Owner

Compiler blocker addressed

After assembling latest UI/JFace master with the SWT 3.138 fix, Eclipse 4.42 Tycho failed at org.eclipse.ui.ide: MarkersTreeViewer.m3PreservingSelection(Runnable) collides with a package-local StructuredViewer helper from a different Java package.

Contract-preserving generated fix

Recipe-first qualification

Mechanically generated with canonical Synexia recipe PR #13124, commit aad7ff4a744070f70882d531b859d40273487707. Actual OpenRewrite Java AST recipe on JDK21 passed 6/6 adversarial tests (fixed point, hash drift, missing/duplicate, reorder, unrelated source, exact semantics), and current public master Git blobs match source preimages.

Full 534-module Tycho -Pbree-libs -DskipTests verify then advanced past org.eclipse.ui.ide and stopped in separate repository owner org.eclipse.compare on inherited method visibility. Details in the receiver receipt.

Draft: whole-SDK reactor, JFace selection regression and SWT GUI/native tests remain outstanding; do not merge or replace unresolved superset PRs without qualified evidence.

Apply Java 21 AST recipe with SHA-sealed 2-file source pre/postimages. Rename one internal helper and its two call sites, without behavior/API changes. Includes reactor/selection proof receipt.
@hsoliwal
hsoliwal marked this pull request as ready for review October 23, 2026 01:07
@hsoliwal
hsoliwal merged commit 71fe7f6 into master Oct 23, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant