Repository navigation
fix(JFace): preserve marker selection and disambiguate local helper - #43
Merged
Merged
Conversation
Apply Java 21 AST recipe with SHA-sealed 2-file source pre/postimages. Rename one internal helper and its two call sites, without behavior/API changes. Includes reactor/selection proof receipt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiler blocker addressed
After assembling latest UI/JFace
masterwith the SWT 3.138 fix, Eclipse 4.42 Tycho failed atorg.eclipse.ui.ide:MarkersTreeViewer.m3PreservingSelection(Runnable)collides with a package-localStructuredViewerhelper from a different Java package.Contract-preserving generated fix
m3PreservingMarkerSelectioninMarkersTreeViewer.M3MarkerDeltaschanged to match.Recipe-first qualification
Mechanically generated with canonical Synexia recipe PR #13124, commit
aad7ff4a744070f70882d531b859d40273487707. Actual OpenRewrite Java AST recipe on JDK21 passed 6/6 adversarial tests (fixed point, hash drift, missing/duplicate, reorder, unrelated source, exact semantics), and current publicmasterGit blobs match source preimages.Full 534-module Tycho
-Pbree-libs -DskipTests verifythen advanced pastorg.eclipse.ui.ideand stopped in separate repository ownerorg.eclipse.compareon inherited method visibility. Details in the receiver receipt.Draft: whole-SDK reactor, JFace selection regression and SWT GUI/native tests remain outstanding; do not merge or replace unresolved superset PRs without qualified evidence.