Repository navigation
JFace: receive selected-state and Combo callback repairs without replacing M3 bulk lanes - #39
Conversation
…n-structuredviewer-20261022
…n-structuredviewerinternals-20261022
…n-comboviewer-20261022
Exact-head source/model workflow received (2026-10-22)The target now contains one additional source-first workflow file This workflow checks all six product Java postimage SHA-256s, requires the unchanged original GitHub accepted the new workflow and created run 39722656415 for this PR head. Status queued when inspected; zero passing hosted assertions claimed. Exact merged Java source (JFace/SWT/UI), the four native receiver JUnit tests, 47 historical GTK cases on this new head, full Tycho, JNI/Win32/Cocoa and performance remain pending. This PR must stay DRAFT until those gates pass. Only the workflow metadata was added after the six original Java source changes; no generated Java was edited. |
Source-content-ordered original Eclipse JFace, not another M3+JDK layer
Directly refines the original
StructuredViewer,StructuredViewerInternals,ComboViewer,M3Viewersand the existingM3ViewerDifferentialtest owner inside Eclipse Platform UI. The integrated Java/JNI SDK is M3JDK21; M3/Synexia is the recipe/convergence provenance, not a separately mandated runtime, widget, payload/Entry store or public API replacement.Why this is stacked on JFace #36
UI #33 and later #35/#37 contain stronger logical selection, CCombo callback and native differential fixes. Their full
M3Viewersqueue andM3ViewerDelta.appendalso conflict with already admitted master and #36: currentM3ViewerDeltahas five-arraySystem.arraycopyrather than per-elementpush; #36 preserves fixedSystem.nanoTimefirst-postdeadlineNanos, worker-safe Display dispatch, coalescing, and opt-in iterative tree search. Directly cherry-picking the entire older stack would lose those atoms.This branch is based exactly on #36 head
c51aa40192356731adfa70061dfb949767a0bddband changes five existing Java files and one additive SWT/JFace test source:StructuredViewer.java: six exact Repair shared M3 viewer batching, selection and callback semantics #33 source hunks for explicit M3 selection boundary, nested scopes, callback intent, restored selected element, no temporary events.StructuredViewerInternals.java: exact one-hunk first-party protected-owner access through existing JFace API.ComboViewer.java: three exact Repair shared M3 viewer batching, selection and callback semantics #33 hunks for explicit empty Combo/CCombo selection and retaining original Modify/Verify callbacks.M3Viewers.java: only the first five selection-specific Repair shared M3 viewer batching, selection and callback semantics #33 hunks: additiveapplyPreservingSelectionand ComboUPDATEowner-boundary dispatch. The entire existing private Queue and all following methods are byte-identical to Reconcile JFace viewer queue and iterative tree search without losing merged M3 array lanes #36;post(Display,...), fixed nanosecond deadline, stale-batch identity, adjacent-REFRESH policy,flushand redraw are preserved.M3ViewerDifferential.java: three donor-exact native trace adjustments for distinct tree sibling IDs, positive widget geometry and pixel trace recording.M3SelectionReceiverTest.java: four original SWT/JFace JUnit regressions for remove/reinsert selection, Combo label update, explicit CCombo empty selection, and the last callback's selection request.Intentionally unchanged: current improved original
M3ViewerDelta.javaGit blobb68f93b3854e49ad0571905ad274823c9c502baeand original queue regressions. The only new public JFace method is the opt-inM3Viewers.applyPreservingSelectionplusStructuredViewerInternals.preservingSelectionhelper, no removed or renamed existing methods. No native JNI symbol modified.Source-first reusable recipe
Canonical six SOURCE-hash-sealed serial Maven/OpenRewrite FILE recipes, before and approved postimage snapshots, explicit ABSENT-before test, original downstream rights, category catalogue, append-only recipe correction memory, Maven/JUnit actual SDK replay/fixed-point/drift-refusal test sources: Synexia #12945, itself stacked on #12919 and #12917. Six named
M3HashPinnedJavaSnapshotRecipestages registered inCANONICAL_RECIPE_HOME.tsv(eight new additive rows). Generated outputs were committed to Synexia before product changes. All six receiver outputs were applied serially and independently read back byte-for-byte identical to canonical postimages; patch diff verifies donor identity for original files, and queue suffix identity for M3Viewers.Donor code: own Eclipse JFace #33, not unlicensed challenge solutions. LeetCode/HackerRank/GfG used only as indexed-array/callback-order problem taxonomy. Eclipse original EPL-2.0 copyrights unchanged, new Synexia recipe under Apache-2.0 first-party 2026 copyright.
Executed vs held acceptance
Executed (isolated Java21 model):
javac --release 21 -Xlint:all -Werror,java -Xmx384m: 179,958 checks passed covering callback-priority, nested preservation, selected-row restore, exception cleanup, and disabled preservation (oracle SHA256aee74d8df70cb77d30dbbd1c08170db10e01ae63f91d6c16bc4934c6ee6e9d38). Source-patch matching and whole-queue/bulk-array invariants also passed.Previous first-party donor evidence only: #33 reported 47 real GTK native JFace tests per mode plus 15 headless; this is not proof of this new combined head.
Not run / draft hold: six-stage real Maven/OpenRewrite
Recipe.runand fixed-point/refusal; the new four original SWT/JFace native tests and complete original 47-test suite on this exact head; Eclipse Tycho Java21/25/JFace/SWT/PDE reactor; CCombo native GTK/Win32/macOS events, pixel/accessibility checks; full M3JDK21 installed JDK/HotSpot JNI/GC/CDS; comparative CPU/heap/native-memory. Keep DRAFT; do not merge until proved. Remaining Project Explorer #38, Problems/Search, JDT/PDE/Debug/Nebula/GEF are separate source gates.Review order: master → UI #36 → this selection receiver. No rebase/force-push or direct writes to master. Preserve every admitted source atom.