Skip to content

JFace: receive selected-state and Combo callback repairs without replacing M3 bulk lanes - #39

Merged
hsoliwal merged 7 commits into
masterfrom
codex/eclipse-jface-selection-on-36-20261022
Oct 22, 2026
Merged

hsoliwal merged 7 commits into
masterfrom
codex/eclipse-jface-selection-on-36-20261022

Conversation

@hsoliwal

Copy link
Copy Markdown
Owner

Source-content-ordered original Eclipse JFace, not another M3+JDK layer

Directly refines the original StructuredViewer, StructuredViewerInternals, ComboViewer, M3Viewers and the existing M3ViewerDifferential test owner inside Eclipse Platform UI. The integrated Java/JNI SDK is M3JDK21; M3/Synexia is the recipe/convergence provenance, not a separately mandated runtime, widget, payload/Entry store or public API replacement.

Why this is stacked on JFace #36

UI #33 and later #35/#37 contain stronger logical selection, CCombo callback and native differential fixes. Their full M3Viewers queue and M3ViewerDelta.append also conflict with already admitted master and #36: current M3ViewerDelta has five-array System.arraycopy rather than per-element push; #36 preserves fixed System.nanoTime first-post deadlineNanos, worker-safe Display dispatch, coalescing, and opt-in iterative tree search. Directly cherry-picking the entire older stack would lose those atoms.

This branch is based exactly on #36 head c51aa40192356731adfa70061dfb949767a0bddb and changes five existing Java files and one additive SWT/JFace test source:

Intentionally unchanged: current improved original M3ViewerDelta.java Git blob b68f93b3854e49ad0571905ad274823c9c502bae and original queue regressions. The only new public JFace method is the opt-in M3Viewers.applyPreservingSelection plus StructuredViewerInternals.preservingSelection helper, no removed or renamed existing methods. No native JNI symbol modified.

Source-first reusable recipe

Canonical six SOURCE-hash-sealed serial Maven/OpenRewrite FILE recipes, before and approved postimage snapshots, explicit ABSENT-before test, original downstream rights, category catalogue, append-only recipe correction memory, Maven/JUnit actual SDK replay/fixed-point/drift-refusal test sources: Synexia #12945, itself stacked on #12919 and #12917. Six named M3HashPinnedJavaSnapshotRecipe stages registered in CANONICAL_RECIPE_HOME.tsv (eight new additive rows). Generated outputs were committed to Synexia before product changes. All six receiver outputs were applied serially and independently read back byte-for-byte identical to canonical postimages; patch diff verifies donor identity for original files, and queue suffix identity for M3Viewers.

Donor code: own Eclipse JFace #33, not unlicensed challenge solutions. LeetCode/HackerRank/GfG used only as indexed-array/callback-order problem taxonomy. Eclipse original EPL-2.0 copyrights unchanged, new Synexia recipe under Apache-2.0 first-party 2026 copyright.

Executed vs held acceptance

Executed (isolated Java21 model): javac --release 21 -Xlint:all -Werror, java -Xmx384m: 179,958 checks passed covering callback-priority, nested preservation, selected-row restore, exception cleanup, and disabled preservation (oracle SHA256 aee74d8df70cb77d30dbbd1c08170db10e01ae63f91d6c16bc4934c6ee6e9d38). Source-patch matching and whole-queue/bulk-array invariants also passed.

Previous first-party donor evidence only: #33 reported 47 real GTK native JFace tests per mode plus 15 headless; this is not proof of this new combined head.

Not run / draft hold: six-stage real Maven/OpenRewrite Recipe.run and fixed-point/refusal; the new four original SWT/JFace native tests and complete original 47-test suite on this exact head; Eclipse Tycho Java21/25/JFace/SWT/PDE reactor; CCombo native GTK/Win32/macOS events, pixel/accessibility checks; full M3JDK21 installed JDK/HotSpot JNI/GC/CDS; comparative CPU/heap/native-memory. Keep DRAFT; do not merge until proved. Remaining Project Explorer #38, Problems/Search, JDT/PDE/Debug/Nebula/GEF are separate source gates.

Review order: master → UI #36 → this selection receiver. No rebase/force-push or direct writes to master. Preserve every admitted source atom.

Copy link
Copy Markdown
Owner Author

Exact-head source/model workflow received (2026-10-22)

The target now contains one additional source-first workflow file .github/workflows/m3-jface-selection-source-20261022.yml, received byte-for-byte from the existing canonical Synexia text recipe com.synexia.m3.EclipseJFaceSelectionSourceWorkflow20261022 in #12945. The template and receiver Git blob are both 5aefa0e5e015b14b2a01cf05d09aec87aeb359f9, SHA-256 059cc70c684a010f58825770e22fc1bae19deeb5a8eb5657e53bd2b026d47c5a.

This workflow checks all six product Java postimage SHA-256s, requires the unchanged original M3ViewerDelta.java fast-five-lane Git blob b68f93b3854e49ad0571905ad274823c9c502bae, compares the entire M3Viewers.Queue and trailing source bytes to the exact approved #36 parent, and checks out pinned Synexia Git 48fde6ad83d5889126aa3570deaa247801b95c8e for its checksum-guarded JDK21 source model. The exact 8,324-byte tested model is now checked in at canonical .../evidence/model/M3SelectionAtomOracle.java, local Git blob 7b52bd39b21cab82930e8cdcc65764abc8fc0730. Its bash .../verify-isolated.sh was rerun and passed 179,958 checks.

GitHub accepted the new workflow and created run 39722656415 for this PR head. Status queued when inspected; zero passing hosted assertions claimed. Exact merged Java source (JFace/SWT/UI), the four native receiver JUnit tests, 47 historical GTK cases on this new head, full Tycho, JNI/Win32/Cocoa and performance remain pending. This PR must stay DRAFT until those gates pass. Only the workflow metadata was added after the six original Java source changes; no generated Java was edited.

@hsoliwal
hsoliwal changed the base branch from codex/eclipse-jface-best-merged-20261022 to master October 22, 2026 04:37
@hsoliwal
hsoliwal marked this pull request as ready for review October 22, 2026 04:37
@hsoliwal
hsoliwal merged commit 1b5750d into master Oct 22, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant