Skip to content

feat(jface): restore iterative tree lookup without overwriting newer viewer queue - #40

Merged
hsoliwal merged 2 commits into
developfrom
integration/additive-iterative-tree-search-20261022
Oct 22, 2026
Merged

hsoliwal merged 2 commits into
developfrom
integration/additive-iterative-tree-search-20261022

Conversation

@hsoliwal

Copy link
Copy Markdown
Owner

Additive recovery of missing iterative tree search from Eclipse UI #27

The newer Eclipse UI #37 retains the #33/#35 JFace queue, selection and worker-display fixes, but does not change AbstractTreeViewer.java or M3ViewerPaths.java. This PR restores only the independent A5 tree-search behavior from #27 into current develop, without reverting or duplicating #33/#35/#37.

Code

  • Add the optional early hook in existing AbstractTreeViewer.internalFindItem under M3ViewerPaths.on(this); default behavior is unchanged when M3 viewport mode is off.
  • Add M3ViewerPaths.findTreeItem, an iterative preorder traversal using Item[][] level arrays and primitive int[] offsets. Preserve first-match order and existing getData, comparer and getChildren callback sequence.
  • Reuse the exact two source hunks from original M3: repair shared JFace viewer delta dispatch and iterative tree lookup #27. No new data owner or duplicate viewer scheduler.

Diff and boundaries

Base: develop@3260aa19d97f9b2fc73d85270d2011b1e164fda5. Diff: 2 original source files, +48/-0. No overlapping files with #37. No SWT public API, worker-display policy, queue semantics or selection logic replaced.

Pending gates

Original #27 reports isolated Java 21 randomized tree-query parity, but this receiving PR has not independently run JFace/SWT native PDE/JUnit, headless mode, large-depth stack, disposal/reentrancy or platform gates. Keep draft until exact receiving tests and upstream-scenario evidence pass. Do not normalize #27 by ancestry-only merges.

@hsoliwal
hsoliwal marked this pull request as ready for review October 22, 2026 05:44
@hsoliwal
hsoliwal merged commit 54ac86f into develop Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant