Repository navigation
feat(jface): restore iterative tree lookup without overwriting newer viewer queue - #40
Merged
hsoliwal merged 2 commits intoOct 22, 2026
Conversation
hsoliwal
marked this pull request as ready for review
October 22, 2026 05:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additive recovery of missing iterative tree search from Eclipse UI #27
The newer Eclipse UI #37 retains the #33/#35 JFace queue, selection and worker-display fixes, but does not change
AbstractTreeViewer.javaorM3ViewerPaths.java. This PR restores only the independent A5 tree-search behavior from #27 into currentdevelop, without reverting or duplicating #33/#35/#37.Code
AbstractTreeViewer.internalFindItemunderM3ViewerPaths.on(this); default behavior is unchanged when M3 viewport mode is off.M3ViewerPaths.findTreeItem, an iterative preorder traversal usingItem[][]level arrays and primitiveint[]offsets. Preserve first-match order and existinggetData, comparer andgetChildrencallback sequence.Diff and boundaries
Base:
develop@3260aa19d97f9b2fc73d85270d2011b1e164fda5. Diff: 2 original source files, +48/-0. No overlapping files with #37. No SWT public API, worker-display policy, queue semantics or selection logic replaced.Pending gates
Original #27 reports isolated Java 21 randomized tree-query parity, but this receiving PR has not independently run JFace/SWT native PDE/JUnit, headless mode, large-depth stack, disposal/reentrancy or platform gates. Keep draft until exact receiving tests and upstream-scenario evidence pass. Do not normalize #27 by ancestry-only merges.