Repository navigation
build: switch Makefiles and pre-commit to flat config (gh54 part VII) - #10973
Merged
Merged
Conversation
Planeshifter
changed the title
Planeshifter
force-pushed
the
philipp/gh54-switch-to-flat-config
branch
from
March 15, 2026 18:08
c3dab8a to
c6bab92
Compare
4 of 7 tasks
Planeshifter
force-pushed
the
philipp/gh54-switch-to-flat-config
branch
from
August 20, 2026 05:57
c6bab92 to
3bdcf70
Compare
Planeshifter
force-pushed
the
philipp/gh54-switch-to-flat-config
branch
from
August 20, 2026 06:11
3bdcf70 to
9610469
Compare
Planeshifter
force-pushed
the
philipp/gh54-switch-to-flat-config
branch
from
August 20, 2026 06:25
9610469 to
92735cb
Compare
kgryte
force-pushed
the
philipp/gh54-switch-to-flat-config
branch
from
August 21, 2026 10:06
92735cb to
bcb201a
Compare
kgryte
force-pushed
the
philipp/gh54-switch-to-flat-config
branch
from
August 21, 2026 10:14
bcb201a to
86526e2
Compare
Planeshifter
force-pushed
the
philipp/gh54-switch-to-flat-config
branch
from
August 25, 2026 03:49
86526e2 to
00d646f
Compare
kgryte
force-pushed
the
philipp/gh54-switch-to-flat-config
branch
from
August 26, 2026 01:17
00d646f to
a1f1006
Compare
Planeshifter
marked this pull request as ready for review
October 28, 2026 06:16
Planeshifter
force-pushed
the
philipp/gh54-switch-to-flat-config
branch
from
October 28, 2026 06:24
a1f1006 to
fee88c9
Compare
Update build tooling to use ESLint flat config (`eslint.config.js`) instead of legacy `.eslintrc.*` files: - Remove `ESLINT_USE_FLAT_CONFIG=false` from JS eslint.mk - Remove `--ignore-path`, `--config`, and per-target config variables from both JS and TS eslint.mk (flat config autodiscovery handles all of this via `eslint.config.js`) - Remove per-directory tsconfig.json copy mechanism from TS eslint.mk (the flat config's TS block points to the root tsconfig.json) - Remove legacy config path variables from pre-commit hook ESLint now autodiscovers `eslint.config.js` at the repo root and applies the correct rules based on file patterns (benchmarks, tests, examples, TypeScript) defined in the flat config. Ref: stdlib-js/metr-issue-tracker#54
kgryte
force-pushed
the
philipp/gh54-switch-to-flat-config
branch
from
October 29, 2026 02:02
fee88c9 to
16a17ea
Compare
kgryte
approved these changes
Oct 29, 2026
kgryte
left a comment
kgryte
left a comment
Member
There was a problem hiding this comment.
These changes seem a bit magical given that ESLint now supposedly does auto-discovery. We can go ahead and merge, but we should pay special attention to whether our linting retains parity with previous behavior, @Planeshifter.
5 of 7 tasks
kgryte
pushed a commit
that referenced
this pull request
Oct 30, 2026
PR-URL: #16378 (review) Reviewed-by: Athan Reines <kgryte@gmail.com> Ref: #10973
This was referenced Oct 31, 2026
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresses stdlib-js/metr-issue-tracker#54.
Description
This pull request:
.eslintrc.*config to flat config autodiscoveryESLINT_USE_FLAT_CONFIG=false,--ignore-path,--config, and per-target config variables from JS and TS eslint.mk.tsconfig.jsoncopy mechanism from TS eslint.mk (flat config's TS block handles this).eslint.config.cjsand applies rules based on file patterns.Related Issues
This pull request has the following related issues:
Questions
No.
Other
Stacked on #10972.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code.
@stdlib-js/reviewers