Repository navigation
build: restore doctest exemption for ESLint rule definitions - #16396
Merged
Merged
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Planeshifter
marked this pull request as ready for review
October 31, 2026 02:44
kgryte
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the JSDoc doctest exemption for ESLint rule-definition files.
Description
This pull request:
stdlib/jsdoc-doctestforetc/eslint/rules/*.js, restoring the legacy exemption introduced in commitfd16a2f49cc.These files document lint rules using illustrative "Bad" and "Good" examples. Treating intentionally incorrect expected values in that documentation as executable doctests produces misleading lint failures. The override preserves the original path scope and leaves all other lint rules enabled.
Related Issues
This pull request has the following related issues:
Reference Packages
This pull request followed these packages:
etc/eslint/overrides/source.jsatfd16a2f49cc.etc/eslint/rules/*.jsfile pattern andstdlib/jsdoc-doctest: 'off'override.eslint.config.jsand verified that it changes only the intended rule and file scope.Questions
No.
Other
Validation:
stdlib/jsdoc-doctestchanges for rule-definition files.no-undefstill detects undefined names in rule-definition files.eslint.config.jsand all 11 JavaScript files underetc/eslint/rules/: zero errors and nine warnings in existing code.git diff --check, normal pre-commit checks, and the pre-push dependency license check passed.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by OpenAI Codex under human direction, including investigation, implementation, validation, and the PR description.
@stdlib-js/reviewers