Repository navigation
build: restore shared JSDoc settings in flat config - #16378
Merged
Merged
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
kgryte
approved these changes
Oct 30, 2026
Member
There was a problem hiding this comment.
@Planeshifter We've now a few of these situations where the previous settings were not carried over. Would you mind taking a closer look at the other previous overrides we had and making sure we have 1:1 parity?
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the JSDoc lint regression observed in #16346.
Description
This pull request:
settings.jsdoc.contextsandsettings.jsdoc.tagNamePreferencein the base JavaScript flat configuration.@constructorover@class, fixing thejsdoc/check-tag-nameserror on existing constructor documentation.These settings were present in the legacy configuration at commit
fd16a2f49cc, which introduced them in #10965. They were omitted when #10973 switched JavaScript linting to flat configuration.Related Issues
This pull request has the following related issues:
@constructorannotation.Reference Packages
This pull request followed these packages:
etc/eslint/.eslintrc.jsatfd16a2f49cc.settings.jsdocblock, including all five contexts and theclass: 'constructor'tag preference.eslint.config.js, preserving inheritance by the Markdown code-block configuration.Questions
No.
Other
Validation:
array/fixed-endian-factory/lib/main.jsandeslint.config.js: zero errors; one existingstdlib/no-single-property-requirewarning on the config'spathimport.@constructorwithout the settings, accepts it with the settings, and continues to flag@class.git diff --check, normal pre-commit checks, and the pre-push dependency license check passed.EC_VERSION=v3.11.3locally because the installed EditorConfig downloader does not recognize the latest release's renamed macOS binary assets.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by OpenAI Codex under human direction, including investigation, implementation, validation, and the PR description.
@stdlib-js/reviewers