Repository navigation
build: restore benchmark ESLint rule overrides - #16393
Merged
Merged
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Planeshifter
marked this pull request as ready for review
October 31, 2026 02:22
Planeshifter
requested review from
a team and
kgryte
and
a balanced review from Copilot
October 31, 2026 02:22
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the benchmark-specific ESLint override restoration.
No open issues 🎉
What changed in this PR
Restores benchmark-specific ESLint overrides omitted during the flat-config migration in #10973, preventing doctest linting from executing benchmark files.
Changes:
- Disables private-annotation, doctest, and unnecessary-nested-function rules for benchmark JavaScript files.
- Restores errors for string concatenation in benchmark descriptions.
| File | Description |
|---|---|
eslint.config.js |
Restores four benchmark rule overrides with their legacy severity levels. |
Review effort: Balanced
5 of 7 tasks
kgryte
approved these changes
Oct 31, 2026
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores benchmark linting behavior lost during the flat-config migration.
Description
This pull request:
stdlib/jsdoc-private-annotation,stdlib/jsdoc-doctest, andstdlib/no-unnecessary-nested-functionsfor benchmark JavaScript files.stdlib/no-bench-string-concatfor benchmark descriptions.f6df0741b98.Without the
stdlib/jsdoc-doctestoverride, linting initializes the rule and evaluates the entire file in a VM. This can start the benchmark harness during CLI linting or editor integration, even before processing any JSDoc examples. Restoring the override prevents that execution.Related Issues
This pull request has the following related issues:
Reference Packages
This pull request followed these packages:
etc/eslint/.eslintrc.benchmarks.jsatf6df0741b98.lintText()execution behavior, including nested benchmark paths.Questions
No.
Other
Validation:
ESLint.lintText()with a harmless temporary-file marker.format()is accepted bystdlib/no-bench-string-concat.array/fixed-endian-factorybenchmark: zero errors; one existing warning on the configuration'spathimport.git diff --check, normal pre-commit checks, and the pre-push dependency license check passed.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by OpenAI Codex under human direction, including investigation, implementation, validation, and the PR description.
@stdlib-js/reviewers