Skip to content

build: delete legacy ESLint config and obsolete helpers (gh54 part VIII) - #10974

Merged
kgryte merged 3 commits into
developfrom
philipp/gh54-delete-legacy-config
Oct 29, 2026
Merged

kgryte merged 3 commits into
developfrom
philipp/gh54-delete-legacy-config

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Mar 15, 2026 •

Copy link
Copy Markdown
Member

Resolves stdlib-js/metr-issue-tracker#54.

Description

What is the purpose of this pull request?

This pull request:

  • Deletes legacy ESLint configuration files superseded by eslint.config.cjs (PR 12 of the migration plan).
  • Removes .eslintrc.js, .eslintignore, per-target configs (benchmarks, examples, tests), and the overrides module.
  • Inlines the restricted syntax config directly in eslint.config.cjs.
  • Keeps etc/eslint/.eslintrc.js (consumed by typescript.js for base rule definitions), .eslintrc.markdown.js (consumed by remark plugin), and .eslintrc.typescript*.js files for now.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Stacked on #10973.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was written primarily by Claude Code.


@stdlib-js/reviewers

@Planeshifter Planeshifter changed the title build: delete legacy ESLint config and obsolete helpers build: delete legacy ESLint config and obsolete helpers (gh54 part VIII) Mar 15, 2026
@Planeshifter Planeshifter added the METR Pull request associated with the METR project. label Mar 18, 2026
@Planeshifter
Planeshifter force-pushed the philipp/gh54-delete-legacy-config branch from d037e92 to dac40cc Compare August 20, 2026 05:57
@Planeshifter
Planeshifter force-pushed the philipp/gh54-delete-legacy-config branch 2 times, most recently from 589a8a9 to 47b0aab Compare August 20, 2026 06:25
@kgryte
kgryte force-pushed the philipp/gh54-delete-legacy-config branch from 47b0aab to e936388 Compare August 21, 2026 10:06
@kgryte
kgryte force-pushed the philipp/gh54-delete-legacy-config branch from e936388 to 412f4da Compare August 21, 2026 10:14
@Planeshifter
Planeshifter force-pushed the philipp/gh54-delete-legacy-config branch from 412f4da to ae28ddf Compare August 25, 2026 03:49
@kgryte
kgryte force-pushed the philipp/gh54-delete-legacy-config branch from ae28ddf to e4832ab Compare August 26, 2026 01:17
@Planeshifter
Planeshifter marked this pull request as ready for review October 28, 2026 06:15
@Planeshifter
Planeshifter requested a review from a team October 28, 2026 06:15
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 28, 2026
@Planeshifter
Planeshifter force-pushed the philipp/gh54-delete-legacy-config branch from e4832ab to 5d0dadb Compare October 28, 2026 06:24
@kgryte
kgryte force-pushed the philipp/gh54-delete-legacy-config branch from 5d0dadb to 1891d62 Compare October 29, 2026 02:02
Base automatically changed from philipp/gh54-switch-to-flat-config to develop October 29, 2026 02:10
Remove legacy ESLint configuration files that are superseded by
`eslint.config.js` (flat config):

Deleted files:
- `.eslintrc.js` (root entry point)
- `.eslintignore` (ignores are in flat config)
- `etc/eslint/.eslintrc.overrides.js`
- `etc/eslint/.eslintrc.benchmarks.js`
- `etc/eslint/.eslintrc.examples.js`
- `etc/eslint/.eslintrc.tests.js`
- `etc/eslint/overrides/index.js`
- `etc/eslint/overrides/restricted_syntax.js`
- `etc/eslint/overrides/source.js`

Updated files:
- `eslint.config.js`: inline restricted syntax config (was imported
  from the now-deleted overrides module); remove overrides import
- `etc/eslint/.eslintrc.js`: remove overrides import (kept for now
  as `typescript.js` depends on it for base rule definitions)

Kept for now:
- `etc/eslint/.eslintrc.js` (consumed by `typescript.js`)
- `etc/eslint/.eslintrc.typescript.js` (consumed by remark plugin)
- `etc/eslint/.eslintrc.typescript.tests.js`
- `etc/eslint/.eslintrc.markdown.js` (consumed by remark plugin)
- `etc/eslint/env/`, `parser-options/`, `plugins/`, `rules/`

Ref: stdlib-js/metr-issue-tracker#54
@kgryte
kgryte force-pushed the philipp/gh54-delete-legacy-config branch from 1891d62 to 4048fda Compare October 29, 2026 02:10
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and merge, but it is likely that this will break current editor integration. For example, we need to update instructions for how to configure SublimeLinter, and thus real-time lint errors will be broken in the meantime.

@kgryte

kgryte commented Oct 29, 2026

Copy link
Copy Markdown
Member

...same thing for VSCode, according to our VSCode editor guide.

@kgryte
kgryte merged commit 1dd0231 into develop Oct 29, 2026
9 checks passed
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Oct 29, 2026
kgryte pushed a commit that referenced this pull request Oct 29, 2026
PR-URL: #16355
Reviewed-by: Athan Reines <kgryte@gmail.com>
Ref: #10974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

METR Pull request associated with the METR project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: migrate to ESLint v9

3 participants