chore(lint): enable no-throw-literal - #2149
Merged
Merged
Conversation
This was referenced Aug 8, 2026
|
To myriad friends Andrew love my brother
…On Fri, Aug 7, 2026 at 8:04 PM Hayden ***@***.***> wrote:
- I understand that this repository is auto-generated and my pull
request may not be merged
Changes being requested
- Remove the no-throw-literal compatibility exception from
oxlint.config.ts.
- Wrap the 3 existing thrown strings in Error while preserving their
messages.
Additional context & links
- Oxlint cleanup stack, part 69; stacked on #2148
<#2148>.
- Preserves generated-file exclusions and repository-specific import
policy.
Validation
- pnpm lint
- pnpm exec tsc --pretty false
- pnpm exec vitest run --config vitest.config.mts --update=none
Stack
#2141 <#2141>
#2143 <#2143>
#2144 <#2144>
#2145 <#2145>
#2146 <#2146>
#2147 <#2147>
#2148 <#2148>
------------------------------
You can view, comment on, or merge this pull request online at:
#2149
Commit Summary
- f671a2e
<f671a2e>
chore(lint): enable no-throw-literal
File Changes
(3 files <https://github.com/openai/openai-node/pull/2149/files>)
- *M* oxlint.config.ts
<https://github.com/openai/openai-node/pull/2149/files#diff-bb74d47b77763f955ac4f1aa50c369328c445a697494dd8abbeaa650907870ae>
(1)
- *M* scripts/utils/check-version.cjs
<https://github.com/openai/openai-node/pull/2149/files#diff-da1520663c09b85d08421edbe8907bf3b76dbc2616a88ae7ab360be80f6e50d8>
(6)
- *M* tests/qs/stringify.test.ts
<https://github.com/openai/openai-node/pull/2149/files#diff-028831a6e91167c0b5329cfaeb821aabe8f1008ec5ea9de5352984e199915dc3>
(2)
Patch Links:
- https://github.com/openai/openai-node/pull/2149.patch
- https://github.com/openai/openai-node/pull/2149.diff
—
Reply to this email directly, view it on GitHub
<#2149?email_source=notifications&email_token=CG7P3W64U5QHPGZMJIBNVF35IZVCBA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42DEMZSGM4TINZXGCTHEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVRTG633UMVZF6Y3MNFRWW>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CG7P3W3A4IEABAPTBCUYCS35IZVCBAVCNFSNUABFKJSXA33TNF2G64TZHM2DGOBUGE4TSMZXHNEXG43VMU5TKMBZGQ4DOOBVHE3KC5QC>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
jbeckwith-oai
approved these changes
Aug 8, 2026
jbeckwith-oai
left a comment
Contributor
There was a problem hiding this comment.
The two build-script failures preserve their exact message text while now throwing real Error instances with normal stack and error handling behavior; the test-only unreachable branch changes equivalently. No public SDK API surface changes, the rule passes without broad exemptions, no file-size or structural regression is introduced, and local lint, typecheck, focused tests, and exact-head CI all pass.
HAYDEN-OAI
force-pushed
the
dev/hayden/ultracite-069-no-throw-literal
branch
from
August 8, 2026 00:31
f671a2e to
7c515b2
Compare
HAYDEN-OAI
force-pushed
the
dev/hayden/ultracite-068-no-useless-escape
branch
from
August 8, 2026 00:31
d52f7c0 to
b6b62ce
Compare
Base automatically changed from
dev/hayden/ultracite-068-no-useless-escape
to
main
August 8, 2026 00:55
Draft
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
…2143) - [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/consistent-existence-index-check` compatibility exception from `oxlint.config.ts`. - Normalize the 3 existing handwritten-code `findIndex()` existence checks to compare with `-1`. ## Additional context & links - Oxlint cleanup stack, part 63; stacked on openai#2141. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2141 openai#2143 👈 this PR openai#2144 openai#2145 openai#2146 openai#2147 openai#2148 openai#2149
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/prefer-bigint-literals` compatibility exception from `oxlint.config.ts`. - Replace the 3 existing test-only `BigInt()` calls with equivalent bigint literals. ## Additional context & links - Oxlint cleanup stack, part 64; stacked on openai#2143. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2141 openai#2143 openai#2144 👈 this PR openai#2145 openai#2146 openai#2147 openai#2148 openai#2149
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged
## Changes being requested
- Remove the `no-lonely-if` compatibility exception from
`oxlint.config.ts`.
- Flatten the 3 existing handwritten-code `else { if }` branches without
changing their conditions or bodies.
## Additional context & links
- Oxlint cleanup stack, part 65; stacked on
openai#2144.
- Preserves generated-file exclusions and repository-specific import
policy.
### Validation
- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`
## Stack
openai#2141
openai#2143
openai#2144
openai#2145 👈 this PR
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `no-empty` compatibility exception from `oxlint.config.ts`. - Document the intent of the 3 existing empty catch blocks without changing control flow. ## Additional context & links - Oxlint cleanup stack, part 66; stacked on openai#2145. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2141 openai#2143 openai#2144 openai#2145 openai#2146 👈 this PR openai#2147 openai#2148 openai#2149
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `jsdoc/check-tag-names` compatibility exception from `oxlint.config.ts`. - Allow Jest's intentional `@jest-environment` pragma through the rule's `definedTags` option. ## Additional context & links - Oxlint cleanup stack, part 67; stacked on openai#2146. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2141 openai#2143 openai#2144 openai#2145 openai#2146 openai#2147 👈 this PR openai#2148 openai#2149
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `no-useless-escape` compatibility exception from `oxlint.config.ts`. - Remove the 3 redundant escapes while preserving the email regex character-class semantics. ## Additional context & links - Oxlint cleanup stack, part 68; stacked on openai#2147. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2141 openai#2143 openai#2144 openai#2145 openai#2146 openai#2147 openai#2148 👈 this PR openai#2149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
no-throw-literalcompatibility exception fromoxlint.config.ts.Errorwhile preserving their messages.Additional context & links
Validation
pnpm lintpnpm exec tsc --pretty falsepnpm exec vitest run --config vitest.config.mts --update=noneStack
#2141
#2143
#2144
#2145
#2146
#2147
#2148
#2149 👈 this PR