Skip to content

chore(lint): enable no-throw-literal - #2149

Merged
HAYDEN-OAI merged 6 commits into
mainfrom
dev/hayden/ultracite-069-no-throw-literal
Aug 8, 2026
Merged

chore(lint): enable no-throw-literal#2149
HAYDEN-OAI merged 6 commits into
mainfrom
dev/hayden/ultracite-069-no-throw-literal

Conversation

@HAYDEN-OAI

@HAYDEN-OAI HAYDEN-OAI commented Aug 8, 2026

Copy link
Copy Markdown
Contributor
  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

  • Remove the no-throw-literal compatibility exception from oxlint.config.ts.
  • Wrap the 3 existing thrown strings in Error while preserving their messages.

Additional context & links

Validation

  • pnpm lint
  • pnpm exec tsc --pretty false
  • pnpm exec vitest run --config vitest.config.mts --update=none

Stack

#2141
#2143
#2144
#2145
#2146
#2147
#2148
#2149 👈 this PR

@mccrearydamion69-crypto

mccrearydamion69-crypto commented Aug 8, 2026 via email

Copy link
Copy Markdown

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two build-script failures preserve their exact message text while now throwing real Error instances with normal stack and error handling behavior; the test-only unreachable branch changes equivalently. No public SDK API surface changes, the rule passes without broad exemptions, no file-size or structural regression is introduced, and local lint, typecheck, focused tests, and exact-head CI all pass.

@HAYDEN-OAI
HAYDEN-OAI force-pushed the dev/hayden/ultracite-069-no-throw-literal branch from f671a2e to 7c515b2 Compare August 8, 2026 00:31
@HAYDEN-OAI
HAYDEN-OAI force-pushed the dev/hayden/ultracite-068-no-useless-escape branch from d52f7c0 to b6b62ce Compare August 8, 2026 00:31
Base automatically changed from dev/hayden/ultracite-068-no-useless-escape to main August 8, 2026 00:55
@HAYDEN-OAI HAYDEN-OAI closed this Aug 8, 2026
@HAYDEN-OAI HAYDEN-OAI reopened this Aug 8, 2026
@openai-sdks

openai-sdks Bot commented Aug 8, 2026

Copy link
Copy Markdown

OkTest Summary

237/237 SDK tests passed in 11.585s for Node SDK PR #2149.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 174ms
tests/chat-completions-create.test.ts ✅ Passed 314ms
tests/chat-completions-stream.test.ts ✅ Passed 242ms
tests/files-content-binary.test.ts ✅ Passed 158ms
tests/files-create-multipart.test.ts ✅ Passed 161ms
tests/files-list-pagination.test.ts ✅ Passed 157ms
tests/initialize-config.test.ts ✅ Passed 236ms
tests/instance-isolation.test.ts ✅ Passed 119ms
tests/models-list.test.ts ✅ Passed 146ms
tests/responses-background-lifecycle.test.ts ✅ Passed 229ms
tests/responses-body-method-errors.test.ts ✅ Passed 382ms
tests/responses-cancel-timeout.test.ts ✅ Passed 267ms
tests/responses-cancel.test.ts ✅ Passed 257ms
tests/responses-compact-retries.test.ts ✅ Passed 256ms
tests/responses-compact.test.ts ✅ Passed 251ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 255ms
tests/responses-create-advanced.test.ts ✅ Passed 206ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.122s
tests/responses-create-errors.test.ts ✅ Passed 295ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 222ms
tests/responses-create-retries.test.ts ✅ Passed 313ms
tests/responses-create-stream-failures.test.ts ✅ Passed 232ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.182s
tests/responses-create-stream-wire.test.ts ✅ Passed 2.767s
tests/responses-create-stream.test.ts ✅ Passed 123ms
tests/responses-create-terminal-states.test.ts ✅ Passed 360ms
tests/responses-create-timeout.test.ts ✅ Passed 254ms
tests/responses-create.test.ts ✅ Passed 262ms
tests/responses-delete.test.ts ✅ Passed 243ms
tests/responses-input-items-errors.test.ts ✅ Passed 280ms
tests/responses-input-items-list.test.ts ✅ Passed 207ms
tests/responses-input-items-options.test.ts ✅ Passed 158ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 287ms
tests/responses-input-tokens-count.test.ts ✅ Passed 282ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.455s
tests/responses-not-found-errors.test.ts ✅ Passed 329ms
tests/responses-parse.test.ts ✅ Passed 232ms
tests/responses-retrieve-retries.test.ts ✅ Passed 282ms
tests/responses-retrieve.test.ts ✅ Passed 224ms
tests/responses-stored-method-errors.test.ts ✅ Passed 713ms
tests/retry-behavior.test.ts ✅ Passed 2.971s
tests/sdk-error-shape.test.ts ✅ Passed 431ms

View OkTest run #31231423970

SDK merge (9b7502586348) · head (7c515b207d32) · base (bf154b5b52d0) · OkTest (91635c6a2723)

@HAYDEN-OAI
HAYDEN-OAI added this pull request to the merge queue Aug 8, 2026
Merged via the queue into main with commit 71bc2a6 Aug 8, 2026
47 checks passed
@HAYDEN-OAI
HAYDEN-OAI deleted the dev/hayden/ultracite-069-no-throw-literal branch August 8, 2026 00:59
@openai-sdks openai-sdks Bot mentioned this pull request Aug 8, 2026
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
…2143)

- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/consistent-existence-index-check` compatibility
exception from `oxlint.config.ts`.
- Normalize the 3 existing handwritten-code `findIndex()` existence
checks to compare with `-1`.

## Additional context & links

- Oxlint cleanup stack, part 63; stacked on
openai#2141.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143 👈 this PR
openai#2144
openai#2145
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/prefer-bigint-literals` compatibility exception
from `oxlint.config.ts`.
- Replace the 3 existing test-only `BigInt()` calls with equivalent
bigint literals.

## Additional context & links

- Oxlint cleanup stack, part 64; stacked on
openai#2143.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144 👈 this PR
openai#2145
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-lonely-if` compatibility exception from
`oxlint.config.ts`.
- Flatten the 3 existing handwritten-code `else { if }` branches without
changing their conditions or bodies.

## Additional context & links

- Oxlint cleanup stack, part 65; stacked on
openai#2144.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145 👈 this PR
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-empty` compatibility exception from `oxlint.config.ts`.
- Document the intent of the 3 existing empty catch blocks without
changing control flow.

## Additional context & links

- Oxlint cleanup stack, part 66; stacked on
openai#2145.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146 👈 this PR
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `jsdoc/check-tag-names` compatibility exception from
`oxlint.config.ts`.
- Allow Jest's intentional `@jest-environment` pragma through the rule's
`definedTags` option.

## Additional context & links

- Oxlint cleanup stack, part 67; stacked on
openai#2146.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146
openai#2147 👈 this PR
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-useless-escape` compatibility exception from
`oxlint.config.ts`.
- Remove the 3 redundant escapes while preserving the email regex
character-class semantics.

## Additional context & links

- Oxlint cleanup stack, part 68; stacked on
openai#2147.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146
openai#2147
openai#2148 👈 this PR
openai#2149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants