Skip to content

chore(lint): enable no-lonely-if - #2145

Merged
HAYDEN-OAI merged 2 commits into
mainfrom
dev/hayden/ultracite-065-no-lonely-if
Aug 8, 2026
Merged

chore(lint): enable no-lonely-if#2145
HAYDEN-OAI merged 2 commits into
mainfrom
dev/hayden/ultracite-065-no-lonely-if

Conversation

@HAYDEN-OAI

@HAYDEN-OAI HAYDEN-OAI commented Aug 8, 2026

Copy link
Copy Markdown
Contributor
  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

  • Remove the no-lonely-if compatibility exception from oxlint.config.ts.
  • Flatten the 3 existing handwritten-code else { if } branches without changing their conditions or bodies.

Additional context & links

Validation

  • pnpm lint
  • pnpm exec tsc --pretty false
  • pnpm exec vitest run --config vitest.config.mts --update=none

Stack

#2141
#2143
#2144
#2145 👈 this PR
#2146
#2147
#2148
#2149

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the immediate stacked diff at this exact head. Each else { if (...) ... } rewrite is a direct else if flattening with unchanged predicates, ordering, bodies, and fallthrough, including both stable and beta Realtime URL paths and Azure constructor validation. The inherited no-lonely-if rule is now enforced without changing generated-file or import-policy boundaries. Lint, TypeScript, and focused Azure/Realtime tests pass.

@HAYDEN-OAI
HAYDEN-OAI force-pushed the dev/hayden/ultracite-064-unicorn-prefer-bigint-literals branch from c08922a to 2fc3156 Compare August 8, 2026 00:31
@HAYDEN-OAI
HAYDEN-OAI force-pushed the dev/hayden/ultracite-065-no-lonely-if branch from 9205d65 to 7c1b2eb Compare August 8, 2026 00:31
Base automatically changed from dev/hayden/ultracite-064-unicorn-prefer-bigint-literals to main August 8, 2026 00:36
@HAYDEN-OAI HAYDEN-OAI closed this Aug 8, 2026
@HAYDEN-OAI HAYDEN-OAI reopened this Aug 8, 2026
@openai-sdks

openai-sdks Bot commented Aug 8, 2026

Copy link
Copy Markdown

OkTest Summary

237/237 SDK tests passed in 10.932s for Node SDK PR #2145.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 156ms
tests/chat-completions-create.test.ts ✅ Passed 244ms
tests/chat-completions-stream.test.ts ✅ Passed 237ms
tests/files-content-binary.test.ts ✅ Passed 145ms
tests/files-create-multipart.test.ts ✅ Passed 182ms
tests/files-list-pagination.test.ts ✅ Passed 166ms
tests/initialize-config.test.ts ✅ Passed 196ms
tests/instance-isolation.test.ts ✅ Passed 117ms
tests/models-list.test.ts ✅ Passed 141ms
tests/responses-background-lifecycle.test.ts ✅ Passed 295ms
tests/responses-body-method-errors.test.ts ✅ Passed 301ms
tests/responses-cancel-timeout.test.ts ✅ Passed 225ms
tests/responses-cancel.test.ts ✅ Passed 237ms
tests/responses-compact-retries.test.ts ✅ Passed 243ms
tests/responses-compact.test.ts ✅ Passed 269ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 146ms
tests/responses-create-advanced.test.ts ✅ Passed 169ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.166s
tests/responses-create-errors.test.ts ✅ Passed 209ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 145ms
tests/responses-create-retries.test.ts ✅ Passed 243ms
tests/responses-create-stream-failures.test.ts ✅ Passed 223ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.178s
tests/responses-create-stream-wire.test.ts ✅ Passed 2.702s
tests/responses-create-stream.test.ts ✅ Passed 116ms
tests/responses-create-terminal-states.test.ts ✅ Passed 367ms
tests/responses-create-timeout.test.ts ✅ Passed 221ms
tests/responses-create.test.ts ✅ Passed 266ms
tests/responses-delete.test.ts ✅ Passed 237ms
tests/responses-input-items-errors.test.ts ✅ Passed 274ms
tests/responses-input-items-list.test.ts ✅ Passed 172ms
tests/responses-input-items-options.test.ts ✅ Passed 110ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 238ms
tests/responses-input-tokens-count.test.ts ✅ Passed 297ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.381s
tests/responses-not-found-errors.test.ts ✅ Passed 300ms
tests/responses-parse.test.ts ✅ Passed 178ms
tests/responses-retrieve-retries.test.ts ✅ Passed 292ms
tests/responses-retrieve.test.ts ✅ Passed 250ms
tests/responses-stored-method-errors.test.ts ✅ Passed 545ms
tests/retry-behavior.test.ts ✅ Passed 2.885s
tests/sdk-error-shape.test.ts ✅ Passed 297ms

View OkTest run #31230611467

SDK merge (f94f71e52b64) · head (7c1b2eb0a153) · base (d272540353c5) · OkTest (91635c6a2723)

@HAYDEN-OAI
HAYDEN-OAI added this pull request to the merge queue Aug 8, 2026
Merged via the queue into main with commit e114825 Aug 8, 2026
47 checks passed
@HAYDEN-OAI
HAYDEN-OAI deleted the dev/hayden/ultracite-065-no-lonely-if branch August 8, 2026 00:41
@openai-sdks openai-sdks Bot mentioned this pull request Aug 8, 2026
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
…2143)

- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/consistent-existence-index-check` compatibility
exception from `oxlint.config.ts`.
- Normalize the 3 existing handwritten-code `findIndex()` existence
checks to compare with `-1`.

## Additional context & links

- Oxlint cleanup stack, part 63; stacked on
openai#2141.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143 👈 this PR
openai#2144
openai#2145
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/prefer-bigint-literals` compatibility exception
from `oxlint.config.ts`.
- Replace the 3 existing test-only `BigInt()` calls with equivalent
bigint literals.

## Additional context & links

- Oxlint cleanup stack, part 64; stacked on
openai#2143.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144 👈 this PR
openai#2145
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-empty` compatibility exception from `oxlint.config.ts`.
- Document the intent of the 3 existing empty catch blocks without
changing control flow.

## Additional context & links

- Oxlint cleanup stack, part 66; stacked on
openai#2145.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146 👈 this PR
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `jsdoc/check-tag-names` compatibility exception from
`oxlint.config.ts`.
- Allow Jest's intentional `@jest-environment` pragma through the rule's
`definedTags` option.

## Additional context & links

- Oxlint cleanup stack, part 67; stacked on
openai#2146.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146
openai#2147 👈 this PR
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-useless-escape` compatibility exception from
`oxlint.config.ts`.
- Remove the 3 redundant escapes while preserving the email regex
character-class semantics.

## Additional context & links

- Oxlint cleanup stack, part 68; stacked on
openai#2147.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146
openai#2147
openai#2148 👈 this PR
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-throw-literal` compatibility exception from
`oxlint.config.ts`.
- Wrap the 3 existing thrown strings in `Error` while preserving their
messages.

## Additional context & links

- Oxlint cleanup stack, part 69; stacked on
openai#2148.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146
openai#2147
openai#2148
openai#2149 👈 this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants