Skip to content

chore(lint): enable no-empty - #2146

Merged
HAYDEN-OAI merged 3 commits into
mainfrom
dev/hayden/ultracite-066-no-empty
Aug 8, 2026
Merged

chore(lint): enable no-empty#2146
HAYDEN-OAI merged 3 commits into
mainfrom
dev/hayden/ultracite-066-no-empty

Conversation

@HAYDEN-OAI

@HAYDEN-OAI HAYDEN-OAI commented Aug 8, 2026

Copy link
Copy Markdown
Contributor
  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

  • Remove the no-empty compatibility exception from oxlint.config.ts.
  • Document the intent of the 3 existing empty catch blocks without changing control flow.

Additional context & links

Validation

  • pnpm lint
  • pnpm exec tsc --pretty false
  • pnpm exec vitest run --config vitest.config.mts --update=none

Stack

#2141
#2143
#2144
#2145
#2146 👈 this PR
#2147
#2148
#2149

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the immediate stacked diff at this exact head. The three formerly empty catches retain identical control flow and now document their intentional suppression accurately: best-effort ecosystem cleanup, partial-number fallback, and non-JSON OAuth error bodies. The inherited no-empty rule is enforced for handwritten code while generated exclusions remain intact. Lint, TypeScript, focused parser/auth tests, and exact-head CI pass.

@openai-sdks

openai-sdks Bot commented Aug 8, 2026

Copy link
Copy Markdown

OkTest Summary

237/237 SDK tests passed in 8.787s for Node SDK PR #2146.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 117ms
tests/chat-completions-create.test.ts ✅ Passed 182ms
tests/chat-completions-stream.test.ts ✅ Passed 99ms
tests/files-content-binary.test.ts ✅ Passed 110ms
tests/files-create-multipart.test.ts ✅ Passed 142ms
tests/files-list-pagination.test.ts ✅ Passed 128ms
tests/initialize-config.test.ts ✅ Passed 112ms
tests/instance-isolation.test.ts ✅ Passed 93ms
tests/models-list.test.ts ✅ Passed 118ms
tests/responses-background-lifecycle.test.ts ✅ Passed 167ms
tests/responses-body-method-errors.test.ts ✅ Passed 227ms
tests/responses-cancel-timeout.test.ts ✅ Passed 202ms
tests/responses-cancel.test.ts ✅ Passed 176ms
tests/responses-compact-retries.test.ts ✅ Passed 175ms
tests/responses-compact.test.ts ✅ Passed 163ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 92ms
tests/responses-create-advanced.test.ts ✅ Passed 160ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.168s
tests/responses-create-errors.test.ts ✅ Passed 181ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 121ms
tests/responses-create-retries.test.ts ✅ Passed 210ms
tests/responses-create-stream-failures.test.ts ✅ Passed 205ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.13s
tests/responses-create-stream-wire.test.ts ✅ Passed 1.975s
tests/responses-create-stream.test.ts ✅ Passed 131ms
tests/responses-create-terminal-states.test.ts ✅ Passed 135ms
tests/responses-create-timeout.test.ts ✅ Passed 191ms
tests/responses-create.test.ts ✅ Passed 112ms
tests/responses-delete.test.ts ✅ Passed 124ms
tests/responses-input-items-errors.test.ts ✅ Passed 132ms
tests/responses-input-items-list.test.ts ✅ Passed 146ms
tests/responses-input-items-options.test.ts ✅ Passed 105ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 224ms
tests/responses-input-tokens-count.test.ts ✅ Passed 155ms
tests/responses-malformed-inputs.test.ts ✅ Passed 1.642s
tests/responses-not-found-errors.test.ts ✅ Passed 197ms
tests/responses-parse.test.ts ✅ Passed 139ms
tests/responses-retrieve-retries.test.ts ✅ Passed 179ms
tests/responses-retrieve.test.ts ✅ Passed 180ms
tests/responses-stored-method-errors.test.ts ✅ Passed 556ms
tests/retry-behavior.test.ts ✅ Passed 3.004s
tests/sdk-error-shape.test.ts ✅ Passed 258ms

View OkTest run #31230819021

SDK merge (4fac5c2191e5) · head (4f3baa5a3ef8) · base (e1148259af3a) · OkTest (91635c6a2723)

@HAYDEN-OAI
HAYDEN-OAI added this pull request to the merge queue Aug 8, 2026
Merged via the queue into main with commit 8862525 Aug 8, 2026
47 checks passed
@HAYDEN-OAI
HAYDEN-OAI deleted the dev/hayden/ultracite-066-no-empty branch August 8, 2026 00:45
@openai-sdks openai-sdks Bot mentioned this pull request Aug 8, 2026
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
…2143)

- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/consistent-existence-index-check` compatibility
exception from `oxlint.config.ts`.
- Normalize the 3 existing handwritten-code `findIndex()` existence
checks to compare with `-1`.

## Additional context & links

- Oxlint cleanup stack, part 63; stacked on
openai#2141.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143 👈 this PR
openai#2144
openai#2145
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/prefer-bigint-literals` compatibility exception
from `oxlint.config.ts`.
- Replace the 3 existing test-only `BigInt()` calls with equivalent
bigint literals.

## Additional context & links

- Oxlint cleanup stack, part 64; stacked on
openai#2143.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144 👈 this PR
openai#2145
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-lonely-if` compatibility exception from
`oxlint.config.ts`.
- Flatten the 3 existing handwritten-code `else { if }` branches without
changing their conditions or bodies.

## Additional context & links

- Oxlint cleanup stack, part 65; stacked on
openai#2144.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145 👈 this PR
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `jsdoc/check-tag-names` compatibility exception from
`oxlint.config.ts`.
- Allow Jest's intentional `@jest-environment` pragma through the rule's
`definedTags` option.

## Additional context & links

- Oxlint cleanup stack, part 67; stacked on
openai#2146.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146
openai#2147 👈 this PR
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-useless-escape` compatibility exception from
`oxlint.config.ts`.
- Remove the 3 redundant escapes while preserving the email regex
character-class semantics.

## Additional context & links

- Oxlint cleanup stack, part 68; stacked on
openai#2147.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146
openai#2147
openai#2148 👈 this PR
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-throw-literal` compatibility exception from
`oxlint.config.ts`.
- Wrap the 3 existing thrown strings in `Error` while preserving their
messages.

## Additional context & links

- Oxlint cleanup stack, part 69; stacked on
openai#2148.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146
openai#2147
openai#2148
openai#2149 👈 this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants