Skip to content

chore(lint): enable no-useless-escape - #2148

Merged
HAYDEN-OAI merged 5 commits into
mainfrom
dev/hayden/ultracite-068-no-useless-escape
Aug 8, 2026
Merged

chore(lint): enable no-useless-escape#2148
HAYDEN-OAI merged 5 commits into
mainfrom
dev/hayden/ultracite-068-no-useless-escape

Conversation

@HAYDEN-OAI

@HAYDEN-OAI HAYDEN-OAI commented Aug 8, 2026

Copy link
Copy Markdown
Contributor
  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

  • Remove the no-useless-escape compatibility exception from oxlint.config.ts.
  • Remove the 3 redundant escapes while preserving the email regex character-class semantics.

Additional context & links

Validation

  • pnpm lint
  • pnpm exec tsc --pretty false
  • pnpm exec vitest run --config vitest.config.mts --update=none

Stack

#2141
#2143
#2144
#2145
#2146
#2147
#2148 👈 this PR
#2149

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The no-useless-escape activation and two cleanup edits are behavior-preserving; lint, targeted path tests, regex equivalence checks, file sizes, and exact-head CI are clean.

@HAYDEN-OAI
HAYDEN-OAI force-pushed the dev/hayden/ultracite-068-no-useless-escape branch from d52f7c0 to b6b62ce Compare August 8, 2026 00:31
@HAYDEN-OAI
HAYDEN-OAI force-pushed the dev/hayden/ultracite-067-jsdoc-check-tag-names branch from a6d775c to c8929ac Compare August 8, 2026 00:31
Base automatically changed from dev/hayden/ultracite-067-jsdoc-check-tag-names to main August 8, 2026 00:50
@HAYDEN-OAI HAYDEN-OAI closed this Aug 8, 2026
@HAYDEN-OAI HAYDEN-OAI reopened this Aug 8, 2026
@openai-sdks

openai-sdks Bot commented Aug 8, 2026

Copy link
Copy Markdown

OkTest Summary

237/237 SDK tests passed in 9.098s for Node SDK PR #2148.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 116ms
tests/chat-completions-create.test.ts ✅ Passed 146ms
tests/chat-completions-stream.test.ts ✅ Passed 230ms
tests/files-content-binary.test.ts ✅ Passed 120ms
tests/files-create-multipart.test.ts ✅ Passed 101ms
tests/files-list-pagination.test.ts ✅ Passed 165ms
tests/initialize-config.test.ts ✅ Passed 149ms
tests/instance-isolation.test.ts ✅ Passed 113ms
tests/models-list.test.ts ✅ Passed 99ms
tests/responses-background-lifecycle.test.ts ✅ Passed 143ms
tests/responses-body-method-errors.test.ts ✅ Passed 302ms
tests/responses-cancel-timeout.test.ts ✅ Passed 213ms
tests/responses-cancel.test.ts ✅ Passed 171ms
tests/responses-compact-retries.test.ts ✅ Passed 186ms
tests/responses-compact.test.ts ✅ Passed 170ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 98ms
tests/responses-create-advanced.test.ts ✅ Passed 147ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.089s
tests/responses-create-errors.test.ts ✅ Passed 166ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 130ms
tests/responses-create-retries.test.ts ✅ Passed 184ms
tests/responses-create-stream-failures.test.ts ✅ Passed 155ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.161s
tests/responses-create-stream-wire.test.ts ✅ Passed 2.18s
tests/responses-create-stream.test.ts ✅ Passed 63ms
tests/responses-create-terminal-states.test.ts ✅ Passed 188ms
tests/responses-create-timeout.test.ts ✅ Passed 199ms
tests/responses-create.test.ts ✅ Passed 127ms
tests/responses-delete.test.ts ✅ Passed 117ms
tests/responses-input-items-errors.test.ts ✅ Passed 255ms
tests/responses-input-items-list.test.ts ✅ Passed 211ms
tests/responses-input-items-options.test.ts ✅ Passed 87ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 216ms
tests/responses-input-tokens-count.test.ts ✅ Passed 176ms
tests/responses-malformed-inputs.test.ts ✅ Passed 1.819s
tests/responses-not-found-errors.test.ts ✅ Passed 250ms
tests/responses-parse.test.ts ✅ Passed 160ms
tests/responses-retrieve-retries.test.ts ✅ Passed 188ms
tests/responses-retrieve.test.ts ✅ Passed 155ms
tests/responses-stored-method-errors.test.ts ✅ Passed 490ms
tests/retry-behavior.test.ts ✅ Passed 2.999s
tests/sdk-error-shape.test.ts ✅ Passed 204ms

View OkTest run #31231229477

SDK merge (f4744ea2aeca) · head (b6b62ce24093) · base (f7e60a9958d7) · OkTest (91635c6a2723)

@HAYDEN-OAI
HAYDEN-OAI added this pull request to the merge queue Aug 8, 2026
Merged via the queue into main with commit bf154b5 Aug 8, 2026
47 checks passed
@HAYDEN-OAI
HAYDEN-OAI deleted the dev/hayden/ultracite-068-no-useless-escape branch August 8, 2026 00:55
@openai-sdks openai-sdks Bot mentioned this pull request Aug 8, 2026
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
…2143)

- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/consistent-existence-index-check` compatibility
exception from `oxlint.config.ts`.
- Normalize the 3 existing handwritten-code `findIndex()` existence
checks to compare with `-1`.

## Additional context & links

- Oxlint cleanup stack, part 63; stacked on
openai#2141.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143 👈 this PR
openai#2144
openai#2145
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/prefer-bigint-literals` compatibility exception
from `oxlint.config.ts`.
- Replace the 3 existing test-only `BigInt()` calls with equivalent
bigint literals.

## Additional context & links

- Oxlint cleanup stack, part 64; stacked on
openai#2143.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144 👈 this PR
openai#2145
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-lonely-if` compatibility exception from
`oxlint.config.ts`.
- Flatten the 3 existing handwritten-code `else { if }` branches without
changing their conditions or bodies.

## Additional context & links

- Oxlint cleanup stack, part 65; stacked on
openai#2144.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145 👈 this PR
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-empty` compatibility exception from `oxlint.config.ts`.
- Document the intent of the 3 existing empty catch blocks without
changing control flow.

## Additional context & links

- Oxlint cleanup stack, part 66; stacked on
openai#2145.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146 👈 this PR
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `jsdoc/check-tag-names` compatibility exception from
`oxlint.config.ts`.
- Allow Jest's intentional `@jest-environment` pragma through the rule's
`definedTags` option.

## Additional context & links

- Oxlint cleanup stack, part 67; stacked on
openai#2146.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146
openai#2147 👈 this PR
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-throw-literal` compatibility exception from
`oxlint.config.ts`.
- Wrap the 3 existing thrown strings in `Error` while preserving their
messages.

## Additional context & links

- Oxlint cleanup stack, part 69; stacked on
openai#2148.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146
openai#2147
openai#2148
openai#2149 👈 this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants