chore(lint): enable unicorn/consistent-existence-index-check - #2143
Merged
HAYDEN-OAI merged 15 commits intoAug 8, 2026
Merged
Conversation
This was referenced Aug 8, 2026
jbeckwith-oai
approved these changes
Aug 8, 2026
jbeckwith-oai
left a comment
Contributor
There was a problem hiding this comment.
The three rewrites are semantically equivalent because Array.prototype.findIndex returns only -1 or a nonnegative index, and the newly enabled rule now passes across the handwritten source. The immediate stacked diff is minimal, introduces no file-size or structural regression, and local lint, typecheck, focused emitter tests, and exact-head CI all pass.
Base automatically changed from
dev/hayden/ultracite-062-no-new-wrappers
to
main
August 8, 2026 00:24
HAYDEN-OAI
deleted the
dev/hayden/ultracite-063-unicorn-consistent-existence-index-check
branch
August 8, 2026 00:29
Draft
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/prefer-bigint-literals` compatibility exception from `oxlint.config.ts`. - Replace the 3 existing test-only `BigInt()` calls with equivalent bigint literals. ## Additional context & links - Oxlint cleanup stack, part 64; stacked on openai#2143. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2141 openai#2143 openai#2144 👈 this PR openai#2145 openai#2146 openai#2147 openai#2148 openai#2149
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged
## Changes being requested
- Remove the `no-lonely-if` compatibility exception from
`oxlint.config.ts`.
- Flatten the 3 existing handwritten-code `else { if }` branches without
changing their conditions or bodies.
## Additional context & links
- Oxlint cleanup stack, part 65; stacked on
openai#2144.
- Preserves generated-file exclusions and repository-specific import
policy.
### Validation
- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`
## Stack
openai#2141
openai#2143
openai#2144
openai#2145 👈 this PR
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `no-empty` compatibility exception from `oxlint.config.ts`. - Document the intent of the 3 existing empty catch blocks without changing control flow. ## Additional context & links - Oxlint cleanup stack, part 66; stacked on openai#2145. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2141 openai#2143 openai#2144 openai#2145 openai#2146 👈 this PR openai#2147 openai#2148 openai#2149
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `jsdoc/check-tag-names` compatibility exception from `oxlint.config.ts`. - Allow Jest's intentional `@jest-environment` pragma through the rule's `definedTags` option. ## Additional context & links - Oxlint cleanup stack, part 67; stacked on openai#2146. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2141 openai#2143 openai#2144 openai#2145 openai#2146 openai#2147 👈 this PR openai#2148 openai#2149
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `no-useless-escape` compatibility exception from `oxlint.config.ts`. - Remove the 3 redundant escapes while preserving the email regex character-class semantics. ## Additional context & links - Oxlint cleanup stack, part 68; stacked on openai#2147. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2141 openai#2143 openai#2144 openai#2145 openai#2146 openai#2147 openai#2148 👈 this PR openai#2149
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `no-throw-literal` compatibility exception from `oxlint.config.ts`. - Wrap the 3 existing thrown strings in `Error` while preserving their messages. ## Additional context & links - Oxlint cleanup stack, part 69; stacked on openai#2148. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2141 openai#2143 openai#2144 openai#2145 openai#2146 openai#2147 openai#2148 openai#2149 👈 this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
unicorn/consistent-existence-index-checkcompatibility exception fromoxlint.config.ts.findIndex()existence checks to compare with-1.Additional context & links
Validation
pnpm lintpnpm exec tsc --pretty falsepnpm exec vitest run --config vitest.config.mts --update=noneStack
#2141
#2143 👈 this PR
#2144
#2145
#2146
#2147
#2148
#2149