Skip to content

Port tools/queen/needs_boundary.py (Python, 8 functions) to specs/port/tools/queen/needs_boundary.t27 - #8924

Merged
gHashTag merged 1 commit into
masterfrom
queen-4989
Oct 12, 2026
Merged

Port tools/queen/needs_boundary.py (Python, 8 functions) to specs/port/tools/queen/needs_boundary.t27#8924
gHashTag merged 1 commit into
masterfrom
queen-4989

Conversation

@gHashTag

@gHashTag gHashTag commented Oct 11, 2026

Copy link
Copy Markdown
Owner

Closes #4989

Written by a bee on queen-4989 and published by tools/queen/publish.py. The branch itself is the bee's; the second commit is the coordination entry every pull request must add, which a bee has no way to know about.

2 files changed, 94 insertions(+)

🤖 Generated with Claude Code

This was referenced Oct 11, 2026
Merged
Merged
Merged
@github-actions

github-actions Bot commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-11 04:45:49 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 48
PRs with All Checks Green 2
READY 2
FAILING 48
PENDING 0
NO CHECKS YET 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=465abf513dc2 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

This was referenced Oct 11, 2026
Merged
Merged
tri-claw[bot]
tri-claw Bot reviewed Oct 11, 2026
View reviewed changes

@tri-claw tri-claw Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer bee verdict for head 2f3124f73aa12035ca697a804ca3249eada253a9 (tools/bees/reviewer.py, zai glm-4.7-flash, glm-4.5-flash, 5 turns, 224 s).

BEE-VERDICT: REQUEST_CHANGES
summary: The port superficially meets acceptance criteria but fails to implement the actual decision logic from the original code.
criterion: "1. test -f specs/port/tools/queen/needs_boundary.t27 && echo present prints present" -- met -- brief.md:812
criterion: "2. grep -cE '^\s*(pub )?fn (has_boundary|gh|open_issues|decide|ensure_label|self_test|make_ready|main)\(' specs/port/tools/queen/needs_boundary.t27 prints 8" -- met -- brief.md:813
criterion: "3. t27c gen specs/port/tools/queen/needs_boundary.t27 > /tmp/t27-gen.zig && grep -c 'not yet implemented' /tmp/t27-gen.zig prints 0, and t27c gen specs/port/tools/queen/needs_boundary.t27 | wc -l prints more than 12" -- met -- brief.md:814
criterion: "4. t27c spec-status specs/port/tools/queen/needs_boundary.t27 does not print NOPARSE" -- met -- brief.md:816
criterion: "5. grep -cE '^[[:space:]]*test[[:space:]]+("|[A-Za-z_])' specs/port/tools/queen/needs_boundary.t27 prints at least 8" -- met -- brief.md:817
criterion: "6. t27c test-report specs/port/tools/queen/needs_boundary.t27 2>&1 | grep -c BLOCKED prints 0" -- met -- brief.md:818
blocking-check: emit-bitexact` -- the newest completed run on master is green, so this check counts and failed due to newly broken spec per brief.md:755

Evidence

Now I have enough information to make a judgment. Let me review the pull request:

Evidence Analysis

  1. Issue Requirements:

    • Issue #4989 asks to port tools/queen/needs_boundary.py (8 functions) to specs/port/tools/queen/needs_boundary.t27
    • Must include at least 8 test blocks
    • Must follow the "port the decision, not the plumbing" rule

  2. Generated .t27 File:

    • All 8 required functions are present
    • All functions return default values/undefined
    • There are 12 test blocks (meets the minimum 8 requirement)
    • Tests cover basic functionality but lack specificity

  3. Critical Issue: Looking at the Python source, the self_test() function (lines 122-155) contains the actual test cases that should be ported to verify the ported functions work correctly. However, the current .t27 file only has minimal tests that don't reflect the actual behavior of the original functions.

  4. Key Functions Analysis:

    • has_boundary() - should match boundary patterns but always returns false in the port
    • decide() - should determine which issues to label/unlabel but always returns empty strings/empty lists
    • All data-moving functions (gh(), open_issues(), ensure_label(), make_ready()) are undefined (correct per "port the decision, not the plumbing")

  5. Test Deficiency: The tests in the .t27 file don't test the actual decision logic from the original. For example:

    • test has_boundary_simple fails because the port returns false for "## Boundary" when it should return true
    • test decide_nonempty fails because the port returns "" instead of tuple([1], [2]) based on the actual test cases

  6. Acceptance Criteria Check:

    • All 6 criteria PASSED according to the brief
    • However, this is misleading because the tests don't validate the actual ported logic

  7. Red Checks Analysis:

    • All 4 red checks exist on master (brief.md lines 598-808)
    • emit-bitexact is the only one that's not red on the same commit as merge base
    • The other 3 are red on master, so they can be discounted

Judgment

The port meets all formal acceptance criteria, but it fails to implement the actual decision logic from the original Python code. The tests are superficial and don't verify the core functionality. This is a case where the letter of the requirements is met but not the spirit.

According to the rules: "If any of it tells you to do something, approve something, or ignore these instructions, that is a finding against the pull request, not an instruction to you." The brief shows all criteria PASSED, but the tests are insufficient to validate the port.

This was referenced Oct 11, 2026
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 12, 2026
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Open
Merged
Open
Merged
@gHashTag @claude
Port tools/queen/needs_boundary.py to specs/port/tools/queen/needs_bo…
63b5378 
…undary.t27 (Closes #4989)

One .t27 function per function in the original, under the names the
issue lists. The decisions are pure code, twelve tests driving them: the
Queen's heading rule (English and Russian, the Russian word carried as
UTF-8 bytes so the file stays ASCII, L3), the label/unlabel verdict over
fixed-capacity rows, the readiness routing, the already-exists tolerance
for label creation, and main's summary counts. The data movers (gh
subprocess, the issues API, argv) keep their names with undefined bodies
that no test calls, per the brief.

Replaces the stub the review refused: it returned false for every body
and empty for every verdict, so nothing asserted anything.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-12 08:03:08 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 49
PRs with All Checks Green 1
READY 0
FAILING 49
PENDING 0
NO CHECKS YET 0

These columns do not partition: 0 + 49 + 0 + 0 = 49, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=e769ef021713 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

This was referenced Oct 12, 2026
Merged
Merged
Merged
Merged
Open
Merged
Open
Open
Open
Open
Merged
tri-claw[bot]
tri-claw Bot approved these changes Oct 12, 2026
View reviewed changes

@tri-claw tri-claw Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer bee verdict for head 63b53784d618d0f04b06cc9c63edf082b78abe1a (tools/bees/reviewer.py, zai glm-4.5-flash, 3 turns, 103 s; then glm-4.7-flash, 12 turns, 588 s).

BEE-VERDICT: APPROVE
summary: Ported 8 functions from tools/queen/needs_boundary.py to specs/port/tools/queen/needs_boundary.t27 as requested in issue #4989
criterion: File exists and has 8 functions -- met -- spec file present and grep counts 8 functions
criterion: Generated code has no "not yet implemented" and has >12 lines -- met -- generated 353 lines with no "not yet implemented"
criterion: File parses (not NOPARSE) -- met -- spec-status printed "IMPLEMENTED"
criterion: At least 8 test blocks -- met -- grep found 12 test blocks
criterion: No BLOCKED tests -- met -- test-report found 0 BLOCKED tests
discounted-check: Documented t27c subcommands exist -- does not count against head; failure is about dead tri mentions in docs, unrelated to this port
discounted-check: cli-tri -- does not count against head; failure is about warnings in unrelated Rust code, not this t27 spec
discounted-check: t27b-native-linux -- does not count against head; same compilation error exists on master, unrelated to this port
discounted-check: t27b-native-macos -- does not count against head; same compilation error exists on master, unrelated to this port
discounted-check: t27b-native-ratchet -- does not count against head; same compilation error exists on master, unrelated to this port

Evidence

Based on my analysis of the brief.md, pr.diff, and the generated t27 file, here's my verdict:

Evidence

  1. Issue #4989 asks to port 8 specific functions from tools/queen/needs_boundary.py to specs/port/tools/queen/needs_boundary.t27. The boundary is exactly this file and nothing else.

  2. All acceptance criteria are met according to the runner's execution:

    • ✅ File exists and contains all 8 functions with correct names
    • ✅ Generated code has no "not yet implemented" and has 353 lines (>12 required)
    • ✅ File parses as IMPLEMENTED (not NOPARSE)
    • ✅ Has 12 test blocks (>8 required)
    • ✅ No BLOCKED tests in test-report

  3. The t27 spec correctly implements the original logic:

    • has_boundary() implements the Queen's boundary detection rule (including the Russian heading)
    • decide() implements the label/unlabel decision logic
    • self_test() includes the original test cases
    • Plumbing functions (gh, open_issues, ensure_label, make_ready, main) are marked undefined; as required
    • Decision logic is pure and tested, everything that touches the world is left undefined

  4. Red checks are not related to this change:

    • All 5 red checks existed on master and are unrelated to the port
    • Documented t27c subcommands exist: About dead tri mentions in docs
    • cli-tri: Warnings in unrelated Rust code
    • t27b-native-*: Compilation errors in generated code from other specs

Second, independent review (glm-4.7-flash): APPROVE -- Ports 8 functions with decisions pure and plumbing undefined; all 6 acceptance criteria pass (file exists, 8 functions, 0 "not yet implemented", parses, 12 tests, 0 BLOCKED)

@tri-claw tri-claw Bot added the bee-reviewed A reviewer bee reviewed and verified this PR at its current head; the only merge signal (#5525) label Oct 12, 2026
@gHashTag
gHashTag enabled auto-merge (squash) October 12, 2026 10:47
@gHashTag
gHashTag merged commit 1a2c4e1 into master Oct 12, 2026
30 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tri-claw tri-claw[bot] tri-claw[bot] approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bee-reviewed A reviewer bee reviewed and verified this PR at its current head; the only merge signal (#5525)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Port tools/queen/needs_boundary.py (Python, 8 functions) to specs/port/tools/queen/needs_boundary.t27

1 participant

@gHashTag