Repository navigation
[API tests] Set sales quote document and posting dates in API tests - #12680
Prangshuman Das (t-prda) wants to merge 1 commit into
Conversation
Align quote dates with the work date before converting to an order and re-enable the make-order tests. AB#646383 AB#653393 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
fe76e3a to
89f5e34
Compare
|
The re-enabled test commits setup data at this line but does not declare TransactionModel::AutoCommit. With the test codeunit's default transaction model, the test can fail at Commit instead of reaching its assertions. Declare the method AutoCommit and ensure the executing test runner provides the required isolation for the committed setup. Knowledge: Line mapping was unavailable, so this was posted as an issue comment. 👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.50.6 |
1 similar comment
|
The re-enabled test commits setup data at this line but does not declare TransactionModel::AutoCommit. With the test codeunit's default transaction model, the test can fail at Commit instead of reaching its assertions. Declare the method AutoCommit and ensure the executing test runner provides the required isolation for the committed setup. Knowledge: Line mapping was unavailable, so this was posted as an issue comment. 👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.50.6 |
Review focus: date setup in two sales quote tests.
Area fix (previously #11227): aligns sales quote document and posting dates, then re-enables the affected tests.
Related: AB#646383, AB#653393
Stack (each PR shows only its own layer; merge bottom first)
main)Experiments (on D8, do not merge): #12685 E single tenant, #12686 F no clean execution. Combined validation (do not merge): #12687, same tree as D8.
Platform:
mainalready pins BCPlatform 30.0.56112.0, which includes the SQL connection-pool fix (AB#653457).Note for CI: AL-Go's new-warning check needs a CI/CD baseline from the base branch, and
features/*bases have none, so a PR build there fails with a 404. The current CI runs were triggered while these PRs targetedmain, so their results are valid for the cumulative change.