Skip to content

[API tests] Set sales quote document and posting dates in API tests - #12680

Open
Prangshuman Das (t-prda) wants to merge 1 commit into
features/646383-stack-d3-localized-discountsfrom
features/646383-stack-d4-quote-dates
Open

Prangshuman Das (t-prda) wants to merge 1 commit into
features/646383-stack-d3-localized-discountsfrom
features/646383-stack-d4-quote-dates

Conversation

@t-prda

@t-prda Prangshuman Das (t-prda) commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Review focus: date setup in two sales quote tests.

Area fix (previously #11227): aligns sales quote document and posting dates, then re-enables the affected tests.

Related: AB#646383, AB#653393

Stack (each PR shows only its own layer; merge bottom first)

  1. [API tests] Default to web service key authentication #12674 A: web service key auth (base: main)
  2. [Expense tests] Re-enable Expense Agent API tests #12675 B: Expense API tests + clean test codeunit execution
  3. [API tests] Re-enable APIV1 and APIV2 API tests #12676 C: re-enable APIV1/APIV2 API tests
  4. Area fixes: [API tests] Ensure VAT posting setup in API document fixtures #12677 D1 VAT fixtures → [API tests] Ensure cancellation reason codes in API sales document tests #12678 D2 cancellation reasons → [API tests] Handle localized purchase invoice payment discounts in APIV1 tests #12679 D3 localized discounts → [API tests] Set sales quote document and posting dates in API tests #12680 D4 quote dates → [API tests] Assign a number series to API vendor payment journals #12681 D5 journal numbering → [API tests] Ignore localized fields in API document comparisons #12682 D6 field comparison → [API tests] Return shipment PDF selection and pdfDocument test isolation #12683 D7 PDF documents → [API tests] Improve APIV1 fixture and verification reliability #12684 D8 APIV1 reliability

Experiments (on D8, do not merge): #12685 E single tenant, #12686 F no clean execution. Combined validation (do not merge): #12687, same tree as D8.

Platform: main already pins BCPlatform 30.0.56112.0, which includes the SQL connection-pool fix (AB#653457).

Note for CI: AL-Go's new-warning check needs a CI/CD baseline from the base branch, and features/* bases have none, so a PR build there fails with a 404. The current CI runs were triggered while these PRs targeted main, so their results are valid for the cumulative change.

@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Oct 12, 2026
@github-actions github-actions Bot added the Team: Integrations GitHub request for Integrations area label Oct 12, 2026
@t-prda
Prangshuman Das (t-prda) changed the base branch from features/646383-stack-d3-localized-discounts to main October 12, 2026 11:13
@github-actions github-actions Bot added Build: Automation Workflows and other setup in .github folder Build: scripts & configs Build scripts and configuration files labels Oct 12, 2026
@github-actions github-actions Bot added this to the Version 30.0 milestone Oct 12, 2026
@github-actions github-actions Bot added Team: SCM GitHub request for SCM area and removed Team: Integrations GitHub request for Integrations area labels Oct 12, 2026
Align quote dates with the work date before converting to an order and re-enable the
make-order tests.

AB#646383
AB#653393

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
@t-prda
Prangshuman Das (t-prda) force-pushed the features/646383-stack-d4-quote-dates branch from fe76e3a to 89f5e34 Compare October 12, 2026 11:28
@t-prda
Prangshuman Das (t-prda) changed the base branch from main to features/646383-stack-d3-localized-discounts October 12, 2026 12:29
@t-prda
Prangshuman Das (t-prda) added this pull request to stack #12697 October 12, 2026 15:38
@t-prda
Prangshuman Das (t-prda) marked this pull request as ready for review October 13, 2026 08:58
@t-prda
Prangshuman Das (t-prda) requested a review from a team October 13, 2026 08:58
@t-prda
Prangshuman Das (t-prda) requested a review from a team as a code owner October 13, 2026 08:58
@github-actions github-actions Bot added Team: Integrations GitHub request for Integrations area and removed Team: SCM GitHub request for SCM area labels Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

$\textbf{🟠\ High\ Severity\ —\ Testing}$

The re-enabled test commits setup data at this line but does not declare TransactionModel::AutoCommit. With the test codeunit's default transaction model, the test can fail at Commit instead of reaching its assertions. Declare the method AutoCommit and ensure the executing test runner provides the required isolation for the committed setup.

Knowledge:

Line mapping was unavailable, so this was posted as an issue comment.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.50.6

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

$\textbf{🟠\ High\ Severity\ —\ Testing}$

The re-enabled test commits setup data at this line but does not declare TransactionModel::AutoCommit. With the test codeunit's default transaction model, the test can fail at Commit instead of reaching its assertions. Declare the method AutoCommit and ensure the executing test runner provides the required isolation for the committed setup.

Knowledge:

Line mapping was unavailable, so this was posted as an issue comment.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.50.6

This branch was successfully deployed

1 active deployment
triage — 89f5e34c Deployed Oct 13, 2026 by t-prda via Classify team ownership #7623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Build: Automation Workflows and other setup in .github folder Build: scripts & configs Build scripts and configuration files Team: Integrations GitHub request for Integrations area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant