Repository navigation
[API tests] Default to web service key authentication - #12674
Draft
Prangshuman Das (t-prda) wants to merge 1 commit into
Draft
Prangshuman Das (t-prda) wants to merge 1 commit into
Prangshuman Das (t-prda) wants to merge 1 commit into
Conversation
This was referenced Oct 12, 2026
This was referenced Oct 12, 2026
Authenticate API test requests with the current user's web service key and remove the container password and Key Vault credential plumbing (ApiTestCredential, password cleanup, PipelineFinalize hooks). Containers disable NavHttpClient anti-SSRF so API tests can call the local server. Clean-tenant execution logic is unchanged. Adds the shared SetLicenseSafeWorkDate and AddFieldToIgnoreIfExists helpers to Library - Graph Mgt. AB#646383 AB#653393 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Prangshuman Das (t-prda)
force-pushed
the
features/646383-stack-a-webkey-auth
branch
from
October 12, 2026 11:28
e8e2b21 to
3a7dc6e
Compare
Prangshuman Das (t-prda)
added this pull request to stack #12697
October 12, 2026 15:38
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review focus:
MicrosoftTestAuthProvider(about 60 lines) and the enum default; thebuild/changes are deletions plus the anti-SSRF line inNewBcContainer.ps1.Defaults API test authentication (
Library - Graph Mgt) to the current user's web service key. API tests no longer need per-app auth uptake or a container password.API Test Authenticationenum:DefaultImplementation=Microsoft Test Auth Provider. RemovesNo API Test Auth Providerand the explicitMicrosoft Test Environmentvalue.Microsoft Test Auth Provider: on-premises with NavUserPassword, sends Basic auth withUserId()and the web service key. The key is created (24h expiry) when missing or expired and committed, because the API request runs in a separate server session.Library - Graph Mgt: adds theSetLicenseSafeWorkDateandAddFieldToIgnoreIfExistshelpers used by later layers.ApiTestCredential.psm1,Remove-ApiTestPassword.ps1,PipelineFinalizehooks and their tests). Keeps the clean-tenant execution logic. SetsNavHttpClientAntiSSRFEnabled=falsein the test container, as NAVRunALTests.ps1does: since Migrate API test libraries off Http Web Request Mgt. #12323, API tests call the container's own endpoint through ALHttpClient, which anti-SSRF blocks.API Test Auth Provider Tests: covers key creation and renewal.Related: AB#646383, AB#653393
Stack (each PR shows only its own layer; merge bottom first)
main)Experiments (on D8, do not merge): #12685 E single tenant, #12686 F no clean execution. Combined validation (do not merge): #12687, same tree as D8.
Platform:
mainalready pins BCPlatform 30.0.56112.0, which includes the SQL connection-pool fix (AB#653457).Note for CI: AL-Go's new-warning check needs a CI/CD baseline from the base branch, and
features/*bases have none, so a PR build there fails with a 404. The current CI runs were triggered while these PRs targetedmain, so their results are valid for the cumulative change.