Repository navigation
[API tests] Ensure VAT posting setup in API document fixtures - #12677
Draft
Prangshuman Das (t-prda) wants to merge 1 commit into
Draft
Prangshuman Das (t-prda) wants to merge 1 commit into
Prangshuman Das (t-prda) wants to merge 1 commit into
Conversation
This was referenced Oct 12, 2026
Prangshuman Das (t-prda)
changed the base branch from
features/646383-stack-c-api-reenable
to
main
October 12, 2026 11:12
Create missing VAT posting setup for item, item charge, resource and G/L account lines in API document fixtures and re-enable the affected line and item variant tests. AB#646383 AB#653393 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Prangshuman Das (t-prda)
force-pushed
the
features/646383-stack-d1-vat-fixtures
branch
from
October 12, 2026 11:28
0e866a1 to
18057ba
Compare
Prangshuman Das (t-prda)
changed the base branch from
main
to
features/646383-stack-c-api-reenable
October 12, 2026 12:29
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review focus:
LibraryGraphDocumentTools.EnsureVATPostingSetupExistsand its call sites.Area fix (previously #11224): ensures a VAT posting setup exists for API document fixtures, then re-enables the affected tests.
Related: AB#646383, AB#653393
Stack (each PR shows only its own layer; merge bottom first)
main)Experiments (on D8, do not merge): #12685 E single tenant, #12686 F no clean execution. Combined validation (do not merge): #12687, same tree as D8.
Platform:
mainalready pins BCPlatform 30.0.56112.0, which includes the SQL connection-pool fix (AB#653457).Note for CI: AL-Go's new-warning check needs a CI/CD baseline from the base branch, and
features/*bases have none, so a PR build there fails with a 404. The current CI runs were triggered while these PRs targetedmain, so their results are valid for the cumulative change.