Repository navigation
[API tests] Handle localized purchase invoice payment discounts in APIV1 tests - #12679
Draft
Prangshuman Das (t-prda) wants to merge 1 commit into
Conversation
This was referenced Oct 12, 2026
github-actions
Bot
added
the
Team: Integrations
Prangshuman Das (t-prda)
changed the base branch from
features/646383-stack-d2-cancellation-reasons
to
main
October 12, 2026 11:12
github-actions
Bot
added
Build: Automation
Set dates before vendor defaults apply, use the payment-terms discount library and accept localized payment lines, then re-enable the payment discount test. AB#646383 AB#653393 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Prangshuman Das (t-prda)
force-pushed
the
features/646383-stack-d3-localized-discounts
branch
from
October 12, 2026 11:28
240f1c2 to
4555c24
Compare
Prangshuman Das (t-prda)
changed the base branch from
main
to
features/646383-stack-d2-cancellation-reasons
October 12, 2026 12:29
Prangshuman Das (t-prda)
added this pull request to stack #12697
October 12, 2026 15:38
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review focus: one APIV1 purchase-invoice test.
Area fix (previously #11226): supports localized purchase-invoice payment discounts, then re-enables the affected test.
Related: AB#646383, AB#653393
Stack (each PR shows only its own layer; merge bottom first)
main)Experiments (on D8, do not merge): #12685 E single tenant, #12686 F no clean execution. Combined validation (do not merge): #12687, same tree as D8.
Platform:
mainalready pins BCPlatform 30.0.56112.0, which includes the SQL connection-pool fix (AB#653457).Note for CI: AL-Go's new-warning check needs a CI/CD baseline from the base branch, and
features/*bases have none, so a PR build there fails with a 404. The current CI runs were triggered while these PRs targetedmain, so their results are valid for the cumulative change.