Repository navigation
Fix shared viewer refresh coalescing and stale batch timers - #30
Merged
hsoliwal merged 1 commit intoOct 22, 2026
Conversation
Coalesce only adjacent single refresh posts for the identical target. Bind timers to their pending batch so older callbacks cannot drain newer work. Preserve ordered updates and explicit direct apply operations, with focused SWT regression and nine-variant coverage.
hsoliwal
marked this pull request as ready for review
October 21, 2026 11:14
This was referenced Oct 21, 2026
Owner
Author
|
Stacked incremental correction: UI #34 is based on this exact #30 head and retains its batch epoch, adjacent refresh coalescing and UI #27 Display-thread contract. It only pins the first post's absolute monotonic deadline against later longer delays and adds the SWT owning regression. Canonical exact-source recipes are in Synexia #12885; no public ABI or JNI symbol changes. Focused/native tests of this new increment remain pending. |
hsoliwal
added a commit
that referenced
this pull request
Oct 22, 2026
Stacked on qualified JFace queue #30, preserving queue identity, existing timer behavior, worker-safe APIs and source ancestry. Retain full platform validation as a separate gate; no squash, rebase, branch deletion.
This was referenced Oct 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Adjacent refresh posts currently accumulate redundant work. A scheduled callback from a flushed batch can also drain a newer batch, breaking the later batch's debounce window.
Change
Repair the existing
M3Viewers.Queue:REFRESHwhose target is identical to the pending tailREFRESHtarget.applyoperations.This stacks on #27 at
67cd89ec3ea55e6bf13811666ffe90fe2c6adc08. It preserves that PR's prior repairs and import-order correction. The existing broader all-viewers programme remains applicable.The production and test files are actual outputs of the unchanged canonical Synexia SDK/receiver. Recipe and complete execution evidence: hsoliwal/com.synexia#12797.
Executed validation
M3ViewersTest, four unchanged inM3ViewerDeltaTest.javapoutput is byte-identical.--release 21 -Xlint:all -Werror) passed.docs/m3/views/jface-queue-20261021/; full receipts live in the linked recipe PR.Acceptance boundary
The real UI run used published JFace 3.40.0, GTK SWT 3.135.0 and its genuine JNI, Jupiter 5.14.4, Temurin21 and official Xvfb. This qualifies the changed M3 owners on that focused closure. Full current source/Tycho/PDE acceptance on Java25 still requires the owning reactor's
mvn verifygate.Lazy providers, Problems marker-pipeline end-to-end behavior, other source-specific view adapters, Nebula and the native-platform matrix remain separately tracked. This PR does not claim the entire all-viewers programme is complete. Existing dual Apache-2.0/EPL-2.0 notices are retained.