You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Exact Eclipse source-owner repair, not an M3 wrapper
Receives four serial FILE outputs from the canonical Synexia reusable Maven/OpenRewrite recipes in Synexia PR #12787, including the two original Eclipse JFace production sources and their existing JUnit test owners. The generated target Git blobs match canonical snapshots bit for bit. No public interface, SWT JNI/native ABI, or alternative viewer model is introduced.
M3ViewerDelta.append: capture original operation count and bulk-copy all five parent-owned array lanes; self-append terminates and retains kind/element/parent/index/property reference identity and order.
M3Viewers.enqueue: original first-post delay bound is fixed using System.nanoTime, with a separate batch epoch; mixed debounce requests cannot postpone earlier events, and older Display.timerExec callbacks cannot drain successor batches.
M3ViewerDeltaTest and M3ViewersTest: new focused regression tests for self-append, mixed delays and stale-timer isolation after flush. Existing SWT/TreeViewer/TableViewer/ListViewer behavior and fallback remain the authority.
Draft only: The recipes and JUnit tests have been authored; the actual Maven/OpenRewrite replay, Tycho/PDE and native Eclipse UI/JFace test runs have not been executed in this session, and default viewer modes are unchanged. Merge only after full headless/Win32/GTK/Cocoa behavior and allocations are verified. This first shared-owner increment does not claim that Project Explorer, Outline, Properties, Progress, Search, Debug and remaining viewers are converted; their file-by-file plan is recorded in canonical VIEWER_OWNER_CENSUS.tsv and the established docs/m3/views/VIEW_INVENTORY.tsv.
I inspected the newly triggered Windows CI job Verify Windows (job 119136349353). It failed in actions/checkout before Java/Maven compilation. Git reported fatal: cannot create directory .../docs/M3-SCALE/jface-forwarding-20261017/tooling/synexia-openrewrite-recipes/recipe-crates/m3-jface-array-forwarding-20261017/resources/com/synexia/rewrite/hash-pinned-java/m3-jface-array-forwarding-20261017: Filename too long. This path is outside the four files changed by this PR. The Windows result is infrastructure/checkout blocking, not a Java regression verdict. Linux and macOS source build/test gates have not been established passing by this review; keep this PR draft. Repair the checkout/long-path runner configuration separately before accepting cross-platform IDE tests. Canonical source snapshots are in Synexia PR #12787.
Superset/collision note: this PR's older M3Viewers.java variant overlaps UI #27 (worker-safe Display) and UI #30 (refresh coalescing + stale-batch identity). Do not merge or cherry-pick the whole older file over #27/#30; it would discard qualified shared-viewer behavior. The unique first-post monotonic-deadline correction is isolated and source-sealed in Synexia #12885 and received on top of UI #30 in UI #34. The #28 bulk-array append candidate is preserved for separate measured review, not silently discarded or promoted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact Eclipse source-owner repair, not an M3 wrapper
Receives four serial FILE outputs from the canonical Synexia reusable Maven/OpenRewrite recipes in Synexia PR #12787, including the two original Eclipse JFace production sources and their existing JUnit test owners. The generated target Git blobs match canonical snapshots bit for bit. No public interface, SWT JNI/native ABI, or alternative viewer model is introduced.
M3ViewerDelta.append: capture original operation count and bulk-copy all five parent-owned array lanes; self-append terminates and retains kind/element/parent/index/property reference identity and order.M3Viewers.enqueue: original first-post delay bound is fixed usingSystem.nanoTime, with a separate batch epoch; mixed debounce requests cannot postpone earlier events, and olderDisplay.timerExeccallbacks cannot drain successor batches.M3ViewerDeltaTestandM3ViewersTest: new focused regression tests for self-append, mixed delays and stale-timer isolation after flush. Existing SWT/TreeViewer/TableViewer/ListViewer behavior and fallback remain the authority.Draft only: The recipes and JUnit tests have been authored; the actual Maven/OpenRewrite replay, Tycho/PDE and native Eclipse UI/JFace test runs have not been executed in this session, and default viewer modes are unchanged. Merge only after full headless/Win32/GTK/Cocoa behavior and allocations are verified. This first shared-owner increment does not claim that Project Explorer, Outline, Properties, Progress, Search, Debug and remaining viewers are converted; their file-by-file plan is recorded in canonical
VIEWER_OWNER_CENSUS.tsvand the establisheddocs/m3/views/VIEW_INVENTORY.tsv.