Repository navigation
fix(JFace M3): preserve first-post deadline across mixed debounce delays - #34
Merged
hsoliwal merged 2 commits intoOct 22, 2026
Conversation
This was referenced Oct 21, 2026
hsoliwal
marked this pull request as ready for review
October 22, 2026 03:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack on the already qualified shared viewer owners
This two-file PR builds on Eclipse UI #30, which already stacks on UI #27. Its Java files are byte-identical outputs from the original canonical Synexia Maven/OpenRewrite recipe in Synexia #12885, not manual Eclipse edits.
M3Viewers.Queue: keep the first post's monotonic4 * firstDelayMillisdeadline throughout the batch. Do not recalculate the hard limit from later, longer posts. Use ceiling milliseconds for pending sub-ms timer work. Retain M3: repair shared JFace viewer delta dispatch and iterative tree lookup #27 worker-safepost(Display, ...)and Fix shared viewer refresh coalescing and stale batch timers #30 originalbatchidentity,generation, adjacent-refresh coalescing and direct-apply semantics.M3ViewersTest: one UI-thread regression that posts two delays to the actual SWT viewer queue, verifies exact unchanged first deadline and checks that both changes are applied inside two seconds. All previous 18 focused Fix shared viewer refresh coalescing and stale batch timers #30 owner tests remain in the source tree unchanged.Source gates: exact #30 preimages
c2d9383a5c7d5e459885b90176b8692da0aa2842andfd50ef06701863322e25220f87b2d877a4f6dfc0; corresponding output Git blob SHA identities match recipe templates.Qualification truth: strict isolated Java21 scheduler model tested 1,250,002 assertions; no full OpenRewrite Maven replay, actual JFace/SWT UI test result, Tycho, or platform-wide runtime qualification claimed by this receiving PR. Keep DRAFT; do not merge older UI #28 wholesale over the newer #27/#30 implementations. No JNI signature/public API changes.