Repository navigation
M3 Search viewer: avoid full child-array copy under result limits - #31
Merged
Merged
Conversation
hsoliwal
marked this pull request as ready for review
October 22, 2026 02:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source-specific Problems-view-style bounded projection
This PR receives exactly one Java FILE atom from the canonical Maven/OpenRewrite recipe in Synexia #12839. It does not alter public Search/JFace APIs, filters, event delivery, callback order, or the existing single-owner content-provider map.
FileTreeContentProvider.getChildrencurrently invokeschildren.toArray()to materialize every result and then copies only the selected number whenFileSearchPage's default limit is 1,000. It now traverses the sameSetiterator for preciselyelementLimitentries into the same returned-size array, retaining identity and iteration order. The unlimited path (-1) and the normal no-limit case are unchanged. There are no new wrappers, JNI symbols or persistent per-element objects.dc9e000cd917359a8fed3edd04d0de044dd8cf6da369e231cb2328e9d2cf56d7436315ce7327065c11e3a73ed1018d2229eb654236368e62b6589318bfd9d191b16a7ac0286c3b322801504c3795dc00e9465122--release 21 -Xlint:all -Werrorand main execution: 1,606 differential checks passed, including 100,000 set entries, colliding hash keys, -2/-1/0/default/oversized limits and original object identity/order.Qualification boundary
Draft. This narrow local Java differential does not prove Eclipse Search runtime equivalence. Required checks not run: canonical Maven/OpenRewrite SDK, fixed-point/refusal under the actual Java parser and original file, Eclipse/Tycho build and Search/JFace/UI tests, all operating systems, end-to-end Problems/Search selection behavior, and comparative heap/CPU benchmarks. The canonical provenance gate remains open. Estimated complexity improves from O(total children) temporary enumeration to O(display limit) under the limiting branch; no measured speedup claimed.
Retains original Eclipse copyright and EPL-2.0 license. Distinct from shared JFace PRs #27/#28/#30 and Project Explorer #29. Full Claude marked-site inventory remains open for additional receivers.