Skip to content

Port gHashTag/BrowserOS:trios/agent-server/apps/server/src/api/routes/refine-prompt.ts (TypeScript, 1 function) to specs - #7207

Open
gHashTag wants to merge 6 commits into
masterfrom
queen-5289
Open

gHashTag wants to merge 6 commits into
masterfrom
queen-5289

Conversation

@gHashTag

@gHashTag gHashTag commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Closes #5289

Written by a bee on queen-5289 and published by tools/queen/publish.py. The branch itself is the bee's; the second commit is the coordination entry every pull request must add, which a bee has no way to know about.

1 file changed, 111 insertions(+)

🤖 Generated with Claude Code

Trinity Bee and others added 5 commits September 30, 2026 22:08
The turn ended with these files edited and never committed. Uncommitted
work is invisible to the review - it reads the branch - so the attempt
would have been released as empty and the next bee would have started
beside this work rather than from it.

This commit is not a claim that the work is correct. It is the bee's
work, committed on its behalf, and it is judged exactly like any other:
the adversarial reviewer reads it, the compiler runs on it, and the
issue's own criteria are measured against it.

Issue: #5289
Turn: 0d575a50-714b-4ad4-a810-70590cf44f97
Ending: finished (the turn closed)
Committed: 1 path(s)
Left uncommitted: 0 path(s) outside the declared boundary
The turn ended with these files edited and never committed. Uncommitted
work is invisible to the review - it reads the branch - so the attempt
would have been released as empty and the next bee would have started
beside this work rather than from it.

This commit is not a claim that the work is correct. It is the bee's
work, committed on its behalf, and it is judged exactly like any other:
the adversarial reviewer reads it, the compiler runs on it, and the
issue's own criteria are measured against it.

Issue: #5289
Turn: 4e0ac158-bb7f-45c2-90f1-9a25280c4963
Ending: finished (the turn closed)
Committed: 1 path(s)
Left uncommitted: 1 path(s) outside the declared boundary
Create specs/port/browseros/trios/agent-server/apps/server/src/api/routes/refine-prompt.t27
porting createRefinePromptRoutes function from TypeScript to .t27.

The function now has the correct signature matching the original TypeScript:
- Takes RefinePromptRouteDeps parameter with optional browseros_id
- Has undefined body for HTTP plumbing (Hono routes)
- Core decision logic extracted to pure functions:
  - validateRefinePromptRequest: validates input prompt and name
  - extractLLMConfig: extracts LLM configuration from request
  - extractRefinePromptInput: extracts prompt and name for refinement
  - statusCodeFromResult: determines HTTP status from result success

Added comprehensive tests covering:
- Input validation (valid, empty prompt, empty name)
- Configuration extraction with various providers and parameters
- Input extraction correctness
- Status code mapping for success/failure cases

All acceptance criteria met:
- File exists and contains createRefinePromptRoutes function
- Generated code has no stubs and sufficient lines
- File parses successfully (IMPLEMENTED status)
- Contains 7 tests covering all core logic
- Generated code compiles with no BLOCKED errors

Closes #5289
- Add createRefinePromptRoutes function with proper camelCase naming
- Port decision logic for prompt validation and refinement
- Add comprehensive tests covering edge cases and success scenarios
- Handle HTTP routing plumbing as undefined per requirements

Closes #5289
A pull request must add exactly one docs/now entry and a bee has no way
to know that: its brief names a boundary file and acceptance criteria,
and docs/now/ is neither. The publisher adds it rather than failing the
gate.

Closes #5289

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-07 01:28:54 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 48
PRs with All Checks Green 2
READY 1
FAILING 48
PENDING 0
NO CHECKS YET 0

These columns do not partition: 1 + 48 + 0 + 0 = 49, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=b23641f01baa != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

This was referenced Oct 7, 2026
This was referenced Oct 7, 2026
…5289, #7573)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-07 19:23:57 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 47
PRs with All Checks Green 3
READY 1
FAILING 47
PENDING 0
NO CHECKS YET 0

These columns do not partition: 1 + 47 + 0 + 0 = 48, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=66b6e1375e37 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants