Repository navigation
test(tri): a lab run through a stand-in railway ssh (Closes #7390) - #7392
Merged
Merged
Conversation
#7050) The --lab plumbing had one branch no test reached: `railway ssh -p P -e ENV -s SVC <script>`. The only non-local test pointed at a missing railway binary and checked the error. The PR body and the #7050 comment said the ssh path was covered by the scripted tests; it was not. a_lab_run_goes_through_railway_ssh gives the run a `railway` script that records its first 7 arguments and runs the last one through sh -c. The whole run goes through it: probe, upload, launch, read-back, removal. Every recorded call must read `ssh -p p1 -e production -s t27c-lab`. On the Railway lab: cargo test --release -p tri mutate:: -> 56 passed, 0 failed, 0 warnings in mutate.rs. Negative controls, one cargo test each, file sha256 the same before and after: - drop c.arg("ssh") -> the new test fails at the argument check - drop the -p PROJECT pair -> the new test fails at the argument check Still not done: no run has gone through the real railway CLI from a Mac, since tri is not built on the Mac. That stays open on #7050. #7366 merged at 08:39:27Z, two minutes before this commit reached its branch, so it lands here with its own NOW entry (docs/now/2026-10-07-mutate-lab-ssh-test.md); #7366's entry is left as it merged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
October 7, 2026 08:45
gHashTag
added
the
owner-approved-foreign
This was referenced Oct 7, 2026
Merged
This was referenced Oct 7, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7390. Refs #7050.
What
tri mutate spec --lab(#7366) reaches the lab throughrailway ssh -p P -e ENV -s SVC <script>unlessT27C_LAB_LOCAL=1. No test drove that call: the onlylocal: falsetest points at a missingrailwayand checks the error. The #7050 comment and the #7366 body claimed coverage that did not exist; both now say so.a_lab_run_goes_through_railway_sshgives the run a stand-inrailwaythat records its first 7 arguments and runs the last one throughsh -c. The whole run goes through it (probe, upload, launch, read-back, removal). Every recorded call must readssh -p p1 -e production -s t27c-lab, the tool must start once, and the run directory must be gone.This commit was first pushed to #7366's branch two minutes after #7366 merged (08:39:27Z), so it lands here with its own NOW entry.
Results, on the Railway lab
cargo test --release -p tri mutate::: 56 passed, 0 failed, 0 warnings inmutate.rs.mutate.rson master is byte-identical to the file this ran against, apart from the new test.Negative controls, one
cargo testeach:c.arg("ssh")-p PROJECTpairGates run locally
check_now_entry_shape(1 entry, well formed),l2_regen_check(no gen/ change), own-language gate rc 0 (cli/tri/src/mutate.rsis intools/policy/foreign-exceptions.txt), gitleaks on the diff: no leaks (negative control: 1 leak found).Not done
A live run through the real
railwayCLI from a Mac: tri is not built on the Mac. Stays open on #7050.🤖 Generated with Claude Code