Repository navigation
specs: four copied bodies reuse their originals, dupe scan green (Closes #7355) - #7359
Merged
Merged
Conversation
#7355) WAL_deinit, getRecentHistory and is_blinking_success now delegate to the function whose body they copied. review_log.t27 uses runner's str_contains; its str_starts_with (a contains scan under a prefix name) becomes a real prefix check. dupe_scan: 624 -> 615 bodies, no new group. test-report FAIL 0 on all four specs; seals saved. Closes #7355 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
This was referenced Oct 7, 2026
Merged
This was referenced Oct 7, 2026
gHashTag
added a commit
that referenced
this pull request
Oct 7, 2026
#7359 (b3617f2) turned the local str_starts_with from a substring check into a real prefix check, but all 14 tests passed with either body: every fixture line that hits a prefix rule starts with its needle. Three new test blocks answer differently under the two bodies: - a line carrying "reviewer: gh pr list" after offset 0 is OTHER, while the prefixed lines stay LISTING_ERROR_504 / LISTING_ERROR_OTHER; - the same pair for "gh pr list -R: transient failure" (OTHER vs RETRY); - direct str_starts_with asserts (needle mid-string, at start, longer than the haystack, empty needle). t27c test-report: 17 tests, 17 pass, FAIL 0, 0 vacuous. Negative control: str_starts_with body replaced by str_contains in a temp copy -> 14 pass, FAIL 3 (exactly the three new blocks). Seal re-saved. Census: tools/census/quiet.txt re-blessed. "named a path but not quiet" moved 167 -> 181, "a tracked path, present" 10 -> 12, "no path ANYWHERE in the step" 9 -> 7. `tri census explain` attributes all three to .github/workflows/auto-merge-ready-prs.yml, already on master; this commit does not move them, the pre-commit gate requires the re-bless to commit. Closes #7396 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The duplicate-bodies check (
tools/dupe_scan.py) was red on master: four new copied bodies that no ledger entry covered. All four live in.t27specs, so this change removes the copies. Nothing was blessed.gen_wal.t27:WAL_deinitnow returnsWAL_checkpoint(wal).history.t27:getRecentHistorynow callssearchHistory(cdp, "", maxResults).mvp_ternary_classifier_top.t27:is_blinking_successnow callsis_success_status.review_log.t27: importsstr_containswithuse test_framework::runner::str_contains;. Itsstr_starts_withhad a contains-scan body under a prefix name; it is now a real prefix check.Scan before: 624 duplicate bodies in 185 groups, 4 errors. After: 615 bodies in 181 groups, "ok: no new duplicate body".
t27c test-reportshows FAIL 0 on all four specs (8/17/6/14 pass). Seals were saved witht27c seal --save, and the NOW entry was written withtri now add.Closes #7355
🤖 Generated with Claude Code