specs/port/tools: SKIP_SUFFIX, USER_OPCODE and the jtag tests are t27 (#5735) - #5736
Merged
Merged
Conversation
…#5735) check_conflict_markers wrote a Rust/Zig array, read_verdict a Python dict, and both jtag specs braceless tests of Zig statements. The parser dropped 15 + 25 + 55 tokens: SKIP_SUFFIX had no value in the generated Zig, and every jtag test body was empty. They are now t27 arrays and braced tests. read_user1's `result == result` becomes `result < 16` (user1 masks to nbits = 4). read_user1 and read_verdict leave the ledger. check_conflict_markers is re-keyed to the typecheck failure the discard hid (a 4-argument _git stub called with 7 arguments), and max_entries goes from 134 to 132. Closes #5735 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes #5735 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This was referenced Oct 3, 2026
Contributor
This was referenced Oct 3, 2026
Contributor
PR DashboardGenerated at: 2026-10-03 10:57:51 UTC
Summary
Seal Status
|
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5735
t27c parse-complete --shownow printsnothing discardedforcheck_conflict_markers(was 15 tokens),jtag/read_user1(25) andjtag/read_verdict(55).SKIP_SUFFIXnow has its seven suffixes in the generated Zig (it had no value).USER_OPCODEis a[5]u8array whose index 0 is unused, soUSER_OPCODE[chain]keeps its 1..4 chain numbers.read_user1's tautologyresult == resultbecomesresult < 16, becauseuser1masks to 4 bits. No check was deleted.zig ast-checkerrors: 1→1, 0→0, 4→3.test-reportis BLOCKED on master and here alike, by existing stub and type problems in each spec.read_user1andread_verdictleave it.check_conflict_markersis re-keyed fromparse-no-discardtotypecheckunder Fifteen ported specs do not parse and need their ports redone #5549: once it parses whole, the 4-argument_gitstub called with 7 arguments shows.max_entriesdrops by two, to 128 on top of specs/numeric: GF8/20/24/32 invariants check concrete points instead of prose the parser drops #5702 (which had already lowered it to 130; master is merged in). A localt27c suite --ratchet --corpus-onlyreportsRATCHET: CLEAN.🤖 Generated with Claude Code