Repository navigation
specs/fpga: test checks written as 'invariant <expr>;' become then/and assertions - #5731
Merged
Merged
Conversation
…d assertions (#5730) Inside a braceless test, 'invariant <expr>;' opened a new top-level invariant named after the first identifier and the parser discarded the rest, so six tests in power_analysis and vcd_conformance_compare ran their setup and asserted nothing (gen emitted 'invariant: r NOT CHECKED' stubs). The 9 expressions are now then/and assertions of their tests, unchanged. Seals regenerated with this tree's t27c; both parse-no-discard ledger entries are removed. Closes #5730 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This was referenced Oct 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5730
In two FPGA specs, braceless tests ended in
invariant <expr>;. That keyword opens a new top-level invariant, so the parser closed the test, named a stray invariantrortotal, and discarded the expression. Six tests ran their setup and asserted nothing;t27c genemitted eight// invariant: r NOT CHECKEDstubs.invariant <expr>;is nowthen <expr>/and <expr>in its own test. The 9 expressions are unchanged.parse-complete --show: power_analysis 3 ->nothing discarded; vcd_conformance_compare 38 ->nothing discarded.t27c genof vcd_conformance_compare:NOT CHECKEDstubs 8 -> 0;r.total_checks == 1assertions 0 -> 3. power_analysis gainstotal > 0.ast-check0 errors before and after.test-reportis BLOCKED on both before and after by the same pre-existing errors outside the changed lines.--verifyreports all hashes MATCH.parse-no-discardentries removed fromdocs/reports/suite_expectations.json; localt27c suite --ratchet --corpus-only: RATCHET CLEAN.🤖 Generated with Claude Code