Repository navigation
specs/ternary: bigint Trit constants get their values instead of a discarded '.neg' - #5743
Merged
Merged
Conversation
…scarded '.neg' (#5742) TRIT_NEG/ZERO/POS were initialised with a bare '.neg'/'.zero'/'.pos' that the const-declaration parser discards, so gen emitted constants with no value ('pub const TRIT_NEG: Trit;'). They are now Trit.neg/zero/pos; zig ast-check goes from 4 errors to 0. Seals regenerated with this tree's t27c; the parse-no-discard ledger entry is removed. Closes #5742 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5742
specs/ternary/bigint.t27initialisedTRIT_NEG,TRIT_ZEROandTRIT_POSwith a bare.neg/.zero/.pos, which the const-declaration parser discards.t27c genemittedpub const TRIT_NEG: Trit;-- constants with no value.Trit.neg,Trit.zero,Trit.pos.parse-complete --show: 6 token(s) DISCARDED ->nothing discarded.ast-check: 4 errors on master (3 xvariables must be initialized, 1 undeclaredTrit) -> 0.test-reportis BLOCKED before and after, but later now:unable to load 'Trit.zig'(use tritype-base::Tritresolves to no module) instead of the uninitialised constants.--verifyreports all hashes MATCH.parse-no-discardentry is removed fromdocs/reports/suite_expectations.json; localt27c suite --ratchet --corpus-only: RATCHET CLEAN.🤖 Generated with Claude Code