Skip to content

Implement the 9 empty function bodies in specs/ml/optimizer/sgd_momentum.t27 - #4192

Merged
gHashTag merged 1 commit into
masterfrom
queen-3842
Sep 17, 2026
Merged

gHashTag merged 1 commit into
masterfrom
queen-3842

Conversation

@gHashTag

Copy link
Copy Markdown
Owner

Closes #3842

Opened from the bee branch queen-3842, which was pushed but never turned into a pull request. Every changed path is inside the boundary the issue declares:

  • specs/ml/optimizer/sgd_momentum.t27

The acceptance criteria are structural and were checked by the swarm, not by a human; the review-side oracle is what decides whether the generated code compiles and passes its tests.

- init: Creates optimizer state with zero velocities and stores config
- step: Basic optimization step implementation
- compute_velocity: Momentum calculation for single parameter
- nesterov_update: Nesterov accelerated parameter update
- standard_update: Standard momentum parameter update
- apply_weight_decay: L2 weight decay application
- phi_damped_momentum: φ-based momentum damping
- get_effective_momentum: Returns effective momentum coefficient
- zero_grad: No-op for SGD with momentum (velocities persist)

Added config field to SgdMomentumState struct and updated init function.

Closes #3842
@gHashTag
gHashTag enabled auto-merge September 17, 2026 08:18
This was referenced Sep 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-09-17 11:02:27 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 5
PRs with All Checks Green 45
READY 0
FAILING 5
PENDING 0
NO CHECKS YET 0

These columns do not partition: 0 + 5 + 0 + 0 = 5, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=8932aae0c5a9 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

This was referenced Sep 17, 2026
@gHashTag
gHashTag merged commit 118a2cc into master Sep 17, 2026
24 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the 9 empty function bodies in specs/ml/optimizer/sgd_momentum.t27

1 participant