Skip to content

Integrate transcript corrections and Review feedback repairs - #2824

Open
Chris0Jeky wants to merge 20 commits into
mainfrom
issue-2235/review-milestone-integration
Open

Integrate transcript corrections and Review feedback repairs#2824
Chris0Jeky wants to merge 20 commits into
mainfrom
issue-2235/review-milestone-integration

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

This integration delivers immutable transcript correction, Review theme inheritance and truthful refresh-health feedback, plus the rendered night-palette comparison. Save remains separate from Ask AI, and Review/Approve/Apply remains explicit. No palette selection or release acceptance is inferred.

Reviewed source commits are preserved without source edits:

Candidate Scope Included head
#2820 Rendered palette comparison and measurements d6df080
#2821 Review inherits the selected theme 66e5eac
#2822 Immutable linked transcript correction, including rerouting fix 9d2cf79
#2823 Scope-owned refresh health with retained warnings 19a9878

Every source is an ancestor and each owned file exactly matches its source head. The 38-file integration has no conflict-resolution edits. Source candidates completed independent Terra reviews; the two confirmed HIGH defects were fixed once, tested red-first and passed separate fresh-context fix reviews. Their review records remain on the source PRs.

Combined verification at ee90123:

  • dotnet test backend/Taskdeck.sln -c Release -m:1: exit0;9092passed/5skipped. Domain1636, Application4243, API2906+4skip, CLI243, Architecture28+1skip, Integration36. The run started at a6a3f0b; its backend tree is byte-identical at the final integration head, which only adds the frontend health fix.
  • npx --no-install vitest --run --maxWorkers=2: exit0;393files,6234passed/3skipped.
  • Chromium:4passed in21.5s across paper-review-theme, transcript-correction and review-queue-recovery. The capture UI flow uses mocked responses; the real correction/re-triage/worker/proposal chain is separately covered by the API suite.
  • Build, typecheck, scoped ESLint and diffcheck pass. Documentation links674files/0broken; contrast58pairs across4palettes. Synthetic browser ports58747/5185 are stopped.

Remaining scope:

Source PRs remain open until this integration actually lands; then exact merge-tree reconciliation will determine superseded closure. Required current-head hosted CI and the post-push aging floor remain the merge gate.

Refs #1999, #2009, #2214, #2235.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T12:18:34.913686Z ee90123 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Independent fresh-context Terra high integration review: SHIP at ee90123 against843a8f6cb. The four source heads are ancestors, their38owned paths exactly equal the integration diff and match each source head, and all merge conflict-resolution diffs are empty. No hidden source edits, new cross-feature coupling, runtime database artifacts or credential-bearing additions were found. Palette evidence is synthetic/source-bound and makes no adoption claim. The reviewer ran no tests; combined executable evidence is recorded above. Required hosted CI remains outstanding.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee90123c6c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread backend/src/Taskdeck.Application/Services/CaptureService.cs
Comment thread backend/src/Taskdeck.Application/Services/CaptureService.cs
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Both source-fidelity findings are confirmed MEDIUM, non-blocking, and tracked with exact follow-up checks on #1999: #1999 (comment). Line-ending normalization preserves semantic text and prior immutable sources but loses new-input byte fidelity; title-only saves preserve content but add redundant revisions. Neither changes authorization or proposal execution. The source fix round is complete; no extra fix cascade.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

PARKED — confirmed HIGH retained-health loss on B -> All boards -> failed load. Executable proof, exact heads, and resume contract: #2214 (comment). Source #2823 exhausted its review/fix round; this is not a new CRITICAL introduced by fixes. Do not merge this candidate or bypass the ceiling through integration. PR remains open and ready, branch/history preserved. Independent sound sources are proceeding separately; #2820 is merged. All non-blocking feedback has separate tracked disposition.

@Chris0Jeky Chris0Jeky moved this from Review to Blocked in Taskdeck Execution Sep 9, 2026
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Parked integration worktree cleanup complete. Tracked tree was clean and HEAD ee90123 was verified preserved on the remote branch; no active runtime process referenced the checkout. Before plain git worktree remove, unique .tmp runtime/database/log/reproducer evidence and frontend test-results were copied OUT to C:\Users\jekyt\source\Taskdeck.claude\local\milestone-20260909\preserved-2824 (runtime-and-verification and test-results). Rebuildable bin/obj/dist/node_modules were discarded. The HIGH diagnostic log now lives under that preserved runtime-and-verification folder. PR and all source commits remain open/preserved; no merge or third fix. Primary still has only its original untracked local directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Blocked

Development

Successfully merging this pull request may close these issues.

1 participant