Allow canceling a loading inline capture editor - #2825
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent Terra review: SHIP at source6b51834e7eda8f960f34a169bba94ab4491fc829. The generation is invalidated before abort, the store cache predicate rejects late writes, late success/error cannot reopen the editor, loading Cancel preserves held drafts, and focus returns only when owned by the closing editor. No HIGH/CRITICAL or lower-severity finding. Root inspected the later E2E username-string adjustment and frontend-identical main merge to7e6e5e0f; no new production logic. Browser1pass/focused119pass/typecheck/doclinks674/0 on completed refreshed candidate. Hosted CI still pending; ProjectReview/PriorityII and closingrefs0 verified. |
|
Completed source worktree removed after clean tracked state, remote-head preservation and no-active-process checks. Before plain git worktree remove, .tmp verification/runtime/review-diff evidence, test-results, and the original synthetic taskdeck.e2e.db with its sidecars/migration lock were copied OUT to C:\Users\jekyt\source\Taskdeck.claude\local\milestone-20260909\preserved-2825. No shared database was reset; rebuildable bin/obj/dist/node_modules were discarded. Source branch and all commits remain remote; primary/unrelated worktrees preserved. |
|
Final combined candidate #2826 atf7e65bfbddccbf197ea3c7d258b05ef9418a4c6a preserves this reviewed source and passes fullfrontend6234/3skip, combinedChromium5, typecheck/build/lint/doclinks, and freshTerraSHIP. Holding individual merge while that exact combined tree qualifies. This replaces the earlier separate-delivery plan; parked2823/2824 remain excluded. Keep source open until integration delivery and source-content proof. |
|
Delivered through integration #2826, merged as 06bd4d1. Coordinator verified the actual main tree equals qualified f7e65bf exactly (tree 7315d28ec3a2e709da4f701f4489a864ec2c36e2), and all three source heads are ancestors. GitHub automatically marked the source PRs merged through the preserved merge commits. Required ci-required.yml run34353507971 passed, independent Terra SHIP, no unresolved threads. Previously tracked MEDIUM limitations remain follow-ups; no full parent-issue completion claim. |
A held capture-detail request can leave the inline Paper editor loading indefinitely while its row controls remain disabled. Loading now offers Cancel, aborts the read, rejects late component/cache updates, and restores the row controls. Existing held drafts survive, and focus returns to Edit only when it belonged to the closing editor. This completes the inline-loading behavior from original #1999 item 4 while preserving Save and explicit Ask AI semantics.
Refs #1999. Five files only: the two Paper triage components, their focused tests, and one browser regression. No backend, API, store, locale, or canonical docs changes.
Validation:
7e6e5e0f5db14b1762eb9160f47934a888687f79/ base22fcac405946e226c136e2fd52be3b8cdf9ecca7.npx --no-install vitest --run --maxWorkers=2at production-logic source7284b0966: 6234 passed, 3 skipped. Subsequent frontend delta is only the new E2E spec; the main merge adds only reviewed palette evidence.Required hosted CI and head aging remain pending. OUTSTANDING_TASKS.md is unchanged; parent #1999 retains other lineage and tracked follow-ups. This PR is independent of parked #2823/#2824.