Integrate Review theme and capture correction improvements - #2826
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Fresh independent Terra integration review SHIP atf7e65bfbddccbf197ea3c7d258b05ef9418a4c6a/base22fcac405. All three sourceheads are ancestors, parked2823/2824 are not; only the three supplied merge commits and no hidden/manual conflict-resolution edits. The shared PaperTriageTable.spec preserves the transcript fail-closed assertion plus inline-cancel coverage. Combined theme/abort/cache/held-draft/CAS behavior has no confirmedHIGH/CRITICAL. Reviewer ran guard, pin, ancestry/diff inspections and diffcheck; root separately observed fullfrontend6234pass3skip and combinedChromium5pass, both exit0. Required hosted CI remains pending. |
|
Completed integration checkout removed after clean tracked state, remote preservation of f7e65bf, stopped ports and no-active-process checks. Unique .tmp build/full-suite/browser logs, synthetic SQLite DB and review diff, plus frontend test-results, were copied OUT to C:\Users\jekyt\source\Taskdeck.claude\local\milestone-20260909\preserved-2826 (runtime-and-verification and test-results) before plain git worktree remove. Only rebuildable bin/obj/dist/node_modules were discarded. Branch/source history remains remote; primary and unrelated worktrees preserved. Hosted CI still qualifies the exact candidate; no merge claim. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7e65bfbdd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
MEDIUM/tracked, not fix-now: #1999 (comment). The fixed delay weakens the browser late-fulfillment assertion; it does not establish a production defect. Deferred component tests deterministically resolve/reject after Cancel and verify abort/cache-generation/late-state guards. Browser Cancel/control/focus recovery remains proved; fully settled route fulfillment is not claimed. No additional fix commit for a non-blocking review finding. |
|
Delivered through integration #2826, merged as 06bd4d1. Coordinator verified the actual main tree equals qualified f7e65bf exactly (tree 7315d28ec3a2e709da4f701f4489a864ec2c36e2), and all three source heads are ancestors. GitHub automatically marked the source PRs merged through the preserved merge commits. Required ci-required.yml run34353507971 passed, independent Terra SHIP, no unresolved threads. Previously tracked MEDIUM limitations remain follow-ups; no full parent-issue completion claim. |
Combine three reviewed improvements to the capture/review flow: Review keeps selected night colours and structural styles; owned proposal-less Triaged transcripts support immutable correction followed by explicit Ask AI; loading inline capture editors can cancel safely without losing held drafts or accepting late responses. These reduce correction and navigation friction while preserving server authorization and review-first approval.
Source commits are preserved:
5ee00c4bf34923640976318d79cf8e69b7663431883e25589a97d6c2743a94bc65fd48bb9dd5e3e07e6e5e0f5db14b1762eb9160f47934a888687f79Head
f7e65bfbddccbf197ea3c7d258b05ef9418a4c6a, base22fcac405946e226c136e2fd52be3b8cdf9ecca7. Seventeen net paths, three conflict-free source merges. The one overlapping test file preserves both source changes. Parked #2823 and #2824 are not ancestors and their refresh-health change is absent; neither review ceiling is reopened or bypassed.Validation:
npx --no-install vitest --run --maxWorkers=2: 393 files, 6234 passed, 3 skipped; observed exit 0 (138.52s).7a36d704e5002e5df34897b682c9c04cb33591deexactly matches the earlier observeddotnet test backend/Taskdeck.sln -c Release -m:1exit-0 run: 9092 passed/5 skipped. No redundant backend suite was run for subsequent frontend-only changes. That run includes real correction -> re-triage -> hosted-worker proposal and SQLite rollback proof.Required hosted CI and head aging are pending. Known MEDIUMs remain tracked on #1999: old-run provenance beside corrected text, raw line-ending fidelity, and title-only duplicate revisions. Theme palette selection, D4 dogfooding, CLI authority, private cutover and release acceptance remain as recorded in OUTSTANDING_TASKS.md. This candidate does not claim milestone completion or release authorization.
Refs #1999, #2009, #1968, #2235.
Browser proof limit: the Cancel test uses a fixed delay after releasing the held route, so complete late fulfillment is not asserted deterministically. Deferred unit tests cover late resolve/reject and cache guards; browser synchronization follow-up is tracked on #1999 (comment5602276565).