Skip to content

Integrate Review theme and capture correction improvements - #2826

Merged
Chris0Jeky merged 17 commits into
mainfrom
issue-2235/sound-review-integration
Sep 9, 2026
Merged

Integrate Review theme and capture correction improvements#2826
Chris0Jeky merged 17 commits into
mainfrom
issue-2235/sound-review-integration

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Combine three reviewed improvements to the capture/review flow: Review keeps selected night colours and structural styles; owned proposal-less Triaged transcripts support immutable correction followed by explicit Ask AI; loading inline capture editors can cancel safely without losing held drafts or accepting late responses. These reduce correction and navigation friction while preserving server authorization and review-first approval.

Source commits are preserved:

Head f7e65bfbddccbf197ea3c7d258b05ef9418a4c6a, base 22fcac405946e226c136e2fd52be3b8cdf9ecca7. Seventeen net paths, three conflict-free source merges. The one overlapping test file preserves both source changes. Parked #2823 and #2824 are not ancestors and their refresh-health change is absent; neither review ceiling is reopened or bypassed.

Validation:

  • Independent fresh-context Terra integration review: SHIP, no CRITICAL/HIGH. Source reviews and their bounded fix reviews also completed.
  • npx --no-install vitest --run --maxWorkers=2: 393 files, 6234 passed, 3 skipped; observed exit 0 (138.52s).
  • Combined Chromium: 5 passed, observed exit 0 (33.9s): populated light/night theme (2), mocked capture-correction Save/Ask-AI UI (1), loading Cancel/control/focus recovery (1), existing revision-lock keyboard/decision barrier (1). The last test exercises P/Space outside editable fields, preserves typing inside them, and invokes native inspection controls while decisions remain locked.
  • Typecheck, production frontend build, scoped ESLint on all eight changed Vue/TypeScript files, doc links (674 files/0 broken), and diff check pass. API Release build: 0 warnings/0 errors.
  • Backend tree 7a36d704e5002e5df34897b682c9c04cb33591de exactly matches the earlier observed dotnet test backend/Taskdeck.sln -c Release -m:1 exit-0 run: 9092 passed/5 skipped. No redundant backend suite was run for subsequent frontend-only changes. That run includes real correction -> re-triage -> hosted-worker proposal and SQLite rollback proof.
  • Browser used a fresh synthetic SQLite DB with Mock providers; owned ports58750/5188 stopped. No live provider or private data used. Generated snapshot stat noise was cleared only after its normalized Git blob exactly matched HEAD; no content change was committed.

Required hosted CI and head aging are pending. Known MEDIUMs remain tracked on #1999: old-run provenance beside corrected text, raw line-ending fidelity, and title-only duplicate revisions. Theme palette selection, D4 dogfooding, CLI authority, private cutover and release acceptance remain as recorded in OUTSTANDING_TASKS.md. This candidate does not claim milestone completion or release authorization.

Refs #1999, #2009, #1968, #2235.

Browser proof limit: the Cancel test uses a fixed delay after releasing the held route, so complete late fulfillment is not asserted deterministically. Deferred unit tests cover late resolve/reject and cache guards; browser synchronization follow-up is tracked on #1999 (comment5602276565).

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T12:57:54.240560Z f7e65bf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky Chris0Jeky moved this from Pending to Review in Taskdeck Execution Sep 9, 2026
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Fresh independent Terra integration review SHIP atf7e65bfbddccbf197ea3c7d258b05ef9418a4c6a/base22fcac405. All three sourceheads are ancestors, parked2823/2824 are not; only the three supplied merge commits and no hidden/manual conflict-resolution edits. The shared PaperTriageTable.spec preserves the transcript fail-closed assertion plus inline-cancel coverage. Combined theme/abort/cache/held-draft/CAS behavior has no confirmedHIGH/CRITICAL. Reviewer ran guard, pin, ancestry/diff inspections and diffcheck; root separately observed fullfrontend6234pass3skip and combinedChromium5pass, both exit0. Required hosted CI remains pending.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Completed integration checkout removed after clean tracked state, remote preservation of f7e65bf, stopped ports and no-active-process checks. Unique .tmp build/full-suite/browser logs, synthetic SQLite DB and review diff, plus frontend test-results, were copied OUT to C:\Users\jekyt\source\Taskdeck.claude\local\milestone-20260909\preserved-2826 (runtime-and-verification and test-results) before plain git worktree remove. Only rebuildable bin/obj/dist/node_modules were discarded. Branch/source history remains remote; primary and unrelated worktrees preserved. Hosted CI still qualifies the exact candidate; no merge claim.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7e65bfbdd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/taskdeck-web/tests/e2e/capture-edit-loading-cancel.spec.ts
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

MEDIUM/tracked, not fix-now: #1999 (comment). The fixed delay weakens the browser late-fulfillment assertion; it does not establish a production defect. Deferred component tests deterministically resolve/reject after Cancel and verify abort/cache-generation/late-state guards. Browser Cancel/control/focus recovery remains proved; fully settled route fulfillment is not claimed. No additional fix commit for a non-blocking review finding.

@Chris0Jeky
Chris0Jeky merged commit 06bd4d1 into main Sep 9, 2026
37 checks passed
@Chris0Jeky
Chris0Jeky deleted the issue-2235/sound-review-integration branch September 9, 2026 13:27
@github-project-automation github-project-automation Bot moved this from Review to Done in Taskdeck Execution Sep 9, 2026
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Delivered through integration #2826, merged as 06bd4d1. Coordinator verified the actual main tree equals qualified f7e65bf exactly (tree 7315d28ec3a2e709da4f701f4489a864ec2c36e2), and all three source heads are ancestors. GitHub automatically marked the source PRs merged through the preserved merge commits. Required ci-required.yml run34353507971 passed, independent Terra SHIP, no unresolved threads. Previously tracked MEDIUM limitations remain follow-ups; no full parent-issue completion claim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant