Show measured night palettes on real Paper surfaces - #2820
Conversation
…tes' into issue-2009/night-palette-rendered
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent Terra high review of the comparison package atc73ad490bdb1d20932088c5aed7059dd6af30787: SHIP, no direct blocker. Reviewer checked all15 PNG dimensions, variant/surface coverage, token receipts, synthetic fixture reuse, excluded runtime state and explicit Review experimental-override wording. Root inspected the corrected captures. Final integration/source-binding and full-resolution-link edits atab565bb5 are documentation-only and passed doc links; no palette or production logic changed. |
|
Closeout coordination: this PR arrived after the frozen integration/dispatcher cutoff and remains with its author lane. #2815 is delivered and only #2819 is still qualifying in this closeout. Canonical shipped-state records were added to #2819; please avoid moving main until its final gate/merge completes, so that run is not invalidated again. This comment does not adopt or review #2820. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab565bb5d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Confirmed MEDIUM reproducibility follow-up from #2820 review: retained |
|
Closeout lane release: #2819 has landed at843a8f6cba22417a030e9f2e3143c3469fc1aaf7 with required CI green. Existing-PR closeout and canonical delivery-doc lease are complete. This later PR remains owned by its author lane; refresh/reconcile against current main before merge under the normal gate. |
|
Current-base qualification update: merged main843a8f6cba22417a030e9f2e3143c3469fc1aaf7, new headd6df08027710051259432e06f2e3009cfba05e51. Base delta is unused dispatcher deletion plus delivery docs; the evidence patch is unchanged (stable patch-iddeccc4bc175db2ed90b84616b4425dfc98643e0e). Contrast58pairs/4palettes and doclinks674/0broken pass on the current base, diff clean. Existing evidence review remains applicable. No recapture or palette adoption is implied; screenshot source binding and the tracked standalone-harness API-address limitation remain unchanged. New hosted qualification is required before merge. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6df080277
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Confirmed MEDIUM harness follow-up from #2820 review3967919115: root visibility plus body-text length does not guarantee seeded content finished loading on a slower rerun. A future recapture should wait for surface-specific populated content and disappearance of loading states. This does not establish a defect in the delivered15 screenshots: their dimensions/tokens were checked and the actual candidate images were independently inspected. It limits automated rerun reliability; no universal ready-state guarantee is claimed. Track alongside API-origin binding5600931394 under #2009, without another fix cascade in this evidence-only PR. |
|
Integration candidate #2824 is ready at ee90123. This source head and its owned files are preserved exactly. Combined local qualification passed: backend9092/5skip with aggregateexit0, frontend6234/3skip, Chromium4, build/typecheck/lint/docslinks. The integration introduces no source edits and retains the completed source review/fix records. Please hold individual merges while #2824 qualifies against current main. This source PR remains open; it will be closed as superseded only after actual integration delivery and exact merge-tree proof. No parent issue or human acceptance is closed early. |
|
Worktree cleanup complete: clean tracked state and source HEAD ancestry in pushed integration #2824 (ee90123) were verified; the owned source worktree was removed with plain git worktree remove. Unique ignored runtime/test artifacts were copied OUT first to C:\Users\jekyt\source\Taskdeck.claude\local\milestone-20260909\preserved-2820. Source branch refs and commits remain preserved; this PR stays open pending integration qualification and review disposition. Primary checkout and unrelated worktrees were preserved. |
|
Delivery plan update: the combined integration #2824 is held on newly arrived source findings. This independent rendered-palette evidence package has no such blocker: exact head d6df080 / base843a8f6c has all hosted checks green, completed independent Terra review, aged head, and all connector findings dispositioned. Delivering this sound source separately; this supersedes the earlier integration-only hold for #2820. No palette default is adopted; D6 still requires the maintainer choice. |
1 participant
Provide the measured night-palette comparison requested by D-6(a): three existing candidate directions plus current night and light references, rendered on real Home, Today and Review pages at1440x1000. The HTML contact sheet links to full-resolution images. No production CSS or palette adoption changes.
Refs #2009.
Evidence: one synthetic Mock fixture across15 Chromium PNGs; browser assertions verify all dimensions and candidate token values at the actual surface roots. Contrast generator checks58 pairs across four palettes, preserving primary ink and accents. Browser capture1/1, doc links674 files, measurement and diff checks pass. One Terra high review found no blocker; root inspected the corrected images and completed full-resolution links/source binding.
Source binding: screenshots reflect application base64508d3e2f2d9dc8f8ea9aa5e9eb4539173ccb08 and saved candidate definitions209d5af1c5758f10305e4fe68b28f44602807dcb. Main22029c760 was subsequently merged for integration; this does not imply a recapture. Final headab565bb5d9ce7b2d3cc25b81b3f2ee0f80b1f447.
A real parity defect is documented: Review's static nested .paper root remains light under a night shell. Current-night images preserve it; candidate Review images explicitly use experimental page-local token overrides. A separate production fix is in progress. The initial1280x720 pass was rejected and replaced before this package was committed.
Disposable databases/runtime state are excluded from the commit. The full frontend suite is not applicable to this evidence-only change. OUTSTANDING_TASKS.md D-6(a) remains open pending the maintainer's palette choice; no ADR adoption or release acceptance is inferred. Canonical product docs remain with the integration coordinator.