Skip to content

fix: support RTL layout - #175

Merged
rdlabo merged 1 commit into
mainfrom
fix/rtl-logical-properties
Sep 16, 2026
Merged

rdlabo merged 1 commit into
mainfrom
fix/rtl-logical-properties

Conversation

@rdlabo

@rdlabo rdlabo commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace LTR-only spacing and positioning with logical CSS properties
  • mirror safe-area-aware list, menu, FAB, tab bar, searchbar, toolbar, and button layout
  • update demo-only physical spacing so RTL examples render correctly
  • preserve physical glass lighting and physical safe-area padding where mirroring would be incorrect

Depends on rdlabo-dev/ionic-theme-utils#2.

Fixes #168

Verification

  • npm ci
  • npm run build
  • npm run lint

Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Playwright test results

passed  332 passed

Details

stats  332 tests across 18 suites
duration  4 minutes, 20 seconds
commit  d29a8ea
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-175/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@rdlabo
rdlabo force-pushed the fix/rtl-logical-properties branch 3 times, most recently from 2398ffb to 3f2e4f1 Compare September 16, 2026 00:56
github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@rdlabo
rdlabo force-pushed the fix/rtl-logical-properties branch from 3f2e4f1 to d468769 Compare September 16, 2026 01:00
github-actions Bot added a commit that referenced this pull request Sep 16, 2026
github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@rdlabo
rdlabo force-pushed the fix/rtl-logical-properties branch from d468769 to 35e7d6b Compare September 16, 2026 01:08
github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@rdlabo
rdlabo force-pushed the fix/rtl-logical-properties branch from 35e7d6b to 556681e Compare September 16, 2026 01:19
@rdlabo
rdlabo force-pushed the fix/rtl-logical-properties branch from 556681e to d29a8ea Compare September 16, 2026 01:27
github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@rdlabo
rdlabo merged commit 00bf1ef into main Sep 16, 2026
11 checks passed
@rdlabo
rdlabo deleted the fix/rtl-logical-properties branch September 16, 2026 01:36
@github-actions

Copy link
Copy Markdown
Contributor

npm beta published

CI passed for the merge commit 00bf1efcf4b7. Install the immutable version with:

npm install @rdlabo/ionic-theme-ios27@0.1.0-beta.pr175.sha00bf1efcf4b7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: rtl isn't supported

1 participant