fix(list): restore physical safe-area padding - #207
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
rdlabo
force-pushed
the
fix/inset-list-safe-area-duplication
branch
from
September 21, 2026 06:46
08e0b98 to
a9482e6
Compare
Contributor
Playwright test results
Details
|
rdlabo
force-pushed
the
fix/inset-list-safe-area-duplication
branch
from
September 21, 2026 06:49
a9482e6 to
a499b83
Compare
rdlabo
changed the title
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-207/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
rdlabo
force-pushed
the
fix/inset-list-safe-area-duplication
branch
from
September 21, 2026 07:01
a499b83 to
cf32fcf
Compare
Contributor
Author
|
/update-screenshots |
Contributor
|
ℹ️ No screenshot changes detected. The current screenshots are already up to date. |
rdlabo
force-pushed
the
fix/inset-list-safe-area-duplication
branch
from
September 21, 2026 07:15
cf32fcf to
9b15f0d
Compare
rdlabo
changed the title
rdlabo
force-pushed
the
fix/inset-list-safe-area-duplication
branch
from
September 21, 2026 07:19
9b15f0d to
9b52ba1
Compare
rdlabo
changed the title
Contributor
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-ios27@1.0.4-beta.pr207.sha68d50b7e8a69 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--ion-safe-area-rightpaired with the physicalpadding-rightWhy
PR #175 changed the canonical physical declaration from
padding-righttopadding-inline-endand remapped the physical safe-area variable according to writing direction. A physical viewport inset must not be mirrored as a logical component inset:--ion-safe-area-rightcorresponds topadding-rightregardless of LTR or RTL.This PR narrowly restores the pre-#175 declaration. It intentionally does not introduce a new safe-area class or change viewport layout.
The maintained
ios26branch already uses a fixed 16px native padding and does not contain this duplication.Verification
npm run build:cssnpm run lintPLAYWRIGHT_BROWSERS_PATH=/tmp/ionic-theme-pw npx playwright test e2e/rtl.spec.ts --reporter=list(2 passed)