Skip to content

fix: support RTL layout #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdlabo merged 1 commit into from
Sep 16, 2026
Merged

fix: support RTL layout #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions demo/e2e/rtl.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
import { expect, test } from '@playwright/test';

for (const direction of ['ltr', 'rtl'] as const) {
test(`${direction} mirrors logical spacing with asymmetric safe areas`, async ({ page }) => {
await page.goto('/main/index', { waitUntil: 'networkidle' });
await page.evaluate((dir) => {
const fixture = document.createElement('div');
fixture.id = 'rtl-probe';
fixture.dir = dir;
fixture.style.cssText =
'position:fixed;inset:0;z-index:99999;--ion-safe-area-left:20px;--ion-safe-area-right:8px;--ios-theme-menu-width:0px';

const fab = document.createElement('ion-fab');
fab.id = 'fab-probe';
fab.mode = 'ios';
fab.className = 'fab-horizontal-start';
fab.innerHTML = '<ion-fab-button>+</ion-fab-button>';

const tabs = document.createElement('ion-tab-bar');
tabs.id = 'tabs-probe';
tabs.mode = 'ios';
tabs.slot = 'bottom';
tabs.className = 'tab-bar-position-start';
tabs.innerHTML = '<ion-tab-button>One</ion-tab-button><ion-tab-button>Two</ion-tab-button>';

const list = document.createElement('ion-list');
list.id = 'list-probe';
list.mode = 'ios';
list.className = 'list-inset';
list.innerHTML =
'<ion-radio-group><div class="radio-group-top">Supporting text</div><ion-item>Item</ion-item></ion-radio-group><ion-note>Footer</ion-note>';

const toolbar = document.createElement('ion-toolbar');
toolbar.id = 'toolbar-probe';
toolbar.mode = 'ios';
toolbar.className = 'toolbar-searchbar';
toolbar.innerHTML = '<ion-buttons slot="start"><ion-button>Action</ion-button></ion-buttons><ion-searchbar></ion-searchbar>';

fixture.append(fab, tabs, list, toolbar);
document.body.append(fixture);
}, direction);

await expect(page.locator('#fab-probe')).toHaveClass(/hydrated/);
await expect(page.locator('#tabs-probe')).toHaveClass(/hydrated/);
await expect(page.locator('#list-probe')).toHaveClass(/hydrated/);

const values = await page.locator('#rtl-probe').evaluate((fixture) => {
const direction = fixture.getAttribute('dir');
const style = (selector: string) => getComputedStyle(fixture.querySelector(selector)!);
const fab = fixture.querySelector('#fab-probe')!.getBoundingClientRect();
const tabs = fixture.querySelector('#tabs-probe')!.getBoundingClientRect();
const note = style('#list-probe > ion-note');
const radio = style('.radio-group-top');
const toolbarButtons = style('#toolbar-probe ion-buttons');

return {
fabStart: direction === 'ltr' ? fab.left : innerWidth - fab.right,
tabsStart: direction === 'ltr' ? tabs.left : innerWidth - tabs.right,
noteStart: note.marginInlineStart,
noteEnd: note.marginInlineEnd,
radioStart: radio.paddingInlineStart,
radioEnd: radio.paddingInlineEnd,
toolbarGap: toolbarButtons.marginInlineEnd,
};
});

expect(values.fabStart).toBeCloseTo(16, 1);
expect(values.tabsStart).toBeCloseTo(direction === 'ltr' ? 36 : 24, 1);
expect(values.noteStart).toBe(direction === 'ltr' ? '40px' : '28px');
expect(values.noteEnd).toBe(direction === 'ltr' ? '28px' : '40px');
expect(values.radioStart).toBe(direction === 'ltr' ? '40px' : '28px');
expect(values.radioEnd).toBe(direction === 'ltr' ? '28px' : '40px');
expect(values.toolbarGap).toBe('6px');
});
}
2 changes: 1 addition & 1 deletion demo/src/app/album/album-page.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ion-header {
position: absolute;
top: 0;
left: 0;
inset-inline-start: 0;
}

ion-content {
Expand Down
2 changes: 1 addition & 1 deletion demo/src/app/index/pages/button/button.page.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ion-item *[slot='end'] {
margin-right: 6px;
margin-inline-end: 6px;
}
7 changes: 5 additions & 2 deletions demo/src/app/index/pages/tabs/tabs.page.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
:host {
ion-tab-bar {
margin-left: calc(16px + var(--ion-safe-area-left, 0px));
margin-right: calc(16px + var(--ion-safe-area-right, 0px));
margin-inline: calc(16px + var(--ion-safe-area-left, 0px)) calc(16px + var(--ion-safe-area-right, 0px));

&:dir(rtl) {
margin-inline: calc(16px + var(--ion-safe-area-right, 0px)) calc(16px + var(--ion-safe-area-left, 0px));
}
}
}
4 changes: 2 additions & 2 deletions demo/src/app/settings/settings-page.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ ion-item > ion-icon[slot='start'] {
ion-item > ion-icon[slot='start'] {
padding: 4px;
font-size: 1.3rem;
margin-right: 14px;
margin-inline-end: 14px;
border-radius: 8px;
}
}
Expand All @@ -24,7 +24,7 @@ ion-item > ion-icon[slot='start'] {
padding: 8px;
width: calc(40px - 16px);
height: calc(40px - 16px);
margin-right: 16px;
margin-inline-end: 16px;
border-radius: 50%;
background: var(--ion-color-light-shade);
}
Expand Down
5 changes: 3 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
},
"homepage": "https://docs.rdlabo.dev/projects/ionic-theme-ios27",
"dependencies": {
"@rdlabo/ionic-theme-utils": "git+ssh://git@github.com/rdlabo-dev/ionic-theme-utils.git#54c43a91d498a2364215d91f74f678fb696ab00c"
"@rdlabo/ionic-theme-utils": "git+ssh://git@github.com/rdlabo-dev/ionic-theme-utils.git#66eb2fccca10646ebfccdfb3b6c2f3b4c9b00bf6"
},
"devDependencies": {
"@capacitor/core": "^8.5.2",
Expand Down
7 changes: 4 additions & 3 deletions src/styles/components/ion-button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,12 +416,13 @@ ion-buttons.ios:not(.ios-theme-disabled, .ios26-disabled):not(

ion-buttons.ios:not(.ios-theme-disabled, .ios26-disabled):not(:has(ion-back-button, ion-button.button-clear)) {
ion-button {
margin: 0 6px;
margin-block: 0;
margin-inline: 6px;
&:first-child {
margin-left: 0;
margin-inline-start: 0;
}
&:last-child {
margin-right: 0;
margin-inline-end: 0;
}
&:only-child {
margin: 0;
Expand Down
14 changes: 10 additions & 4 deletions src/styles/components/ion-fab.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,13 @@ $scaleup-default-icon-only: api.$button-scaleup-default-icon-only;
$scaleup-large-icon-only: api.$button-scaleup-large-icon-only;

ion-fab.ios:not(.ios-theme-disabled, .ios26-disabled) {
--ios-theme-safe-area-inline-start: var(--ion-safe-area-left, 0px);
--ios-theme-safe-area-inline-end: var(--ion-safe-area-right, 0px);
--transform-value: 2.5px;
&:dir(rtl) {
--ios-theme-safe-area-inline-start: var(--ion-safe-area-right, 0px);
--ios-theme-safe-area-inline-end: var(--ion-safe-area-left, 0px);
}
&:has(> ion-fab-button.fab-button-small) {
--transform-value: 4px;
}
Expand Down Expand Up @@ -85,20 +91,20 @@ ion-fab.ios:not(.ios-theme-disabled, .ios26-disabled) {
}

&.fab-horizontal-start {
left: calc(16px + var(--ios-theme-menu-width, var(--ios26-menu-width, var(--ion-safe-area-left), 0px)));
inset-inline-start: calc(16px + var(--ios-theme-menu-width, var(--ios26-menu-width, var(--ios-theme-safe-area-inline-start))));
}

&.fab-horizontal-end {
right: calc(16px + var(--ion-safe-area-right, 0px));
inset-inline-end: calc(16px + var(--ios-theme-safe-area-inline-end));
}

&:has(.fab-button-small) {
&.fab-horizontal-start {
left: calc(10px + var(--ios-theme-menu-width, var(--ios26-menu-width, var(--ion-safe-area-left), 0px)));
inset-inline-start: calc(10px + var(--ios-theme-menu-width, var(--ios26-menu-width, var(--ios-theme-safe-area-inline-start))));
}

&.fab-horizontal-end {
right: calc(10px + var(--ion-safe-area-right, 0px));
inset-inline-end: calc(10px + var(--ios-theme-safe-area-inline-end));
}
}
}
Expand Down
11 changes: 10 additions & 1 deletion src/styles/components/ion-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,22 @@ ion-list.list-inset.ios:not(.ios-theme-disabled, .ios26-disabled) {
padding-inline-end: calc(var(--ion-safe-area-right, 0) + 20px);
}

&:dir(rtl) ion-radio-group > .radio-group-top {
padding-inline-start: calc(var(--ion-safe-area-right, 0) + 20px);
padding-inline-end: calc(var(--ion-safe-area-left, 0) + 20px);
}

> :is(#{structured-list.$groups}) {
ion-item {
// To draw lines inside
--inner-padding-end: 0;

&::part(native) {
padding-right: calc(var(--ion-safe-area-right, 0px) + 18px);
padding-inline-end: calc(var(--ion-safe-area-right, 0px) + 18px);
}

&:dir(rtl)::part(native) {
padding-inline-end: calc(var(--ion-safe-area-left, 0px) + 18px);
}

--min-height: 52px;
Expand Down
27 changes: 17 additions & 10 deletions src/styles/components/ion-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ ion-split-pane.ios:not(.ios-theme-disabled, .ios26-disabled).split-pane-visible:
.split-pane-main {
ion-tab-bar.ios:not(.ios-theme-disabled, .ios26-disabled) {
width: calc(
100% - calc(18px + var(--ion-safe-area-left, 0px)) - calc(18px + var(--ion-safe-area-left, 0px)) - 60px -
100% - calc(18px + var(--ion-safe-area-left, 0px)) - calc(18px + var(--ion-safe-area-right, 0px)) - 60px -
12px - var(--ios-theme-menu-width, var(--ios26-menu-width))
);

&:has(:nth-child(5)) {
width: calc(
100% - calc(18px + var(--ion-safe-area-left, 0px)) - calc(18px + var(--ion-safe-area-left, 0px)) - var(
100% - calc(18px + var(--ion-safe-area-left, 0px)) - calc(18px + var(--ion-safe-area-right, 0px)) - var(
--ios-theme-menu-width,
var(--ios26-menu-width)
)
Expand All @@ -31,7 +31,7 @@ ion-split-pane.ios:not(.ios-theme-disabled, .ios26-disabled).split-pane-visible:
/*
* 90px: https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/title/title.ios.scss#L8
*/
padding-left: calc(90px + var(--ios-theme-menu-width, var(--ios26-menu-width)));
padding-inline-start: calc(90px + var(--ios-theme-menu-width, var(--ios26-menu-width)));
}
}
ion-content {
Expand All @@ -45,7 +45,10 @@ ion-split-pane.ios:not(.ios-theme-disabled, .ios26-disabled).split-pane-visible:
}
ion-tab-bar.ios:not(.ios-theme-disabled, .ios26-disabled) {
&[slot='bottom'] {
left: calc(16px + var(--ion-safe-area-left, 0px) + var(--ios-theme-menu-width, var(--ios26-menu-width)));
inset-inline-start: calc(16px + var(--ion-safe-area-left, 0px) + var(--ios-theme-menu-width, var(--ios26-menu-width)));
&:dir(rtl) {
inset-inline-start: calc(16px + var(--ion-safe-area-right, 0px) + var(--ios-theme-menu-width, var(--ios26-menu-width)));
}
}
}
}
Expand All @@ -62,7 +65,7 @@ ion-split-pane.ios:not(.ios-theme-disabled, .ios26-disabled).split-pane-visible:
/*
* 90px: https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/title/title.ios.scss#L8
*/
padding-right: calc(90px + var(--ios-theme-menu-width, var(--ios26-menu-width)));
padding-inline-end: calc(90px + var(--ios-theme-menu-width, var(--ios26-menu-width)));
}
}
ion-content {
Expand All @@ -88,10 +91,10 @@ ion-menu.ios:not(.ios-theme-disabled, .ios26-disabled) {
z-index: 999;

&.menu-side-start {
left: 0;
inset-inline-start: 0;
}
&.menu-side-end {
left: calc(100vw - var(--ios-theme-menu-width, var(--ios26-menu-width)));
inset-inline-end: 0;
}

&::part(backdrop) {
Expand Down Expand Up @@ -119,9 +122,13 @@ ion-menu.ios:not(.ios-theme-disabled, .ios26-disabled) {
--ios-theme-content-box-shadow-rgb: var(--ios26-content-box-shadow-rgb);

&::part(scroll) {
margin: calc(var(--ios-theme-floating-safe-area-top, var(--ios26-floating-safe-area-top)) + 6px)
calc(16px + var(--ion-safe-area-right, 0px)) var(--ios-theme-floating-safe-area-bottom, var(--ios26-floating-safe-area-bottom))
calc(12px + var(--ion-safe-area-left, 0px));
margin-block: calc(var(--ios-theme-floating-safe-area-top, var(--ios26-floating-safe-area-top)) + 6px)
var(--ios-theme-floating-safe-area-bottom, var(--ios26-floating-safe-area-bottom));
margin-inline: calc(12px + var(--ion-safe-area-left, 0px)) calc(16px + var(--ion-safe-area-right, 0px));
}

&:dir(rtl)::part(scroll) {
margin-inline: calc(12px + var(--ion-safe-area-right, 0px)) calc(16px + var(--ion-safe-area-left, 0px));
}
}
}
2 changes: 1 addition & 1 deletion src/styles/components/ion-searchbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,6 @@ ion-searchbar.ios:not(.ios-theme-disabled, .ios26-disabled).searchbar-classic {
width: 1.18rem;
}
button.searchbar-clear-button {
right: 8px;
inset-inline-end: 8px;
}
}
24 changes: 14 additions & 10 deletions src/styles/components/ion-tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
@use '../utils/api';

ion-tab-bar.ios:not(.ios-theme-disabled, .ios26-disabled) {
--ios-theme-safe-area-inline-start: var(--ion-safe-area-left, 0px);
--ios-theme-safe-area-inline-end: var(--ion-safe-area-right, 0px);
&:dir(rtl) {
--ios-theme-safe-area-inline-start: var(--ion-safe-area-right, 0px);
--ios-theme-safe-area-inline-end: var(--ion-safe-area-left, 0px);
}
// Ionic forces content-box on the host. Keep the Glass border in a
// separate layer so its physical-pixel rounding cannot resize the bar.
border: 0;
Expand Down Expand Up @@ -29,26 +35,24 @@ ion-tab-bar.ios:not(.ios-theme-disabled, .ios26-disabled) {
&[slot='top'] {
position: absolute;
top: var(--ios-theme-floating-safe-area-top, var(--ios26-floating-safe-area-top));
right: calc(16px + var(--ion-safe-area-right, 0px));
inset-inline-end: calc(16px + var(--ios-theme-safe-area-inline-end));
}

&[slot='bottom'] {
position: absolute;
bottom: var(--ios-theme-floating-safe-area-bottom, var(--ios26-floating-safe-area-bottom));
left: calc(16px + var(--ion-safe-area-left, 0px));
inset-inline-start: calc(16px + var(--ios-theme-safe-area-inline-start));
}

&.tab-bar-position-start,
&.tab-bar-position-end:dir(rtl) {
left: calc(16px + var(--ion-safe-area-left, 0px));
right: auto;
&.tab-bar-position-start {
inset-inline-start: calc(16px + var(--ios-theme-safe-area-inline-start));
inset-inline-end: auto;
margin-inline: 0;
}

&.tab-bar-position-end,
&.tab-bar-position-start:dir(rtl) {
left: auto;
right: calc(16px + var(--ion-safe-area-right, 0px));
&.tab-bar-position-end {
inset-inline-start: auto;
inset-inline-end: calc(16px + var(--ios-theme-safe-area-inline-end));
margin-inline: 0;
}

Expand Down
Loading
Loading