Repository navigation
chore: remove transitional health score v1 compatibility - #2376
Closed
gaspergrom wants to merge 4 commits into
Closed
gaspergrom wants to merge 4 commits into
gaspergrom wants to merge 4 commits into
Conversation
This was referenced Oct 12, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Required upstream PR #4922 remains open and undeployed, so the documented deployment gate is not yet satisfied.
0 open findings
What changed in this PR
Removes transitional Health Score v1 compatibility after the corresponding Tinybird schema cleanup.
Changes:
- Returns Tinybird insight rows directly while preserving the v2
healthScoremapping. - Removes v1 fixture data and legacy tuple-layout tests.
- Deletes obsolete compatibility comments.
| File | Description |
|---|---|
frontend/server/api/project/[slug]/insights.get.ts |
Removes legacy field filtering. |
frontend/server/api/project/[slug]/insights.get.test.ts |
Removes v1 response fixtures and assertions. |
frontend/server/api/project/[slug]/index.test.ts |
Removes the v1 score fixture. |
frontend/server/api/ossindex/ossindex.test.ts |
Tests only the post-v1 tuple layout. |
frontend/server/api/ossindex/categories.ts |
Removes an obsolete compatibility comment. |
frontend/server/api/ossindex/collections.ts |
Removes an obsolete compatibility comment. |
frontend/server/api/ossindex/groups.ts |
Removes an obsolete compatibility comment. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 12, 2026
gaspergrom
force-pushed
the
chore/IN-1222-remove-health-v1-api
branch
from
October 13, 2026 08:41
973b6fe to
d347c1e
Compare
gaspergrom
force-pushed
the
chore/IN-1222-remove-health-v1-transitional
branch
from
October 13, 2026 08:43
a9dcd64 to
f5c76e8
Compare
gaspergrom
force-pushed
the
chore/IN-1222-remove-health-v1-api
branch
from
October 13, 2026 09:18
d347c1e to
1f8e782
Compare
gaspergrom
force-pushed
the
chore/IN-1222-remove-health-v1-transitional
branch
from
October 13, 2026 09:19
f5c76e8 to
f96bd4a
Compare
gaspergrom
force-pushed
the
chore/IN-1222-remove-health-v1-transitional
branch
from
October 13, 2026 10:29
f96bd4a to
07119c8
Compare
gaspergrom
force-pushed
the
chore/IN-1222-remove-health-v1-transitional
branch
from
October 13, 2026 10:35
07119c8 to
db2993b
Compare
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
… test IN-1222 Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
…n routes IN-1222 Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
gaspergrom
force-pushed
the
chore/IN-1222-remove-health-v1-transitional
branch
from
October 13, 2026 11:02
db2993b to
617c7f4
Compare
Merged
9 of 12 tasks
Collaborator
Author
|
Closing for now: org-dashboard still reads the v1 health score ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge until Joana Maia confirms consumer sign-off (LFX One, Org Lens, OD, Self Serve, CNCF) and a deprecation date, and crowd.dev PR 3 (#4922) is deployed.
Summary
GET /api/project/{slug}/insights,GET /api/collection/{slug}/projectsandGET /api/collection/{slug}/project-reposread the Tinybird rows directly. The sharedlegacyScoreFieldsfilter strippedcontributorHealthScore,popularityHealthScore,developmentHealthScoreandsecurityHealthScore; the pipes stop selecting them, so the filter and the list inhealth-score.helpers.tsgo.healthScorestays the rawhealthScoreV2.Changes
frontend/server/api/project/[slug]/insights.get.tslegacyScoreFieldsimport and filter; returns the Tinybird row withhealthScoreset tohealthScoreV2frontend/server/api/project/[slug]/insights.get.test.tshealthScoreand sub-score mocks and the assertions that the handler strips themfrontend/server/api/project/[slug]/index.test.tshealthScoremockfrontend/server/api/project/index.test.tshealthScoremockfrontend/server/helpers/health-score.helpers.tslegacyScoreFieldsexportfrontend/server/api/collection/[slug]/projects.tsfrontend/server/api/collection/[slug]/project-repos.tsfrontend/server/api/collection/[slug]/project-routes.test.tshealthScoreand sub-score mocks and the tests that the routes strip themfrontend/server/api/ossindex/ossindex.test.tsfrontend/server/api/ossindex/categories.tsfrontend/server/api/ossindex/collections.tsfrontend/server/api/ossindex/groups.tsJIRA
IN-1222: Deprecate v1 health score sinks and tables
Related PRs
Deploy order
mainonce chore: remove health score v1 fields and routes #2375 merges.DB migrations
No DB migrations.
Test plan
pnpm lint,pnpm format:check,cd frontend && pnpm tsc-check && pnpm vitest run(366 tests).api/has no changes.To check after this PR deploys, with #4922 live:
GET /api/project/k8s/insightshas none of the four v1 sub-scores, andhealthScoreequalshealthScoreV2.Checklist
git commit --signoff -Son every commitmain