Repository navigation
chore: remove the v1 health score Snowflake sink (IN-1222) - #4921
Draft
gaspergrom wants to merge 1 commit into
Draft
gaspergrom wants to merge 1 commit into
gaspergrom wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Merge depends on external production sign-off and deprecation prerequisites that cannot be verified from this diff.
0 open findings
What changed in this PR
Removes the deprecated v1 health-score Kafka export after downstream migration to v2.
Changes:
- Deletes the production-only
health_score_sinkTinybird pipe. - Retains its datasource and v2 sink.
| File | Description |
|---|---|
services/libs/tinybird/pipes/health_score_sink.pipe |
Removes the scheduled v1 Kafka sink. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Delete health_score_sink.pipe. Its v2 fields are already exported by health_score_v2_sink. The live Tinybird pipe and its 00:30 schedule need `tb pipe rm health_score_sink` on production. Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
gaspergrom
force-pushed
the
chore/IN-1222-remove-health-score-sink
branch
from
October 12, 2026 22:42
dc2ae53 to
b91a223
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge until Joana Maia confirms consumer sign-off (LFX One, Org Lens, OD, Self Serve, CNCF) and a deprecation date — IN-1222 PRE2/PRE4.
Summary
pipes/health_score_sink.pipe. Each day at 00:30 UTC it exported the v1 health score to thehealth_score_sinkKafka topic. The v2 export,health_score_v2_sink, already carries the v2 fields this pipe exported.lfx-oracle-kafka-streamingconnection, so staging never had it.health_score_sinksource. lf-dbt PR 2 moves the v2 columns to the v2 sink, and lf-dbt PR 4 removes the source. This PR waits for both.health_score_copy_ds, stays until crowd.dev PR 3. The Snowflake tables and the connector topic are human steps below.Deploy notes
Prerequisites
Steps
Prod only. Staging never had this pipe.
tb pipe ls.health_score_sinkfrom the Snowflake sink connector (crowd-kube connector runbook), confirm the connector tasks are RUNNING, and delete the OCI streamhealth_score_sink.Cross-repo order
crowd.dev PR 1 is already live, and insights PR 1 deploys after it.
What breaks if out of order
health_score_sinksource freshness check (error_after: 1 day) fails the dbt Cloud job, and the silver health leg goes stale.Related PRs
JIRA
IN-1222: Deprecate v1 health score sinks and tables
https://linuxfoundation.atlassian.net/browse/IN-1222