Skip to content

chore: remove the v1 health score Snowflake sink (IN-1222) - #4921

Draft
gaspergrom wants to merge 1 commit into
mainfrom
chore/IN-1222-remove-health-score-sink
Draft

gaspergrom wants to merge 1 commit into
mainfrom
chore/IN-1222-remove-health-score-sink

Conversation

@gaspergrom

@gaspergrom gaspergrom commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Do not merge until Joana Maia confirms consumer sign-off (LFX One, Org Lens, OD, Self Serve, CNCF) and a deprecation date — IN-1222 PRE2/PRE4.

Summary

  • Deletes pipes/health_score_sink.pipe. Each day at 00:30 UTC it exported the v1 health score to the health_score_sink Kafka topic. The v2 export, health_score_v2_sink, already carries the v2 fields this pipe exported.
  • The pipe exists only in prod. It uses the prod-only lfx-oracle-kafka-streaming connection, so staging never had it.
  • lf-dbt reads this export through its health_score_sink source. lf-dbt PR 2 moves the v2 columns to the v2 sink, and lf-dbt PR 4 removes the source. This PR waits for both.
  • Removes only the pipe. The datasource it reads, health_score_copy_ds, stays until crowd.dev PR 3. The Snowflake tables and the connector topic are human steps below.

Deploy notes

Prerequisites

  • lf-dbt PR 4 is merged and has run in prod.
  • The sign-off gate above is cleared, with a deprecation date.

Steps

Prod only. Staging never had this pipe.

tb pipe rm health_score_sink --yes
  1. Confirm the pipe is gone on prod with tb pipe ls.
  2. The next day, confirm no export ran at 00:30 UTC.
  3. Then the human steps: remove health_score_sink from the Snowflake sink connector (crowd-kube connector runbook), confirm the connector tasks are RUNNING, and delete the OCI stream health_score_sink.

Cross-repo order

crowd.dev PR 1 is already live, and insights PR 1 deploys after it.

  1. lf-dbt PR 1
  2. lf-dbt PR 2
  3. Sign-off gate, then insights PR 2
  4. lf-dbt PR 3
  5. lf-dbt PR 4
  6. crowd.dev PR 2 (this PR)
  7. crowd-kube connector change (human)
  8. Snowflake DROPs (human)
  9. crowd.dev PR 3
  10. insights PR 3: remove transitional v1 compatibility (chore: remove transitional health score v1 compatibility insights#2376, gated)
  11. crowd.dev PR 4

What breaks if out of order

  • Before lf-dbt PR 4 has run in prod: the health_score_sink source freshness check (error_after: 1 day) fails the dbt Cloud job, and the silver health leg goes stale.
  • Before lf-dbt PR 2: lf-dbt's v2 columns still come from this export. Removing it sets them to NULL. The LFX One drawer shows Unscored for every project, and the project recent-progress card shows 0.
  • Deleting the OCI stream before the connector change: one Snowflake sink connector carries every topic. A missing topic fails its task and halts every Snowflake sink, including the v2 sink.

Related PRs

  • crowd.dev PR 1: add health score v2 to project lists and re-source dependency metrics (live)
  • crowd.dev PR 3: remove v1 health score computation and columns from Tinybird (gated)
  • crowd.dev PR 4: remove the v1 repository health score pipes (gated)
  • insights PR 1: show health score v2 in the open source index
  • insights PR 2: remove health score v1 fields and routes (gated)
  • lf-dbt PR 1: expose the v2 sink leg marker on gold project health metrics
  • lf-dbt PR 2: source health score v2 columns from the v2 sink
  • lf-dbt PR 3: drop v1 health score columns from gold, platinum and silver dim (gated)
  • lf-dbt PR 4: remove the v1 health score sink source and silver leg (gated)
  • lfx-self-serve PR (This is a test issue #3465): remove the v1 health band shim
  • crowd-kube connector change (gated, human step): no PR exists yet. In the crowd-kube connector runbook kept with IN-1222, a human removes the topic from the Snowflake sink connector and opens that PR. crowd-kube Add links to dashboard sentiment widget #205 changes docs only.

JIRA

IN-1222: Deprecate v1 health score sinks and tables
https://linuxfoundation.atlassian.net/browse/IN-1222

Copilot AI balanced review requested due to automatic review settings October 12, 2026 20:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Merge depends on external production sign-off and deprecation prerequisites that cannot be verified from this diff.

0 open findings

What changed in this PR

Removes the deprecated v1 health-score Kafka export after downstream migration to v2.

Changes:

  • Deletes the production-only health_score_sink Tinybird pipe.
  • Retains its datasource and v2 sink.
File Description
services/​libs/​tinybird/​pipes/​health_score_sink.pipe Removes the scheduled v1 Kafka sink.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Delete health_score_sink.pipe. Its v2 fields are already exported by health_score_v2_sink. The
live Tinybird pipe and its 00:30 schedule need `tb pipe rm health_score_sink` on production.

Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
@gaspergrom
gaspergrom force-pushed the chore/IN-1222-remove-health-score-sink branch from dc2ae53 to b91a223 Compare October 12, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants