Repository navigation
fix: count last 365 days in the active contributors badge and drop v1 health score copy - #2377
Conversation
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
…r IN-1222 Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
PR SummaryMedium Risk Overview Health Score v1 deprecation in the UI/docs: the project overview methodology banner is removed (component deleted), and the health score docs drop the “How This Differs from the Previous Health Score” section plus wording about replacing the old composite score. Reviewed by Cursor Bugbot for commit cba5550. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
🟢 Approval recommended
The functional changes are consistent and tested; only a non-blocking comment-style cleanup remains.
1 open finding
What changed in this PR
Aligns the active-contributors badge with the share preview’s 365-day calculation and removes obsolete Health Score v1 messaging.
Changes:
- Queries
active_contributorsusing the expected filters and date window. - Adds badge behavior and error-path tests.
- Removes legacy Health Score comparison documentation and banner UI.
| File | Description |
|---|---|
frontend/server/api/badge/active-contributors.ts |
Uses the 365-day active-contributors query. |
frontend/server/api/badge/active-contributors.test.ts |
Tests query parameters, formatting, and 404 behavior. |
frontend/docs/metrics/health-score/index.md |
Removes v1 comparison content. |
frontend/app/components/modules/project/views/overview.vue |
Removes the methodology banner usage. |
frontend/app/components/modules/project/components/overview/health-score-banner.vue |
Deletes the obsolete banner component. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| <!-- TEMPORARILY HIDDEN (IN-1243): original intro described three assessments: "LFX Insights surfaces up to **three independent assessments** for open source projects: a **Lifecycle state**, a **Health Score**, and when applicable an **Impact Score**. Together, these replace the previous single composite score and answer three distinct questions:" Re-enable by uncommenting and removing the two-assessment replacement below. --> | ||
| LFX Insights surfaces **two independent assessments** for open source projects: a **Lifecycle state** and a **Health Score**. Together, these replace the previous single composite score and answer two distinct questions: | ||
| <!-- TEMPORARILY HIDDEN (IN-1243): original intro described three assessments: "LFX Insights surfaces up to **three independent assessments** for open source projects: a **Lifecycle state**, a **Health Score**, and when applicable an **Impact Score**. Together, they answer three distinct questions:" Re-enable by uncommenting and removing the two-assessment replacement below. --> |
…-copy-badge Signed-off-by: Gašper Grom <gasper.grom@gmail.com>

Summary
/api/badge/active-contributors) counts contributors from the last 365 days. It readsactive_contributorswith the same filters and window as the badge preview in the share menu (active-contributor-badge.vue): code contributions on, collaborations off, start 365 days ago, end today. The "Active contributors (1Y)" label and the shields.io redirect stay the same.health-score-banner.vueis deleted. It was the "We updated our Health Score methodology" notice on the project overview, linking readers to that comparison.Why
The badge called
health_score_active_contributors, a health score benchmark pipe, without dates. It showed an all-time count under a "(1Y)" label, so README badges disagreed with the share preview for the same project.The comparison section and the banner describe the v1 score. Once #2374 ships (the Open Source Index pill still reads v1 on main until then), Health Score v2 is the only overall score insights shows.
README badge numbers drop when this deploys. Envoy goes from 5.1K (all time) to about 1.6K (last 365 days).
Changes
frontend/server/api/badge/active-contributors.tscontributorCountfromactive_contributorsfor the last 365 daysfrontend/server/api/badge/active-contributors.test.tsfrontend/docs/metrics/health-score/index.mdfrontend/app/components/modules/project/components/overview/health-score-banner.vuefrontend/app/components/modules/project/views/overview.vueJIRA
IN-1222: Deprecate v1 health score sinks and tables
Related PRs
Deploy order
No ordering constraints.
DB migrations
No DB migrations.
Test plan
active_contributorswithincludeCodeContributions=true,includeCollaborations=falseand a 365-day window, keeps the "(1Y)" label, shows 1,580 as 1.6K, and returns 404 when the pipe has no row.repos=value that matches no repository now shows a "0" badge. The old route returned 404 because its pipe returned no row.pnpm docs:buildpasses with no dead links. Nothing else linked to the removed section.health-score-banner.vue.pnpm lint,pnpm format:check,cd frontend && pnpm tsc-check && pnpm vitest run(321 tests),pnpm build.To check after deploy:
/api/badge/active-contributors?project=envoyredirects with a message near 1.6K./docs/metrics/health-score/ends at the coverage note.Checklist
git commit --signoff -Son every commit