Repository navigation
Project Explorer: receive original worker-safe resource deltas and M3 opt-in path - #38
Merged
Merged
Conversation
hsoliwal
marked this pull request as ready for review
October 22, 2026 04:36
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual Eclipse Project Explorer original-owner receiver
This is an original source modification, not a new viewer, an M3+JDK compatibility wrapper, or an independent model store. M3JDK21 is the integrated Java/JNI product; Synexia owns the reusable recipe and donor catalogue. Eclipse
ResourceExtensionContentProvider, Navigator tests, SWT display/lifetime and JFace APIs stay authoritative.This master-based successor carries the previously reviewed #29 source and tests into the actual
masterline. The old #29 PR was merged/closed withdevelopas base and cannot itself prove those bytes reached master.Exact three source-sealed FILE changes
ResourceExtensionContentProvider.java: oninputChangedthe UI thread publishes one immutableBinding(Viewer, Display); worker-side resource callbacks never call SWTviewer.getControl/isDisposed/getDisplay; queued work executes only on the published display and checks binding identity again after async delivery to refuse stale/disposed receivers.-Dorg.eclipse.ui.navigator.resources.mode=viewport, the original add/remove branch feeds existingM3ViewerDeltaparallel-array lanes and invokes existingM3Viewers.applyon the UI thread. Stock JFace remains the default. Parent/child encounter order, type/open/rename redraw/refresh fallbacks remain present. No new JNI API or per-entry object store.ResourceDeltaThreadingTest.java(new) andNavigatorTestSuite.java: receive reviewed Eclipse M3: fix Project Explorer resource delta threading and opt-in lanes #29 source JUnit regression into original test suite.Exact Git product readback from precommitted canonical outputs:
d554c3bcd5d43b71533d79701b7299a3fd2fec00→3d0f3998b8dc5a83dc9ab57331ea2f8790791db0;fe0e346ae1ca17ec1996a3135054ac82e13e61d7→8efd73a572b22ab784384a6635ac31b8076e0b8e;ABSENT→604b1f634c1d7b247e0254e6722dc82b628968db.All three postimages match GitHub source blobs byte-for-byte.
Reusable canonical source-first recipe, execution boundaries
Synexia #12919 owns the exact three Java21
M3HashPinnedJavaSnapshotRecipedatasets, before/after SHA-256 manifests, original pre fixtures, named YAML, Maven/JUnit SDK replay+fixed-point+drift-refusal test source, categorized algorithm/donor evidence, and an append-only improvement memory;CANONICAL_RECIPE_HOME.tsvregistered all three. No parallel transformation/AST framework.Executed independently: strict JDK21 javac and 85,031 event-loop thread-ownership model checks over 10,000 worker/UI/rebind/dispose trials, source SHA-256
39c240ba4211567029235fe907ca1bb1888e38def87b8fd429e4e577603c02a4. This is NOT an actual Eclipse SWT or Navigator test run.Still NOT_RUN / HOLD: new Maven/OpenRewrite
Recipe.runSDK/fixed-point and receiver, originalNavigatorTestSuiteand full Tycho Java21/25, real GTK/Win32/Cocoa UI event thread native JNI, resource add/remove/move/rename/type/label/viewer selection sequence, thread races/disposal, pixel, CPU/heap/native memory comparisons, and M3JDK21 HotSpot installed-image qualification. Keep draft. Do not enable default viewport or claim full Project Explorer/all-viewer completion.Review order: the independent master-based shared-JFace convergence is UI #36, owned by Synexia #12917. This Project Explorer receiver uses the already existing
M3Viewers.applyand does not require a premature merge of #36.Original Eclipse EPL-2.0 source and test headers remain intact; Synexia first-party recipes Apache-2.0, Copyright 2026 Hitesh Soliwal and Contributors. Challenge sites provide only problem categories, no source code imported. Never rebase Synexia develop, no master direct write, no destructive merge.