Skip to content

JFace viewers and Platform UI views on the M3 viewport: one model, deltas end to end (Markers view first) - #21

Merged
hsoliwal merged 52 commits into
masterfrom
m3/jface-viewport-20261019
Oct 21, 2026
Merged

hsoliwal merged 52 commits into
masterfrom
m3/jface-viewport-20261019

Conversation

@hsoliwal

Copy link
Copy Markdown
Owner

Branch m3/jface-viewport-20261019. Opt-in: -Djface.viewer.mode=viewport (JFace fast paths) and -Dorg.eclipse.ui.ide.markers.mode=viewport (Markers view delta path). Defaults stay stock until the differentials are identical.

What is in here

  • docs/m3/jface-viewport/: DESIGN.md (Layer A stock-API fast paths; Layer B model-side filter/sort on a worker with the superseding debounce; revision 2: one model and deltas end to end), INVENTORY.tsv (every O(n) path with file:line), FOSS_REUSE_DECISION.tsv, PROVENANCE.tsv, evidence/ (loop census, TV_5.0 header census), recipe/ (OpenRewrite hook YAML, second pass UNCHANGED), tools/ (build, bench, differential, all output on S:).
  • org.eclipse.jface: M3ViewerMode, M3FirstIndex, M3IdentityIndex (internal.m3), M3ViewerPaths (viewers) and four one-line recipe hooks (A1 table selection without reveal, A2 table removal, A3 tree stale-item compaction, A4 list selection).
  • org.eclipse.jface.tests: M3ViewerBench (stock vs candidate at 10^4/10^5/10^6), M3ViewerDifferential (seeded scripts; answers, events, provider/comparator/filter call CRCs, widget state, pixel CRC).
  • docs/m3/markers-view/: DESIGN.md, INVENTORY.tsv (K1-K9: the stock clean rebuild per marker change), UPSTREAM_DEFECTS.tsv (per-entry ConcurrentHashMap attribute cache, collation caches, category copies, marker map, clone), recipe hooks, bench bundle and harness on the official 2026-09 bundles.
  • org.eclipse.ui.ide: M3MarkerDeltas (IMarkerDelta lanes, debounced worker prepare, one merge pass per category, tree patch inside the shown windows), M3LongSet, three recipe hooks and one added method (Markers.m3Replace).
  • docs/m3/views/: VIEW_INVENTORY.tsv over all platform.ui views (event source, rebuild evidence with file:line, per-element stores, upstream issues) and PROGRAMME.md (one pattern, one PR per view).

Upstream issues this answers or builds on: eclipse-platform#4404, eclipse-platform#4301, eclipse-platform#4304, eclipse-platform#4469 (Problems view counts walk all markers), eclipse-platform#1093/eclipse-platform#1095/eclipse-platform#1010/eclipse-platform#1626 (viewer limits), eclipse-platform#649 (lazy reveal), eclipse-platform#3728, eclipse-platform#4403; prior art kept: eclipse-platform#4247, eclipse-platform#3733, eclipse-platform#4208/eclipse-platform#2567, eclipse-platform#3527, eclipse-platform#1331.

Status: measurements and differentials run on the hidden desktop and are appended as MEASUREMENTS.tsv and coverage reports; not yet run at the time of opening.

… source, rebuild evidence with file:line, per-element stores, upstream issues) and PROGRAMME.md (one pattern, one PR per view)
…, identity-index, compaction, long set, merge and debounce choices
… and M3ViewerMode (checked against the linear scans), headless test runner with JaCoCo; stock-side test build skips M3-only tests

Copy link
Copy Markdown
Owner Author

Additive CI repair — 2026-10-19

Preservation ref: preserve/pr21-before-nls-repair-20261019 at the original head c6e5ee1763ff24639941532582d274a01a26764e.

Actual source repair committed (no viewer logic/ABI change):

  • Source-pinned Java-21 idempotent recipe docs/m3/jface-viewport/tools/TreeViewerNonNlsRecipe.java in commit b4232f763f0eb32c0290209c7c1e4d4a5119b7ef.
  • Applied exact ten //$NON-NLS-1$ annotations to TreeViewer.java in commit ad4c14532e57c868dd00797305d79ff2adef71f9; original Git blob 88a47bcd2a5f57ebae1fe71bde045daa1637122c, new blob 8e9c66c447f4477845a3179eaa2d5414107b428e.
  • The ten sites correspond to all macOS Tycho JFace non-externalized-string errors in executed job 118063801253. New macOS CI result is pending; do not claim pass until recorded steps complete.

Separately held Windows blocker: executed job 118063800657 fails in Git checkout (Filename too long) under docs/M3-SCALE/jface-forwarding-20261017/tooling/synexia-openrewrite-recipes/recipe-crates/.../resources/...; the deepest directory prefix is 206 characters and contains 12 source-sealed files. The shared upstream reusable mavenBuild.yml checks out before Maven. Do not suppress checks or delete/move this crate without an exact source/manifest/reference-preserving relocation recipe and independent checkout proof.

Production master remains unchanged. Full Linux/Mac/Windows PDE, functional and differential gates remain required before promotion.

…ait loop (the shared copy executes a queue ticket path, exit 127)
…erential snapshot keyed by tag; markers run accepts extra launcher args
…stock TreeViewer refresh throws 'Widget is disposed' in Layer A) instead of ending the run; delta API UI test without the unused counter
… (p2, ECF, bouncycastle, jsvg, slf4j were filtered out, so the workbench never started); two headless warm starts outside the UI lock absorb Equinox's restart request (exit 23); no -clean, no intro, no update check in the measured run
…695 scope set-diff, search lane, flat, flood), debounce from TV_5.0/x86core
…05 viewer API methods, markers-view usage), status columns to fill
…nterned message/location/resource/path, line, created, category lanes; per-category order-statistic slot lists; O(1) counts; facades only for shown windows), deltas patch the lanes and the tree window through M3ViewerDelta; recipe hooks for Markers, CachedMarkerBuilder, content provider and tree viewer; JFace overlay with the delta API; headless tests of M3SlotOrder and M3LabelTable (catalogue: order-statistic list over blocked sorted arrays, interned labels)
…(the revert to error changed infos and the wait timed out); categories expanded as a user works; selection in the differential answers; full-refresh (UI update job) and rebuild counters per delta and per differential phase; resize and column-resize sweeps; M3 counters; m3 side runs the JFace overlay too
…stener2 partHidden/partVisible) as the one helper for every view; the Problems view keeps applying deltas to its lanes while hidden, accumulates the touched categories and changed ids, and applies one window patch on partVisible; bench hidden sweep (minimize, 10^4 changes, restore) with paint and item counters; workbench overlay in the harness
… UIUpdateJob refresh and the clean rebuild PASS for marker deltas in covered states, FAIL in the four fallback states and for selection/working-set scope changes until the set-diff leaf; dialog-local viewers justified); delta census evidence (platform.ui main 433, unchanged: the M3 path removes reachability, not call sites)
…log per side and size, so two runs of one side in different desktop slots never share a configuration area; the overlay build reads any stock configuration
…Visible() are the source of truth for hidden viewports (rule 25); workbench and e4 part visibility are built on them in the renderer; M3PartVisibility is the interim IPartListener2 bridge with the same view contract
… runs (lanes, delta path, viewer delta API, part visibility bridge)
…ception (every earlier answer identical) counts as a stock defect, not a mismatch; Layer A (8 seeds x 6 variants x 60 steps): original 0 mismatches (48 identical), viewport 0 mismatches (34 identical, 14 identical up to stock's TreeViewer 'Widget is disposed' in updateChildren after model-shrink+refresh, recorded as JV-1 in UPSTREAM_DEFECTS.tsv, cf. ui#3728)
…port rows from bench r3 (single run under 3-slot contention, inconclusive); flags viewport-mode table setInput, refresh and filter50 at 10^5 as possible regressions (3-4x slower, filter50 over 60 s) to rerun with median of 5
…he hidden view, what still rebuilds, the proof plan and the files
…gory without a tree item; the content provider's elements are its window; the status message counts from the lanes), closing fallback 3 of FALLBACKS_TO_DELTAS.md; the row patch takes any parent; recipe re-applied to pristine upstream files (the interval sweep had committed the intermediate restore), unnamed variables masked around the OpenRewrite Java 21 parser; ui.ide overlay compiled with JDK 25 (JavaSE-25 on master)
…nd MBean; jcmd cannot attach to a JVM on the hidden desktop and blocked the run until its timeout); each run snapshots the bench and overlay jars into its own configuration, so rebuilds never touch a queued or running run
…d filters too (select() evaluates each group's selectByScope against the current selection per changed marker, the same membership a clean rebuild computes); selection and working-set changes remain scope changes for the set-diff leaf
…_LEDGER rows (median per side, metric and size)
…iew.id, element, source adapter, lanes name:type, group alternatives, sort keys with desc, filters with built-in scope/text, counts, presentation, label; unknown keys, lanes and adapters are errors with line numbers); ProblemsView.m3view, the Problems view's spec; headless tests, 124/125 lines covered
… diff a gather against the lanes (two-pointer merge of sorted ids) and apply only the markers that entered or left as one delta; an unchanged shown set makes no update at all; a changed marker limit still rebuilds; recipe hooks MarkerContentGenerator.requestMarkerUpdate and CachedMarkerBuilder.WorkingSetListener (correction sites CachedMarkerBuilder.java:593/607)
…les.info alone decides the installed jars (cascading onto the install's shared configuration kept the pool's org.eclipse.ui.ide, jface and workbench: every earlier m3 run measured stock code); bench scope sweep pending
…on a file and on the project; Bug 296695 path) with full-refresh and rebuild counters
…tion, not viewport mode (viewport mode only changes remove and select paths)
…elta_status 61 DELTA / 114 FACADE / 118 STOCK_OK / 12 TODO (viewer-side filters and comparators, for the generic tree-view test); differential PASS for the 62 methods JFace Layer A drives (0 mismatches), 243 TODO until the Problems view differential and the generic test; delta_gate 287 PASS, 18 JUSTIFIED (refresh/setInput entry points)
…, lanes as the model, windowed content provider, one delta patch per result with hidden-view and scope diffs)
…resume checklist) for Codex or a fresh session
…suses with branch status: 73 open, 1 changed)
…er before the limit, deltas evaluate the hit per changed row); search steps in the differential; headless tests on JDK 25
@hsoliwal
hsoliwal marked this pull request as ready for review October 21, 2026 01:11
@hsoliwal
hsoliwal merged commit 10da6cc into master Oct 21, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant